Add kfdef 1.2 manifests for Azure#1625
Conversation
* image gcr.io/kubeflow-images-public/tf_operator:vmaster-gd455e6ef * Image built from kubeflow/kubeflow@d455e6ef
…6b (#935) * image gcr.io/kubeflow-images-public/notebook-controller:vmaster-gb629b36b * Image built from kubeflow/kubeflow@b629b36b
* We want to start pinning the v1.0.0 configs to a specific commit of kubeflow/manifests so that we get stability. This is discussed more in #4685. * We will create patch releases 1.0.X as needed. * I created a release tag which points at the appropriate stable release. * Related to #4685 cut 1.0 RC
…be (#938) * image gcr.io/kubeflow-images-public/notebook-controller:vmaster-g915b84be * Image built from kubeflow/kubeflow@915b84be
…955) * image gcr.io/kubeflow-images-public/centraldashboard:vmaster-gf39279c0 * Image built from kubeflow/kubeflow@f39279c0
…c0 (#954) * image gcr.io/kubeflow-images-public/notebook-controller:vmaster-gf39279c0 * Image built from kubeflow/kubeflow@f39279c0
…884) * image gcr.io/kubeflow-images-public/jupyter-web-app:vmaster-gd9be4b9e * Image built from kubeflow/kubeflow@d9be4b9e
…n GPU node pools (#941)
* Fix pipeline default service account * Fix namespace
* updating dex container image * adding images back to kustomization * updating to latest dex image tag
* Adds kfserving ingressgateway for Istio 1.1.6 Modifies KFServing and KNative Serving config-maps to use this gateway * Updates configs for Istio 1.1.6 * Updates tests for istio 1.1.6 * Adding kfserving gateway to kfdefs having istio-1-1-6 * Gateway name correction for kfserving config * Adds HPA config to gateway
* v1.0.1 patch manifests * fix version
* Adds necessary roles and roleBindings to Spark service account * Rename spark service account to match examples service account
* OWNERS for pipeline folder * Update OWNERS * Update OWNERS * Update OWNERS * Update OWNERS
* kubeflow asm config * exp config for GCP setup * update tests * exp kfdef should use master * resolve comments * remove exp DM entry * add reeadme; rename folder
* Fix the aws vpc over manifest. * It looks like there is a bug in the VPC overlay for AWS. It looks like VPC is a patch but it is listed as a resource. * This PR changes the kustomization.yaml file to list VPC.yaml as a patch and not a resource. * Shorten the name of the workflows to fix the tests #1012. * The PR numbers are now 4 digits (XXXX) as a result the worklfow names exceeded the Kubernetes limits and the tests aren't running.
* Move pipeline runner override to gcp overlay * Update overlay name to use-kf-user * Remove not needed test
* Add kfdef 1.2 manifests * Add README.md
* add kfp-tekton deployment and update IBM stacks * update owner file
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: berndverst The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@eedorenko @sudivate @yilun-msft can you add your consent here? It's a bit silly because your commits are already in the v1.1.0 branch. I'm bringing everything into master so that in the future new release branches will already have our base config files and we only need to contribute changes if any. This PR includes a change for v.1.2.0 we can use for testing on Azure. See above. |
|
Can you ask Azure folks to help review the PR? Once they confirm, I can help approve it |
|
If your teammates doesn't mind, you can rewrite commits writers and that's the most easiest way |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
* kfdef for azure * kfdef for azure * Axure kfdef * argo version update * Owners * OWNERS * argo version * Tickle owners * Tickle owners
* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml * intial kdef * indentation * eof * eof * eof * eof * eof * adding istio to azure stack * indentation * update URI * Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml * placeholder for azure ad values
* Add readme file * Add Azure overlay for metadata * Add azure overlay and readme file * Changed the default metadata db name to be metadata-db * Remove duplicated file * Few edits when proofreading the readme.md * Adding db name to be optional * move the overlay to azure stack folder * using relative path for metadata folder
Will be responsible for maintaining manifests for KFServing, OpenShift, IKS etc. PRs merged: kubeflow#1515 kubeflow#1575 kubeflow#1580 kubeflow#1617 Reviews: kubeflow#1582 kubeflow#1621 kubeflow#1625 kubeflow#1627 kubeflow#1628 kubeflow/kfctl#419
|
Clearly I don't know how to update the commit author correctly 😭 . @Jeffwan |
…ous (#1633) * Add Azure owners (#1524) * Create v1.1.0 Azure Kfdef manifests (#1487) * kfdef for azure * kfdef for azure * Axure kfdef * argo version update * Owners * OWNERS * argo version * Tickle owners * Tickle owners * Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD (#1576) * Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml * intial kdef * indentation * eof * eof * eof * eof * eof * adding istio to azure stack * indentation * update URI * Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml * placeholder for azure ad values * Add overlay to support Azure Database for MySQL (#1587) * Add readme file * Add Azure overlay for metadata * Add azure overlay and readme file * Changed the default metadata db name to be metadata-db * Remove duplicated file * Few edits when proofreading the readme.md * Adding db name to be optional * move the overlay to azure stack folder * using relative path for metadata folder * Add Azure kfdef 1.2 manifests * Remove Tensorboard from Azure Stack * Adding myself as Azure stack approver
20 participants
Which issue is resolved by this Pull Request:
Resolves #1597 for Azure
Description of your changes:
Copying the approach of @Jeffwan in #1620 for Azure:
Adds two Azure manifests files for v1.2.0 identical to v1.1.0 except the manifest resource now points to the v.1.2.0 branch.
Note this merges several existing Azure specific commits from the v1.1.0 branch into Master
Eventually these commits will be cherry picked into the v1.2.0 branch.
Checklist:
cd manifests/testsmake generate-changed-onlymake testNote that tests are currently broken in master it appears (or in v1.1.0) - I'm not introducing any testing changes. Could someone help look into this?