Fix pipeline default service account#969
Conversation
|
/assign @jlewi |
|
/retest |
|
Strange, I got error: I guess when referring to a service account not defined in the same kustomize package, it must have a namespace. |
|
I'm not sure this is the right fix, because it seems https://github.com/kubeflow/kfctl/search?q=kf-user&unscoped_q=kf-user I think we'd need a solution to let each application flexibly define what service account needs what binding in their yamls. KCC can support that for GCP, we'd need something similar. |
|
The error message seems irrelevant, will retry again. |
| # temporarily switched to kf-user, because pipeline-runner isn't bound to workload identity by default | ||
| - kind: ServiceAccount | ||
| name: kf-user | ||
| namespace: kubeflow |
|
The failed step cannot pull image: gcr.io/kubeflow-ci/test-worker-py3:789005d. |
|
/lgtm |
|
/retest |
|
@Bobgy the test is fixed :) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! @jlewi @gabrielwen |
Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#4803
Description of your changes:
kf-useras pipeline default sa.pipeline-runnerclusterrole tokf-userto avoid breaking existing usages.Checklist:
cd manifests/testsmake generate-changed-onlymake testThis change is