Add overlay to support Azure Database for MySQL#1587
Conversation
|
Hi @yilun-msft. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
/assign @eedorenko, @sudivate, @shbijlan |
eedorenko
left a comment
There was a problem hiding this comment.
I think we need:
- Copy content of metadata/overlays/azure to stacks/azure/metadata so we keep everything Azure specific in one folder.
- Reference stacks/azure/metadata from kustomization.yaml. Perhaps optionally (aka uncomment this if you want to use ...)
- Update installation guide on the Kubeflow website with what you have in Readme.md.
|
/assign eedorenko |
Eugene, do you mean move metadata/overlays/azure to stacks/azure/metadata or copy them? I will go ahead and document them in kubeflow/website |
|
I mean move. |
|
A meta comment on how the validation is done: I created an Azure Database for MySQL: kf-test.mysql.database.azure.com and edit the kustomization to use ./metadata as instructed in the Readme.md. Execute a pipeline and verify the metadata changes in the selected database named "mlmetadata" |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eedorenko, yilun-msft The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ous (#1633) * Add Azure owners (#1524) * Create v1.1.0 Azure Kfdef manifests (#1487) * kfdef for azure * kfdef for azure * Axure kfdef * argo version update * Owners * OWNERS * argo version * Tickle owners * Tickle owners * Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD (#1576) * Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml * intial kdef * indentation * eof * eof * eof * eof * eof * adding istio to azure stack * indentation * update URI * Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml * placeholder for azure ad values * Add overlay to support Azure Database for MySQL (#1587) * Add readme file * Add Azure overlay for metadata * Add azure overlay and readme file * Changed the default metadata db name to be metadata-db * Remove duplicated file * Few edits when proofreading the readme.md * Adding db name to be optional * move the overlay to azure stack folder * using relative path for metadata folder * Add Azure kfdef 1.2 manifests * Remove Tensorboard from Azure Stack * Adding myself as Azure stack approver
* Cherry-Pick 'Azure kfdef manifests for 1.2 and previous (#1633)' * Add Azure owners (#1524) * Create v1.1.0 Azure Kfdef manifests (#1487) * kfdef for azure * kfdef for azure * Axure kfdef * argo version update * Owners * OWNERS * argo version * Tickle owners * Tickle owners * Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD (#1576) * Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml * intial kdef * indentation * eof * eof * eof * eof * eof * adding istio to azure stack * indentation * update URI * Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml * placeholder for azure ad values * Add overlay to support Azure Database for MySQL (#1587) * Add readme file * Add Azure overlay for metadata * Add azure overlay and readme file * Changed the default metadata db name to be metadata-db * Remove duplicated file * Few edits when proofreading the readme.md * Adding db name to be optional * move the overlay to azure stack folder * using relative path for metadata folder * Add Azure kfdef 1.2 manifests * Remove Tensorboard from Azure Stack * Adding myself as Azure stack approver * Cherry-Pick 'Update azure stack for tests' * Cherry-Pick 'Add Azure stack tests' * Add additional Azure test data
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Create an Azure metadata overlay to use Azure MySQL and provide a readme.md as the instruction. Detailed instruction would be seen in the Readme.md. This would enable Azure MySQL user to use Azure MySQL as the metadata db.
Checklist:
cd manifests/testsmake generate-changed-onlymake test