Skip to content

Add overlay to support Azure Database for MySQL#1587

Merged
k8s-ci-robot merged 10 commits into
kubeflow:v1.1-branchfrom
yilun-msft:yilun/azure_overlay_mysql
Oct 27, 2020
Merged

Add overlay to support Azure Database for MySQL#1587
k8s-ci-robot merged 10 commits into
kubeflow:v1.1-branchfrom
yilun-msft:yilun/azure_overlay_mysql

Conversation

@yilun-msft

Copy link
Copy Markdown

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Create an Azure metadata overlay to use Azure MySQL and provide a readme.md as the instruction. Detailed instruction would be seen in the Readme.md. This would enable Azure MySQL user to use Azure MySQL as the metadata db.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @yilun-msft. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla

google-cla Bot commented Oct 19, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yilun-msft

Copy link
Copy Markdown
Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes and removed cla: no labels Oct 19, 2020
@yilun-msft

Copy link
Copy Markdown
Author

/assign @eedorenko, @sudivate, @shbijlan

@eedorenko eedorenko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need:

  • Copy content of metadata/overlays/azure to stacks/azure/metadata so we keep everything Azure specific in one folder.
  • Reference stacks/azure/metadata from kustomization.yaml. Perhaps optionally (aka uncomment this if you want to use ...)
  • Update installation guide on the Kubeflow website with what you have in Readme.md.

@eedorenko

Copy link
Copy Markdown

/assign eedorenko

@yilun-msft

Copy link
Copy Markdown
Author

I think we need:

  • Copy content of metadata/overlays/azure to stacks/azure/metadata so we keep everything Azure specific in one folder.
  • Reference stacks/azure/metadata from kustomization.yaml. Perhaps optionally (aka uncomment this if you want to use ...)
  • Update installation guide on the Kubeflow website with what you have in Readme.md.

Eugene, do you mean move metadata/overlays/azure to stacks/azure/metadata or copy them? I will go ahead and document them in kubeflow/website

@eedorenko

Copy link
Copy Markdown

I mean move.

@yilun-msft

Copy link
Copy Markdown
Author

A meta comment on how the validation is done: I created an Azure Database for MySQL: kf-test.mysql.database.azure.com and edit the kustomization to use ./metadata as instructed in the Readme.md. Execute a pipeline and verify the metadata changes in the selected database named "mlmetadata"

@yilun-msft yilun-msft changed the title Yilun/azure overlay mysql Add overlay to support Azure Database for MySQL Oct 22, 2020
@eedorenko

Copy link
Copy Markdown

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eedorenko, yilun-msft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 29015ff into kubeflow:v1.1-branch Oct 27, 2020
k8s-ci-robot pushed a commit that referenced this pull request Nov 12, 2020
…ous (#1633)

* Add Azure owners (#1524)

* Create v1.1.0 Azure Kfdef manifests (#1487)

* kfdef for azure

* kfdef for azure

* Axure kfdef

* argo version update

* Owners

* OWNERS

* argo version

* Tickle owners

* Tickle owners

* Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD  (#1576)

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml

* intial kdef

* indentation

* eof

* eof

* eof

* eof

* eof

* adding istio to azure stack

* indentation

* update URI

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml

* placeholder for azure ad  values

* Add overlay to support Azure Database for MySQL (#1587)

* Add readme file

* Add Azure overlay for metadata

* Add azure overlay and readme file

* Changed the default metadata db name to be metadata-db

* Remove duplicated file

* Few edits when proofreading the readme.md

* Adding db name to be optional

* move the overlay to azure stack folder

* using relative path for metadata folder

* Add Azure kfdef 1.2 manifests

* Remove Tensorboard from Azure Stack

* Adding myself as Azure stack approver
k8s-ci-robot pushed a commit that referenced this pull request Nov 13, 2020
* Cherry-Pick 'Azure kfdef manifests for 1.2 and previous (#1633)'

* Add Azure owners (#1524)

* Create v1.1.0 Azure Kfdef manifests (#1487)

* kfdef for azure

* kfdef for azure

* Axure kfdef

* argo version update

* Owners

* OWNERS

* argo version

* Tickle owners

* Tickle owners

* Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD  (#1576)

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml

* intial kdef

* indentation

* eof

* eof

* eof

* eof

* eof

* adding istio to azure stack

* indentation

* update URI

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml

* placeholder for azure ad  values

* Add overlay to support Azure Database for MySQL (#1587)

* Add readme file

* Add Azure overlay for metadata

* Add azure overlay and readme file

* Changed the default metadata db name to be metadata-db

* Remove duplicated file

* Few edits when proofreading the readme.md

* Adding db name to be optional

* move the overlay to azure stack folder

* using relative path for metadata folder

* Add Azure kfdef 1.2 manifests

* Remove Tensorboard from Azure Stack

* Adding myself as Azure stack approver

* Cherry-Pick 'Update azure stack for tests'

* Cherry-Pick 'Add Azure stack tests'

* Add additional Azure test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants