remove ambassador annotations from pipelines-ui manifest#951
Conversation
|
Hi @theofpa. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
I think it's safe to remove this since ambassador has been deprecated for 2 version |
|
/lgtm |
|
It's better to bring folks working pipeline to help review. Not sure any standalone pipeline user will still use it |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue is resolved by this Pull Request:
Resolves #671
Description of your changes:
Remove the ambassador annotations from the manifest of the pipelines-ui service
Checklist:
cd manifests/testsmake generate-changed-onlymake testThis change is