Skip to content

remove ambassador annotations from pipelines-ui manifest#951

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
theofpa:master
Feb 26, 2020
Merged

remove ambassador annotations from pipelines-ui manifest#951
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
theofpa:master

Conversation

@theofpa

@theofpa theofpa commented Feb 25, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #671

Description of your changes:
Remove the ambassador annotations from the manifest of the pipelines-ui service

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @theofpa. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan

Jeffwan commented Feb 25, 2020

Copy link
Copy Markdown
Member

/ok-to-test

@Jeffwan

Jeffwan commented Feb 26, 2020

Copy link
Copy Markdown
Member

I think it's safe to remove this since ambassador has been deprecated for 2 version

@Jeffwan

Jeffwan commented Feb 26, 2020

Copy link
Copy Markdown
Member

/lgtm

@Jeffwan

Jeffwan commented Feb 26, 2020

Copy link
Copy Markdown
Member

It's better to bring folks working pipeline to help review. Not sure any standalone pipeline user will still use it

@jlewi

jlewi commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9c71dfa into kubeflow:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Ambassador annotations from pipelines-ui manifest

5 participants