Pin IBM v1.2 manifests#1627
Merged
Merged
Conversation
Merged
1 task
Member
Author
|
/cc @animeshsingh |
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Contributor
|
thanks @Tomcli /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pvaneck
reviewed
Nov 10, 2020
pvaneck
left a comment
pvaneck
left a comment
Member
There was a problem hiding this comment.
Looks good! Good catch removing the tensorboard section.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 10, 2020
…and update IBM stacks (#1628) * add kfp-tekton deployment and update IBM stacks * update owner file * pin ibm v1.2 manifests * Apply suggestions from code review Co-authored-by: Animesh Singh <singhan@us.ibm.com> Co-authored-by: Animesh Singh <singhan@us.ibm.com>
animeshsingh
added a commit
to animeshsingh/manifests
that referenced
this pull request
Nov 11, 2020
Will be responsible for maintaining manifests for KFServing, OpenShift, IKS etc. PRs merged: kubeflow#1515 kubeflow#1575 kubeflow#1580 kubeflow#1617 Reviews: kubeflow#1582 kubeflow#1621 kubeflow#1625 kubeflow#1627 kubeflow#1628 kubeflow/kfctl#419
Merged
Member
|
Do you want to backport to v1.2-branch or you will like to use master in the future? |
Member
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
The IBM 1.2 manifests are based on 1.1 which didn't include our latest changes such as App ID and Tekton. Therefore, pin the IBM 1.2 manifests with the latest kfdef.
Checklist:
cd manifests/testsmake generate-changed-onlymake test