Add OWNERS file under test folder#947
Merged
Merged
Conversation
Member
Author
|
/cc @jlewi |
Contributor
|
@Jeffwan Thank you so much for taking the initiative and doing this. I know its a small change; but getting in the habit of creating finer scoped OWNERs files is really critical to maintaining project health and scaling /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
added a commit
to Jeffwan/manifests
that referenced
this pull request
Feb 28, 2020
1 task
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 4, 2020
…961) * Create overlay allowing the Load Balancer to be created with HTTPS with it handling no auth. Additionally making the scheme (internet facing/internal) configurable and adding external-dns annotation for clusters with it installed. Cleaned up some duplicated annotations as well (#653) * Upgrade aws component version (#890) * Upgrade aws components versions for v1.0 * Update tests for aws components * Add policy profile controller plugin need (#917) * Add external mysql option for pipeline and metadata (#906) * Add OWNERS file under test folder (#947) * Fixing loadBalancerScheme issue in ingress annotation (#952) * Fix AWS OIDC settings (#953)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Current problem is if user change aws manifest, I can not approve PRs.
This allows me to approve changes under
awsfolder.Description of your changes:
Add OWNERS file under
testfolderChecklist:
cd manifests/testsmake generate-changed-onlymake testThis change is