Skip to content

Conversation

@shalinisudarsan
Copy link

@shalinisudarsan shalinisudarsan commented Jan 6, 2026

https://github.com/jenkinsci/jenkins/issues?q=state%3Aclosed%20label%3A2.541.1-fixed

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@welcome
Copy link

welcome bot commented Jan 6, 2026

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@github-actions github-actions bot added the into-lts This PR is filed against an LTS branch label Jan 6, 2026
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for unexpected update of NodeJS version and unexpected backport of the Java 17 removal.

@NotMyFault
Copy link
Member

NotMyFault commented Jan 6, 2026

Please drop the commit 5afa4b4 and update the PR description as the tool generates.

daniel-beck and others added 7 commits January 7, 2026 17:36
* Add telemetry for Content Security Policy

* Add license header

* Add header length

---------

Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 88fdfa9)
Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 67db131)
… response header can be >30KB (jenkinsci#25901)

Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 52e050e)
…enkinsci#25968)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
(cherry picked from commit c54a0b3)
Partially reverts 331c768.

In jenkinsci#8960 the `out` id was added to `pre.console-output`'s  "otherwise"
case in `console.jelly`.

In 331c768, the `out` id was removed from `otherwise` when console output
was moved from `console.jelly` to `console-log.jelly`.

This may have broken the "Copy" button in some instances.

When clicked, the copy button will copy the inner text of a container
with the id referred to by the `ref` attribute of the copy button. The
copy button's ref attribute is `out`.

Wikimedia's Jenkins has no element with the `out` id on the console
page, which leads to copying `null` to the clipboard.

This was filed as https://phabricator.wikimedia.org/T410633.

Co-authored-by: Mark Waite <[email protected]>
(cherry picked from commit abecec2)
…kinsci#26004)

* Use absolute URL in Cloud sidepanel

The urls in the sidepanel of a cloud are relative. When an action is
added to the cloud these urls lead to a 404 as the action has a
different path.

fixes jenkinsci#26002

* Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Co-authored-by: Alexander Brandes <[email protected]>

---------

Co-authored-by: Alexander Brandes <[email protected]>
(cherry picked from commit ffc46de)
Reinstantiate telemetry for Java properties

Signed-off-by: Alexander Brandes <[email protected]>
(cherry picked from commit 2e58b23)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
(cherry picked from commit eea060c)
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on multiple Windows machines in my test environment and confirmed that this is ready to merge. Yes, even my fastest Windows machines in my test environment still need 3 hours to complete the tests, but they ran to completion. No surprises. Ready to merge.

@MarkEWaite MarkEWaite merged commit 03f54f7 into jenkinsci:stable-2.541 Jan 9, 2026
12 of 15 checks passed
@krisstern
Copy link
Member

Thanks @MarkEWaite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

into-lts This PR is filed against an LTS branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants