-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Backport 2.541.1 #26070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 2.541.1 #26070
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes for unexpected update of NodeJS version and unexpected backport of the Java 17 removal.
|
Please drop the commit 5afa4b4 and update the PR description as the tool generates. |
4fef347 to
d220ed4
Compare
* Add telemetry for Content Security Policy * Add license header * Add header length --------- Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 88fdfa9)
Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 67db131)
… response header can be >30KB (jenkinsci#25901) Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 52e050e)
…enkinsci#25968) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit c54a0b3)
Partially reverts 331c768. In jenkinsci#8960 the `out` id was added to `pre.console-output`'s "otherwise" case in `console.jelly`. In 331c768, the `out` id was removed from `otherwise` when console output was moved from `console.jelly` to `console-log.jelly`. This may have broken the "Copy" button in some instances. When clicked, the copy button will copy the inner text of a container with the id referred to by the `ref` attribute of the copy button. The copy button's ref attribute is `out`. Wikimedia's Jenkins has no element with the `out` id on the console page, which leads to copying `null` to the clipboard. This was filed as https://phabricator.wikimedia.org/T410633. Co-authored-by: Mark Waite <[email protected]> (cherry picked from commit abecec2)
…kinsci#26004) * Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <[email protected]> --------- Co-authored-by: Alexander Brandes <[email protected]> (cherry picked from commit ffc46de)
Reinstantiate telemetry for Java properties Signed-off-by: Alexander Brandes <[email protected]> (cherry picked from commit 2e58b23)
d220ed4 to
a12e1e7
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit eea060c)
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked on multiple Windows machines in my test environment and confirmed that this is ready to merge. Yes, even my fastest Windows machines in my test environment still need 3 hours to complete the tests, but they ran to completion. No surprises. Ready to merge.
|
Thanks @MarkEWaite! |
https://github.com/jenkinsci/jenkins/issues?q=state%3Aclosed%20label%3A2.541.1-fixed
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.