-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Allow entirely disabling CSP headers #23915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FTR https://github.com/jenkinsci/winstone/blob/8b42b1b79bf79ab99a7d58c37b73e6a45e6336fc/README.md#L97 would be another solution in pathological situations. |
A1exKH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Noting #25900 |
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 67db131)
Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 67db131)
Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 67db131)
Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 67db131)
Co-authored-by: Daniel Beck <[email protected]> (cherry picked from commit 67db131)
Fixes #23914.
Testing done
Autotest, basic manual test.
Proposed changelog entries
Proposed changelog category
/label rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.