Skip to content

Conversation

@daniel-beck
Copy link
Member

Fixes #23914.

Testing done

Autotest, basic manual test.

Proposed changelog entries

  • Allow entirely disabling CSP headers to work around unusual Jenkins configurations resulting in excessive HTTP response header lengths.

Proposed changelog category

/label rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Dec 6, 2025
@daniel-beck
Copy link
Member Author

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daniel-beck
Copy link
Member Author

FTR https://github.com/jenkinsci/winstone/blob/8b42b1b79bf79ab99a7d58c37b73e6a45e6336fc/README.md#L97 would be another solution in pathological situations.

Noting #25900

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 11, 2025
@timja timja merged commit 67db131 into jenkinsci:master Dec 11, 2025
18 checks passed
@daniel-beck daniel-beck deleted the allow-disabling-csp branch December 11, 2025 14:44
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jan 3, 2026
Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 67db131)
shalinisudarsan pushed a commit to shalinisudarsan/jenkins that referenced this pull request Jan 6, 2026
Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 67db131)
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jan 7, 2026
Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 67db131)
@MarkEWaite MarkEWaite mentioned this pull request Jan 7, 2026
14 tasks
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jan 7, 2026
Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 67db131)
shalinisudarsan pushed a commit to shalinisudarsan/jenkins that referenced this pull request Jan 8, 2026
Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit 67db131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow disabling CSP headers entirely to work around problems in unusual environments

4 participants