Skip to content

Use rootURL in Cloud sidepanel so links in actions work properly#26004

Merged
MarkEWaite merged 2 commits intojenkinsci:masterfrom
mawinter69:issue-26002
Jan 2, 2026
Merged

Use rootURL in Cloud sidepanel so links in actions work properly#26004
MarkEWaite merged 2 commits intojenkinsci:masterfrom
mawinter69:issue-26002

Conversation

@mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Dec 28, 2025

The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path.

Fixes #26002

Testing done

Manual verified in the generated html that the urls now include the full path and deleting a cloud works as expected.

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Use rootURL in Cloud sidepanel so links in actions work properly.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

The urls in the sidepanel of a cloud are relative. When an action is
added to the cloud these urls lead to a 404 as the action has a
different path.

fixes jenkinsci#26002
@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Dec 28, 2025
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@NotMyFault NotMyFault requested a review from a team December 29, 2025 09:02
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja
Copy link
Member

timja commented Dec 29, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 29, 2025
@MarkEWaite MarkEWaite merged commit ffc46de into jenkinsci:master Jan 2, 2026
18 checks passed
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jan 3, 2026
…kinsci#26004)

* Use absolute URL in Cloud sidepanel

The urls in the sidepanel of a cloud are relative. When an action is
added to the cloud these urls lead to a 404 as the action has a
different path.

fixes jenkinsci#26002

* Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Co-authored-by: Alexander Brandes <[email protected]>

---------

Co-authored-by: Alexander Brandes <[email protected]>
(cherry picked from commit ffc46de)
shalinisudarsan pushed a commit to shalinisudarsan/jenkins that referenced this pull request Jan 6, 2026
…kinsci#26004)

* Use absolute URL in Cloud sidepanel

The urls in the sidepanel of a cloud are relative. When an action is
added to the cloud these urls lead to a 404 as the action has a
different path.

fixes jenkinsci#26002

* Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Co-authored-by: Alexander Brandes <[email protected]>

---------

Co-authored-by: Alexander Brandes <[email protected]>
(cherry picked from commit ffc46de)
@MarkEWaite
Copy link
Contributor

MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jan 7, 2026
…kinsci#26004)

* Use absolute URL in Cloud sidepanel

The urls in the sidepanel of a cloud are relative. When an action is
added to the cloud these urls lead to a 404 as the action has a
different path.

fixes jenkinsci#26002

* Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Co-authored-by: Alexander Brandes <[email protected]>

---------

Co-authored-by: Alexander Brandes <[email protected]>
(cherry picked from commit ffc46de)
@MarkEWaite MarkEWaite mentioned this pull request Jan 7, 2026
14 tasks
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jan 7, 2026
…kinsci#26004)

* Use absolute URL in Cloud sidepanel

The urls in the sidepanel of a cloud are relative. When an action is
added to the cloud these urls lead to a 404 as the action has a
different path.

fixes jenkinsci#26002

* Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Co-authored-by: Alexander Brandes <[email protected]>

---------

Co-authored-by: Alexander Brandes <[email protected]>
(cherry picked from commit ffc46de)
shalinisudarsan pushed a commit to shalinisudarsan/jenkins that referenced this pull request Jan 8, 2026
…kinsci#26004)

* Use absolute URL in Cloud sidepanel

The urls in the sidepanel of a cloud are relative. When an action is
added to the cloud these urls lead to a 404 as the action has a
different path.

fixes jenkinsci#26002

* Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Co-authored-by: Alexander Brandes <[email protected]>

---------

Co-authored-by: Alexander Brandes <[email protected]>
(cherry picked from commit ffc46de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloud sidepanel uses relative urls causing 404 in actions attached to the cloud

4 participants