Use rootURL in Cloud sidepanel so links in actions work properly#26004
Merged
MarkEWaite merged 2 commits intojenkinsci:masterfrom Jan 2, 2026
Merged
Use rootURL in Cloud sidepanel so links in actions work properly#26004MarkEWaite merged 2 commits intojenkinsci:masterfrom
MarkEWaite merged 2 commits intojenkinsci:masterfrom
Conversation
The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002
Co-authored-by: Alexander Brandes <[email protected]>
NotMyFault
approved these changes
Dec 29, 2025
Member
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
MarkEWaite
pushed a commit
to MarkEWaite/jenkins
that referenced
this pull request
Jan 3, 2026
…kinsci#26004) * Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <[email protected]> --------- Co-authored-by: Alexander Brandes <[email protected]> (cherry picked from commit ffc46de)
shalinisudarsan
pushed a commit
to shalinisudarsan/jenkins
that referenced
this pull request
Jan 6, 2026
…kinsci#26004) * Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <[email protected]> --------- Co-authored-by: Alexander Brandes <[email protected]> (cherry picked from commit ffc46de)
Contributor
MarkEWaite
pushed a commit
to MarkEWaite/jenkins
that referenced
this pull request
Jan 7, 2026
…kinsci#26004) * Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <[email protected]> --------- Co-authored-by: Alexander Brandes <[email protected]> (cherry picked from commit ffc46de)
14 tasks
MarkEWaite
pushed a commit
to MarkEWaite/jenkins
that referenced
this pull request
Jan 7, 2026
…kinsci#26004) * Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <[email protected]> --------- Co-authored-by: Alexander Brandes <[email protected]> (cherry picked from commit ffc46de)
shalinisudarsan
pushed a commit
to shalinisudarsan/jenkins
that referenced
this pull request
Jan 8, 2026
…kinsci#26004) * Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <[email protected]> --------- Co-authored-by: Alexander Brandes <[email protected]> (cherry picked from commit ffc46de)
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path.
Fixes #26002
Testing done
Manual verified in the generated html that the urls now include the full path and deleting a cloud works as expected.
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.