Skip to content

Commit abecec2

Browse files
Re-add out id to Console Output (jenkinsci#25953)
Partially reverts 331c768. In jenkinsci#8960 the `out` id was added to `pre.console-output`'s "otherwise" case in `console.jelly`. In 331c768, the `out` id was removed from `otherwise` when console output was moved from `console.jelly` to `console-log.jelly`. This may have broken the "Copy" button in some instances. When clicked, the copy button will copy the inner text of a container with the id referred to by the `ref` attribute of the copy button. The copy button's ref attribute is `out`. Wikimedia's Jenkins has no element with the `out` id on the console page, which leads to copying `null` to the clipboard. This was filed as https://phabricator.wikimedia.org/T410633. Co-authored-by: Mark Waite <[email protected]>
1 parent 0b18928 commit abecec2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

core/src/main/resources/hudson/model/Run/console-log.jelly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
</j:when>
3030
<!-- output is completed now. -->
3131
<j:otherwise>
32-
<pre class="console-output">
32+
<pre id="out" class="console-output">
3333
<st:getOutput var="output" />
3434
<j:whitespace>${it.writeLogTo(offset,output)}</j:whitespace>
3535
</pre>

0 commit comments

Comments
 (0)