Skip to content

Commit ffc46de

Browse files
Use rootURL in Cloud sidepanel so links in actions work properly (jenkinsci#26004)
* Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <[email protected]> --------- Co-authored-by: Alexander Brandes <[email protected]>
1 parent 69c3586 commit ffc46de

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ THE SOFTWARE.
2727
<l:header />
2828
<l:side-panel>
2929
<l:tasks>
30-
<l:task contextMenu="false" href="." icon="symbol-computer" title="${%Status}"/>
31-
<l:task href="configure" icon="symbol-settings"
30+
<j:set var="url" value="${h.getNearestAncestorUrl(request2,it)}"/>
31+
<l:task contextMenu="false" href="${url}/" icon="symbol-computer" title="${%Status}"/>
32+
<l:task href="${url}/configure" icon="symbol-settings"
3233
title="${app.hasPermission(app.ADMINISTER) ? '%Configure' : '%View Configuration'}"/>
33-
<l:delete permission="${app.ADMINISTER}" title="${%Delete Cloud}" message="${%delete.cloud(it.displayName)}"/>
34+
<l:delete permission="${app.ADMINISTER}" title="${%Delete Cloud}" message="${%delete.cloud(it.displayName)}" urlPrefix="${url}"/>
3435
<t:actions />
3536
</l:tasks>
3637
<j:forEach var="action" items="${it.allActions}">

0 commit comments

Comments
 (0)