Close prepared statement and fail if limit is not enforced in limit example

[mattn]

bulkInsert leaked a prepared statement on every call, which also made the pool open extra connections and could run the inserts on a connection without the configured limit. Close the statement, and fail instead of logging when the insert that must exceed SQLITE_LIMIT_VARIABLE_NUMBER unexpectedly succeeds (also removes doubled err checks).

Summary by CodeRabbit

• Bug Fixes
  • Improved resource cleanup during bulk inserts by ensuring prepared statements are properly closed.
  • Updated the limit example to fail when an insert unexpectedly succeeds, and to validate the error message when failures are expected.
  • Simplified error handling for the large-limit insert scenario to make behavior clearer and more consistent.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a15e908-e483-41dc-89ce-768d111b3a42

📥 Commits

Reviewing files that changed from the base of the PR and between 084f3d3 and 18f2ec3.

📒 Files selected for processing (1)

• _example/limit/limit.go

🚧 Files skipped from review as they are similar to previous changes (1)

• _example/limit/limit.go

---

📝 Walkthrough

Walkthrough

The limit example now closes prepared statements, validates the expected small-limit error, and simplifies big-limit error handling.

Changes

Limit example maintenance

Layer / File(s)	Summary
Prepared statement cleanup and insert validation _example/limit/limit.go	bulkInsert defers statement closure; the small-limit check rejects unexpected success and validates the error text; the big-limit fatal branch is simplified.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: closing the prepared statement and failing when the limit check does not trigger.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-limit-example-stmt-leak

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@_example/limit/limit.go`:
- Around line 93-96: The insert validation around the expected
SQLITE_LIMIT_VARIABLE_NUMBER failure must distinguish the expected SQLite error
from unrelated failures. After the insert in the test flow, make nil errors
fatal as currently, but also make any error whose message does not contain the
SQLite “too many SQL variables” text fatal; only log or accept the matching
driver error.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f28433a2-e411-4f98-9cdb-4476bd1d147b

📥 Commits

Reviewing files that changed from the base of the PR and between 210e260 and 084f3d3.

📒 Files selected for processing (1)

• _example/limit/limit.go