Skip to content

Conversation

@q66
Copy link
Contributor

@q66 q66 commented Jul 17, 2024

A valid sqlite header must always be included (like in the other files) but sqlite3-binding.h explicitly guards against the system library case.

This fixes forgejo compilation with libsqlite3 tag.

A valid sqlite header must always be included (like in the other
files) but sqlite3-binding.h explicitly guards against the system
library case.
@charlievieth
Copy link
Contributor

@mattn / @rittneje this commit simply fixes the sqlite3_opt_unlock_notify.{c,go} files so that they respect USE_LIBSQLITE3. Now that Fedora is moving to Forgejo it might be nice to help them out.

@rittneje rittneje merged commit 7658c06 into mattn:master Dec 9, 2024
@charlievieth
Copy link
Contributor

@rittneje thank you for merging this!!!

didzis pushed a commit to didzis/go-sqlite3 that referenced this pull request Feb 28, 2025
A valid sqlite header must always be included (like in the other
files) but sqlite3-binding.h explicitly guards against the system
library case.
didzis pushed a commit to didzis/go-sqlite3 that referenced this pull request Mar 2, 2025
A valid sqlite header must always be included (like in the other
files) but sqlite3-binding.h explicitly guards against the system
library case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants