Identify updated row by argv 0 in goVUpdate

[mattn]

Per the xUpdate contract argv[0] is the rowid of the row being updated and argv[1] is its new rowid, but goVUpdate passed argv[1] to VTabUpdater.Update. A statement like UPDATE vt SET rowid = rowid + 1 therefore updated the wrong row.

Summary by CodeRabbit

• Bug Fixes
  • Virtual table UPDATE behavior is now consistent with the expected update contract when row identifiers are involved.
  • If an update attempts to change a row’s rowid, the operation is now rejected with a clear error, and the existing row data remains unchanged.
  • Added coverage to ensure row identifier change attempts fail and do not corrupt stored values.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ef59c2f9-c45d-4449-9ecc-8e41505ee425

📥 Commits

Reviewing files that changed from the base of the PR and between 1a1bc9e and 726af39.

📒 Files selected for processing (2)

• sqlite3_opt_vtable.go
• sqlite3_opt_vtable_test.go

🚧 Files skipped from review as they are similar to previous changes (1)

• sqlite3_opt_vtable.go

---

📝 Walkthrough

Walkthrough

goVUpdate now follows the virtual table xUpdate rowid argument mapping, rejects rowid changes, and tests that rejected updates leave the original row unchanged.

Changes

Virtual table update correction

Layer / File(s)	Summary
Correct xUpdate row mapping sqlite3_opt_vtable.go, sqlite3_opt_vtable_test.go	goVUpdate uses vals[0] as the existing row identifier, rejects differing rowids, documents the argument mapping, and verifies failed rowid changes preserve stored data.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly reflects the main change: using argv[0] in goVUpdate to identify the row being updated.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-vtable-update-rowid

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@sqlite3_opt_vtable.go`:
- Around line 610-613: The update path in VTabUpdater.Update currently ignores
the new rowid in vals[1]. Extend the update contract and all
implementations/callers to receive and apply both the old rowid (vals[0]) and
new rowid, or explicitly reject updates where they differ; add a regression test
covering rowid-changing updates.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 787e30d0-5795-46a9-a61e-6e92a909f7d3

📥 Commits

Reviewing files that changed from the base of the PR and between a39da35 and 1a1bc9e.

📒 Files selected for processing (1)

• sqlite3_opt_vtable.go