Use the table name from xCreate args in vtable example

[mattn]

The github vtable example passed args[0] (the module name) to DeclareVTab where the table name (args[2]) belongs; it only worked because SQLite ignores the name in the declaration. Also check the HTTP status so a rate-limited API response yields a clear error instead of a JSON unmarshal failure.

Summary by CodeRabbit

• Bug Fixes
  • Added validation to prevent virtual table creation when insufficient arguments are provided.
  • Corrected virtual table naming during SQLite schema creation.
  • Improved error handling for failed GitHub repository requests by reporting non-successful responses.

[coderabbitai]

📝 Walkthrough

Walkthrough

The example virtual table module now validates creation arguments, uses the supplied virtual table name in its schema declaration, and rejects GitHub repository responses that do not return HTTP 200.

Changes

Virtual table handling

Layer / File(s)	Summary
Virtual table creation arguments _example/vtable/vtable.go	githubModule.Create requires at least three arguments and uses args[2] as the virtual table name in the SQLite schema declaration.
GitHub response status validation _example/vtable/vtable.go	ghRepoTable.Open returns an error for non-200 HTTP responses before reading and unmarshaling the response body.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: using the table name from xCreate args in the vtable example.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-vtable-example-declare

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@_example/vtable/vtable.go`:
- Around line 29-35: Update the SQL construction in the xCreate flow around
DeclareVTab to quote args[2] as a SQLite identifier before interpolation. Escape
embedded double-quote characters, wrap the resulting name in double quotes, and
use that safely quoted value in the CREATE TABLE statement.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: aedbf46f-5505-4487-9ec5-4521f83018f5

📥 Commits

Reviewing files that changed from the base of the PR and between e664cc6 and baab344.

📒 Files selected for processing (1)

• _example/vtable/vtable.go

[coderabbitai]

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Quote args[2] as a SQLite identifier before interpolation.

args[2] originates from the SQL xCreate call but is inserted verbatim into another SQL statement. Table names containing spaces, reserved words, or quotes will produce invalid schema SQL; crafted names can also alter the declaration text. Escape embedded " characters and wrap the name in double quotes before passing it to DeclareVTab.

Proposed fix

+	tableName := `"` + strings.ReplaceAll(args[2], `"`, `""`) + `"`
 	err := c.DeclareVTab(fmt.Sprintf(`
 		CREATE TABLE %s (
 			id INT,
 			full_name TEXT,
 			description TEXT,
 			html_url TEXT
-		)`, args[2]))
+		)`, tableName))

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	err := c.DeclareVTab(fmt.Sprintf(`
	CREATE TABLE %s (
	id INT,
	full_name TEXT,
	description TEXT,
	html_url TEXT
	)`, args[0]))
	)`, args[2]))
	tableName := `"` + strings.ReplaceAll(args[2], `"`, `""`) + `"`
	err := c.DeclareVTab(fmt.Sprintf(`
	CREATE TABLE %s (
	id INT,
	full_name TEXT,
	description TEXT,
	html_url TEXT
	)`, tableName))

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@_example/vtable/vtable.go` around lines 29 - 35, Update the SQL construction
in the xCreate flow around DeclareVTab to quote args[2] as a SQLite identifier
before interpolation. Escape embedded double-quote characters, wrap the
resulting name in double quotes, and use that safely quoted value in the CREATE
TABLE statement.