Skip to content

Close prepared statement and fail if limit is not enforced in limit example #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattn merged 2 commits into from
Jul 29, 2026
+8 −7
Merged

Close prepared statement and fail if limit is not enforced in limit example #1440

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084f3d3
Close prepared statement and fail if limit is not enforced in limit e…
mattn Jul 29, 2026
18f2ec3
Assert the expected too many SQL variables error
mattn Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions _example/limit/limit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ func bulkInsert(db *sql.DB, query string, args []any) (err error) {
if err != nil {
return
}
defer stmt.Close()

_, err = stmt.Exec(args...)
if err != nil {
Expand Down Expand Up @@ -89,11 +90,10 @@ func main() {

query, args = createBulkInsertQuery(num, num)
err = bulkInsert(db, query, args)
if err != nil {
if err != nil {
log.Printf("expect failed since SQLITE_LIMIT_VARIABLE_NUMBER is too small: %v", err)
}
if err == nil {
log.Fatal("expected failure since SQLITE_LIMIT_VARIABLE_NUMBER is too small, but insert succeeded")
}
log.Printf("expect failed since SQLITE_LIMIT_VARIABLE_NUMBER is too small: %v", err)
Comment thread
coderabbitai[bot] marked this conversation as resolved.

bigLimitVariableNumber := 999999
sqlite3conn.SetLimit(sqlite3.SQLITE_LIMIT_VARIABLE_NUMBER, bigLimitVariableNumber)
Expand All @@ -104,9 +104,7 @@ func main() {
query, args = createBulkInsertQuery(500, num+num)
err = bulkInsert(db, query, args)
if err != nil {
if err != nil {
log.Fatal(err)
}
log.Fatal(err)
}

log.Println("no error if SQLITE_LIMIT_VARIABLE_NUMBER > 999")
Expand Down
Loading