Skip to content

Identify updated row by argv 0 in goVUpdate #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattn merged 2 commits into from
Jul 29, 2026
+22 −1
Merged

Identify updated row by argv 0 in goVUpdate #1432

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1bc9e
Identify updated row by argv 0 in goVUpdate
mattn Jul 29, 2026
726af39
Reject rowid-changing updates on virtual tables
mattn Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sqlite3_opt_vtable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,9 @@ func goVUpdate(pVTab unsafe.Pointer, argc C.int, argv **C.sqlite3_value, pRowid
}

case argc > 1:
err = v.Update(vals[1], vals[2:])
// Per the xUpdate contract argv[0] identifies the row being
// updated while argv[1] is its (possibly changed) new rowid.
err = v.Update(vals[0], vals[2:])
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}
}

Expand Down
Loading