Skip to content

[IBM] split full stack to components to support finer grain customization used in KfDef#1582

Merged
k8s-ci-robot merged 5 commits into
kubeflow:masterfrom
adrian555:ibm-stack-split
Oct 20, 2020
Merged

[IBM] split full stack to components to support finer grain customization used in KfDef#1582
k8s-ci-robot merged 5 commits into
kubeflow:masterfrom
adrian555:ibm-stack-split

Conversation

@adrian555

@adrian555 adrian555 commented Oct 14, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
This PR splits the full Kubeflow stack for IBM Cloud platform in stacks/ibm/kustomization.yaml to a set of components, including control plane, argo, pipelines, notebooks etc. This enables a finer grain customization of Kubeflow components when users using KfDef configuration file to install Kubeflow. For example, if notebooks is not part of the KfDef configuration, then the Kubeflow's notebook server component won't be installed.

A sample KfDef configuration file kfctl_ibm_customstack.yaml is provided.

Checklist:

  • [ x ] Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

kubeflow-bot commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

This change is Reviewable

@google-cla google-cla Bot added the cla: yes label Oct 14, 2020
@adrian555

adrian555 commented Oct 14, 2020

Copy link
Copy Markdown
Member Author

cc @Tomcli @pvaneck @animeshsingh

@adrian555 adrian555 changed the title [IBM] split full stack to components to support finer grain customization using in KfDef [IBM] split full stack to components to support finer grain customization used in KfDef Oct 14, 2020
@adrian555

adrian555 commented Oct 14, 2020

Copy link
Copy Markdown
Member Author

/retest

pvaneck
pvaneck reviewed Oct 14, 2020
View reviewed changes
Comment thread stacks/ibm/components/seldon-core-operator/kustomization.yaml
pvaneck
pvaneck reviewed Oct 15, 2020
View reviewed changes
Comment thread stacks/ibm/application/istio/kustomization.yaml
@pvaneck

pvaneck commented Oct 15, 2020

Copy link
Copy Markdown
Member

/lgtm

@Tomcli

Tomcli commented Oct 15, 2020

Copy link
Copy Markdown
Member

Thanks @adrian555, can we have a follow up PR that do the same for our multi-user kfdef?
/lgtm

animeshsingh
animeshsingh approved these changes Oct 15, 2020
View reviewed changes

@animeshsingh animeshsingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

As discussed, we should follow this on with an option to provide KFP with Tekton

@moficodes

moficodes commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

@moficodes: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@animeshsingh

animeshsingh commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

k8s-ci-robot commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrian555, animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ea1a351 into kubeflow:master Oct 20, 2020
As20075
As20075 reviewed Nov 1, 2020
View reviewed changes

@As20075 As20075 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

انا

animeshsingh added a commit to animeshsingh/manifests that referenced this pull request Nov 11, 2020
@animeshsingh
Add Paul as a reviewer
ec58f7d 
Will be responsible for maintaining manifests for KFServing, OpenShift, IKS etc.

PRs merged: 
kubeflow#1515
kubeflow#1575
kubeflow#1580
kubeflow#1617

Reviews:
kubeflow#1582
kubeflow#1621
kubeflow#1625
kubeflow#1627
kubeflow#1628
kubeflow/kfctl#419
@animeshsingh animeshsingh mentioned this pull request Nov 11, 2020
Merged
animeshsingh added a commit to animeshsingh/internal-acls that referenced this pull request Nov 11, 2020
@animeshsingh
add @moficodes to Kubeflow org
de3b9e3 
PRs:
Manifest (kubeflow/community-distribution#1603)
Website (kubeflow/website#1752)

Reviews:
Manifest(kubeflow/community-distribution#1621, kubeflow/community-distribution#1594,  kubeflow/community-distribution#1582, kubeflow/community-distribution#1567)
kfctl(kubeflow/kfctl#419)
Website(kubeflow/website#2327)

Issue Triage:
kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)
@animeshsingh animeshsingh mentioned this pull request Nov 11, 2020
Merged
k8s-ci-robot pushed a commit to kubeflow/internal-acls that referenced this pull request Nov 11, 2020
@animeshsingh
add @moficodes to Kubeflow org (#399)
8793ddf 
PRs:
Manifest (kubeflow/community-distribution#1603)
Website (kubeflow/website#1752)

Reviews:
Manifest(kubeflow/community-distribution#1621, kubeflow/community-distribution#1594,  kubeflow/community-distribution#1582, kubeflow/community-distribution#1567)
kfctl(kubeflow/kfctl#419)
Website(kubeflow/website#2327)

Issue Triage:
kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)
k8s-ci-robot pushed a commit that referenced this pull request Nov 11, 2020
@animeshsingh
Add Paul as a reviewer (#1632)
fcd557a 
* Add Paul as a reviewer

Will be responsible for maintaining manifests for KFServing, OpenShift, IKS etc.

PRs merged: 
#1515
#1575
#1580
#1617

Reviews:
#1582
#1621
#1625
#1627
#1628
kubeflow/kfctl#419

* Update OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

@PatrickXYS PatrickXYS Awaiting requested review from PatrickXYS

3 more reviewers

@pvaneck pvaneck pvaneck left review comments

@As20075 As20075 As20075 left review comments

@animeshsingh animeshsingh animeshsingh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pvaneck pvaneck

@animeshsingh animeshsingh

@Tomcli Tomcli

Labels

approved cla: yes lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@adrian555 @kubeflow-bot @pvaneck @Tomcli @moficodes @k8s-ci-robot @animeshsingh @As20075