Uses AppID for multi-user installation on IKS by shawnzhu · Pull Request #2327 · kubeflow/website

shawnzhu · 2020-10-30T22:15:11Z

Notice this PR depends on kubeflow/community-distribution#1594

k8s-ci-robot · 2020-10-30T22:15:16Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

kubeflow-bot · 2020-10-30T22:15:19Z

This change is

animeshsingh · 2020-11-02T23:46:34Z

/assign @moficodes

k8s-ci-robot · 2020-11-02T23:46:36Z

@animeshsingh: GitHub didn't allow me to assign the following users: moficodes.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @moficodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

moficodes · 2020-11-03T03:10:52Z

+2. Follow the step [Registering your app](https://cloud.ibm.com/docs/appid?topic=appid-app#app-register)
+to create an application with type _reguarwebapp_ under the provioned AppID


Suggested change

2. Follow the step [Registering your app](https://cloud.ibm.com/docs/appid?topic=appid-app#app-register)

to create an application with type _reguarwebapp_ under the provioned AppID

2. Follow the step [Registering your app](https://cloud.ibm.com/docs/appid?topic=appid-app#app-register)

to create an application with type _regularwebapp_ under the provisioned AppID

moficodes · 2020-11-04T00:33:29Z

+    * `secret`
+    * `oAuthServerUrl`
+3. Follow the step [Adding redirect URIs](https://cloud.ibm.com/docs/appid?topic=appid-managing-idp)
+to fill a URL for AppID to redirect to Kubeflow. the URL should look like `https://<kubeflow-FQDN>/login/oidc`. Notice that you could follow the guide [Securing the Kubeflow authentication with HTTPS](../authentication/) for the value of `<kubeflow-FQDN>`.


Suggested change

to fill a URL for AppID to redirect to Kubeflow. the URL should look like `https://<kubeflow-FQDN>/login/oidc`. Notice that you could follow the guide [Securing the Kubeflow authentication with HTTPS](../authentication/) for the value of `<kubeflow-FQDN>`.

to fill a URL for AppID to redirect to Kubeflow. the URL should look like `https://<kubeflow-FQDN>/login/oidc`. Notice that you could follow the guide [Securing the Kubeflow authentication with HTTPS](./authentication/) for the value of `<kubeflow-FQDN>`.

moficodes · 2020-11-04T00:43:38Z

+    * `secret`
+    * `oAuthServerUrl`
+3. Follow the step [Adding redirect URIs](https://cloud.ibm.com/docs/appid?topic=appid-managing-idp)
+to fill a URL for AppID to redirect to Kubeflow. the URL should look like `https://<kubeflow-FQDN>/login/oidc`. Notice that you could follow the guide [Securing the Kubeflow authentication with HTTPS](../authentication/) for the value of `<kubeflow-FQDN>`.


This seem like a circular thing.

We need the deployment to be complete for to have a istio-ingress ip that gives us the FQDN and to complete the deployment we need the FQDN.

There needs to be a bit more clarity.

Moved this step to the very end after kubeflow deployment. see a15edf4

moficodes

just one spelling fix. other that that, looks good.

animeshsingh

@shawnzhu we need to merge the manifests repo PR before we merge it. Can we target to get it done today?

shawnzhu · 2020-11-05T21:18:02Z

@animeshsingh the PR for manifests has passed CI: kubeflow/community-distribution#1594

and I've set this PR as ready for review

animeshsingh · 2020-11-05T22:47:15Z

/lgtm

@moficodes are you good to go?

animeshsingh · 2020-11-06T20:20:44Z

/approve

k8s-ci-robot · 2020-11-06T20:20:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, shawnzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/docs/ibm/deploy/OWNERS~~ [animeshsingh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PRs: Manifest (kubeflow/community-distribution#1603) Website (kubeflow/website#1752) Reviews: Manifest(kubeflow/community-distribution#1621, kubeflow/community-distribution#1594, kubeflow/community-distribution#1582, kubeflow/community-distribution#1567) kfctl(kubeflow/kfctl#419) Website(kubeflow/website#2327) Issue Triage: kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)

* Uses AppID for multi-user installation on IKS * Clarify steps to configure AppID after kubeflow deployment * Fix spelling error

k8s-ci-robot added the do-not-merge/work-in-progress label Oct 30, 2020

k8s-ci-robot added the size/L label Oct 30, 2020

k8s-ci-robot requested review from Tomcli and animeshsingh October 30, 2020 22:15

animeshsingh reviewed Nov 3, 2020

View reviewed changes

Comment thread content/en/docs/ibm/deploy/install-kubeflow.md Outdated

Comment thread content/en/docs/ibm/deploy/install-kubeflow.md Outdated

Comment thread content/en/docs/ibm/deploy/install-kubeflow.md Outdated

moficodes suggested changes Nov 3, 2020

View reviewed changes

moficodes reviewed Nov 4, 2020

View reviewed changes

Ke Zhu added 2 commits November 3, 2020 19:48

Uses AppID for multi-user installation on IKS

4b03951

Clarify steps to configure AppID after kubeflow deployment

a15edf4

shawnzhu force-pushed the 2182 branch from baf8c85 to a15edf4 Compare November 4, 2020 02:06

shawnzhu requested a review from animeshsingh November 4, 2020 02:09

moficodes suggested changes Nov 4, 2020

View reviewed changes

Comment thread content/en/docs/ibm/deploy/install-kubeflow.md Outdated

Fix spelling error

a6ffbf3

animeshsingh reviewed Nov 5, 2020

View reviewed changes

shawnzhu marked this pull request as ready for review November 5, 2020 21:14

k8s-ci-robot removed the do-not-merge/work-in-progress label Nov 5, 2020

k8s-ci-robot assigned animeshsingh Nov 5, 2020

k8s-ci-robot added the lgtm label Nov 5, 2020

k8s-ci-robot added the approved label Nov 6, 2020

k8s-ci-robot merged commit 9a09489 into kubeflow:master Nov 6, 2020

shawnzhu deleted the 2182 branch November 6, 2020 20:32

Jeffwan mentioned this pull request Nov 10, 2020

Kubeflow 1.2 release doc changes #2322

Closed

animeshsingh mentioned this pull request Nov 11, 2020

add @moficodes to Kubeflow org kubeflow/internal-acls#399

Merged

moficodes mentioned this pull request Apr 29, 2021

add moficodes to ibm docs owners file #2681

Merged

		2. Follow the step [Registering your app](https://cloud.ibm.com/docs/appid?topic=appid-app#app-register)
		to create an application with type _reguarwebapp_ under the provioned AppID

	to fill a URL for AppID to redirect to Kubeflow. the URL should look like `https://<kubeflow-FQDN>/login/oidc`. Notice that you could follow the guide [Securing the Kubeflow authentication with HTTPS](../authentication/) for the value of `<kubeflow-FQDN>`.
	to fill a URL for AppID to redirect to Kubeflow. the URL should look like `https://<kubeflow-FQDN>/login/oidc`. Notice that you could follow the guide [Securing the Kubeflow authentication with HTTPS](./authentication/) for the value of `<kubeflow-FQDN>`.

Conversation

shawnzhu commented Oct 30, 2020

Uh oh!

k8s-ci-robot commented Oct 30, 2020

Uh oh!

kubeflow-bot commented Oct 30, 2020

Uh oh!

animeshsingh commented Nov 2, 2020

Uh oh!

k8s-ci-robot commented Nov 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moficodes Nov 3, 2020

Choose a reason for hiding this comment

Uh oh!

moficodes Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

moficodes Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

shawnzhu Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

moficodes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

animeshsingh left a comment

Choose a reason for hiding this comment

Uh oh!

shawnzhu commented Nov 5, 2020

Uh oh!

animeshsingh commented Nov 5, 2020

Uh oh!

animeshsingh commented Nov 6, 2020

Uh oh!

k8s-ci-robot commented Nov 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants