Skip to content

update ibmcloud ks cluster config command#1752

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
moficodes:master
Feb 27, 2020
Merged

update ibmcloud ks cluster config command#1752
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
moficodes:master

Conversation

@moficodes

@moficodes moficodes commented Feb 27, 2020 •
edited by jlewi
Loading

Copy link
Copy Markdown
Contributor

the doc referes to
ibmcloud ks cluster-config which is deprecated and will soon be unsupported.

ibmcloud ks cluster config is recommended.

This change is Reviewable

@moficodes
update ibmcloud ks cluster config command
1b7427e 
the doc referes to
`ibmcloud ks cluster-config` which is deprecated and will soon be unsupported.

`ibmcloud ks cluster config` is recommended.
@k8s-ci-robot

k8s-ci-robot commented Feb 27, 2020

Copy link
Copy Markdown
Contributor

Hi @moficodes. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@moficodes

moficodes commented Feb 27, 2020

Copy link
Copy Markdown
Contributor Author

@Tomcli

@Tomcli

Tomcli commented Feb 27, 2020

Copy link
Copy Markdown
Member

Thanks @moficodes
/lgtm
/ok-to-test

@sarahmaddox

sarahmaddox commented Feb 27, 2020

Copy link
Copy Markdown
Contributor

Thanks both!
/approve

@k8s-ci-robot

k8s-ci-robot commented Feb 27, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7d2f6c7 into kubeflow:master Feb 27, 2020
animeshsingh added a commit to animeshsingh/internal-acls that referenced this pull request Nov 11, 2020
@animeshsingh
add @moficodes to Kubeflow org
de3b9e3 
PRs:
Manifest (kubeflow/community-distribution#1603)
Website (kubeflow/website#1752)

Reviews:
Manifest(kubeflow/community-distribution#1621, kubeflow/community-distribution#1594,  kubeflow/community-distribution#1582, kubeflow/community-distribution#1567)
kfctl(kubeflow/kfctl#419)
Website(kubeflow/website#2327)

Issue Triage:
kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)
@animeshsingh animeshsingh mentioned this pull request Nov 11, 2020
Merged
k8s-ci-robot pushed a commit to kubeflow/internal-acls that referenced this pull request Nov 11, 2020
@animeshsingh
add @moficodes to Kubeflow org (#399)
8793ddf 
PRs:
Manifest (kubeflow/community-distribution#1603)
Website (kubeflow/website#1752)

Reviews:
Manifest(kubeflow/community-distribution#1621, kubeflow/community-distribution#1594,  kubeflow/community-distribution#1582, kubeflow/community-distribution#1567)
kfctl(kubeflow/kfctl#419)
Website(kubeflow/website#2327)

Issue Triage:
kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)
@moficodes moficodes mentioned this pull request Apr 29, 2021
Merged
aronchick pushed a commit to aronchick/website-2 that referenced this pull request Feb 19, 2026
@moficodes
update ibmcloud ks cluster config command (kubeflow#1752)
1098e2d 
the doc referes to
`ibmcloud ks cluster-config` which is deprecated and will soon be unsupported.

`ibmcloud ks cluster config` is recommended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Tomcli Tomcli

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moficodes @k8s-ci-robot @Tomcli @sarahmaddox