Merge linux branch into master #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ChakraCore solution can be built with static CRT (`msbuild /p:Runtime=static_library ...`). NativeTests.vcxproj should not specify its own `RuntimeLibrary` property. Should use imported props.
Merge pull request chakra-core#1279 from jianchun:nativetestsstatic The ChakraCore solution can be built with static CRT (`msbuild /p:Runtime=static_library ...`). NativeTests.vcxproj should not specify its own `RuntimeLibrary` property. Should use imported props.
After this PR 7 more tests are passing + 3 of them are excluded from OSX Excluded tests will need a revisit later for xplat improvements. i.e. DST offset for year 35000+ is not maching xplat.. Also revisited Linux DateTime implementation for other distros. i.e. On some distros mktime return -1 for minus years while some others don't. This PR takes care of those.
We have all tests are passing for macOS now. notes on updates: - Sets 64MB process stack limit through macOS linker to match our testing needs
…in/master' into linux Merge pull request chakra-core#1307 from jianchun:filinux
…mework for DateTime Merge pull request chakra-core#1283 from obastemur:osx_fixes_2 After this PR; 7 more tests are passing + 3 of them are excluded from OSX Currently, only couple of ICU and stackoverflow tests are left on OSX. Excluded tests will need a revisit later for xplat improvements. i.e. DST offset for year 35000+ is not maching xplat.. Also revisited Linux DateTime implementation for other distros. i.e. On some distros mktime return -1 for minus years while some others don't.
Fedora x64, we have only 1 failing test at the moment: 'test/Regex/BoiHardFail.js' Compile steps for Fedora 24 ``` > sudo dnf group install -y "Development Tools" "C Development Tools and Libraries" > sudo dnf install -y git cmake clang gcc gcc-c++ libunwind-devel.x86_64 libuuid-devel lttng-ust-devel.x86_64 kernel-devel libicu-devel.x86_64 > git clone https://github.com/Microsoft/ChakraCore > cd ChakraCore > ./build.sh ```
Split version defs out from `CommonDefines.h` into a separate file. Hosts that statically link to ChakraCore can then access ChakraCore version info by `#include` this file at build time.
Recent updates added usages to `_Outptr_result_maybenull_` and `byte` which are unavailable to external hosts.
Merge pull request chakra-core#1313 from jianchun:chakracoreversion Split version defs out from `CommonDefines.h` into a separate file. Hosts that statically link to ChakraCore can then access ChakraCore version info by `#include` this file at build time.
Merge pull request chakra-core#1314 from jianchun:chakracorebyte Recent updates added usages to `_Outptr_result_maybenull_` and `byte` which are unavailable to external hosts.
… issues on macOS Merge pull request chakra-core#1306 from obastemur:fixed_stack_osx We have all tests are passing for macOS now. notes on updates: ~~Main thread default stack limit is 8MB while `pthread_get_stacksize_np` may return lower value.~~ ~~OSX implementation of Pthread stack size is 512KB~~ - Sets 64MB process stack limit through macOS linker to match our testing needs edit: removed additional pthread updates. It was kind of a nice to have but at the moment not needed. Going to visit that separately.
…a X64 compile time issues Merge pull request chakra-core#1312 from obastemur:fedora_compile Fedora x64, we have only 1 failing test at the moment: 'test/Regex/BoiHardFail.js' Compile steps for Fedora 24 Install dependencies ``` sudo dnf group install -y "Development Tools" "C Development Tools and Libraries" sudo dnf install -y git cmake clang gcc gcc-c++ kernel-devel python sudo dnf install -y libuuid-devel lttng-ust-devel.x86_64 libunwind-devel.x86_64 libicu-devel.x86_64 ``` Clone && Compile ``` > git clone https://github.com/Microsoft/ChakraCore > cd ChakraCore > ./build.sh ```
…in/master' into linux Merge pull request chakra-core#1320 from jianchun:filinux
Searches for the libs from custom ICU path
… target --icu path instead Merge pull request chakra-core#1327 from obastemur:fix_icu_lib_link Searches for the libs from custom ICU path
Minor clean up of external PAL dependencies- we don't need uuid or liblttng-ust right now so we don't need to block the build on that. We do need ICU so configure.cmake is updated to check for that. This part is temporary till we make the ICU optional.
ENABLE_TTD was being defined on consumer unintentionally
This change enables OS X build/test as part of Jenkins CI. Ironically, this is currently targetted only to the linux branch but we'll bring it back to master soon. Changes: - Update groovy script to generate OS X build tasks - Update get_system_info.sh to work on OS X - Disable one failing test on OS X in debug test runs
Merge pull request chakra-core#1332 from digitalinfinity:linux_osx This change enables OS X build/test as part of Jenkins CI. Ironically, this is currently targetted only to the linux branch but we'll bring it back to master soon. Changes: - Update groovy script to generate OS X build tasks - Update get_system_info.sh to work on OS X - Disable one failing test on OS X in debug test runs
- Make sure the returned lowLimit address is aligned - Take care of the pthread_get_stackaddr_np issue [ it may return < 8MB OSX / < 1MB-guard_size IOS ]
Fix global ICU installation requirement issue brought by chakra-core#1332 ChakraCore supports ICU from custom location
…stack base and pthread bug Merge pull request chakra-core#1339 from obastemur:osx_mem_align - Make sure the returned lowLimit address is aligned - Take care of the pthread_get_stackaddr_np issue [ it may return < 8MB OSX / < 1MB-guard_size IOS ]
current xplat release binary was broken and CI could not detect that This PR enables very basic testing to make sure the compiled binary is functioning
…ease builds Merge pull request chakra-core#1325 from obastemur:fix_xplat_release ENABLE_TTD was being defined on consumer side unintentionally @digitalinfinity @jianchun
…nary basic testing Merge pull request chakra-core#1328 from obastemur:enable_release_testing current xplat release binary was broken and CI could not detect that This PR enables very basic testing to make sure the compiled binary is functioning /cc @dilijev @digitalinfinity @jianchun
…reation support Merge pull request chakra-core#1294 from obastemur:deb_package
Move down ch's ENABLE_TEST_HOOKS def after CommonDefines.h, so that it does not accidentally turn on ENABLE_DEBUG_CONFIG_OPTIONS for release build type.
…e effect Merge pull request chakra-core#1346 from jianchun:releasetesthooks Move down ch's ENABLE_TEST_HOOKS def after CommonDefines.h, so that it does not accidentally turn on ENABLE_DEBUG_CONFIG_OPTIONS for release build type.
DeferredParsingThunk asm didn't have eh frame data. If an exception is thrown during its execution (calling JavascriptFunction::DeferredParse), process will crash because it cannot unwind the stack correctly. Changed to use asm macroes which adds cfi directives. Applied the same fix to DeferredDeserializeThunk.
This avoids build problems when you're using another shell like zsh.
Merge pull request chakra-core#1354 from jianchun:fixasm DeferredParsingThunk asm didn't have eh frame data. If an exception is thrown during its execution (calling JavascriptFunction::DeferredParse), process will crash because it cannot unwind the stack correctly. Changed to use asm macroes which adds cfi directives. Applied the same fix to DeferredDeserializeThunk.
Merge pull request chakra-core#1358 from TorbenKoehn:patch-1 This avoids build problems when you're using another default shell like zsh.
Merge pull request chakra-core#1370 from obastemur:master_to_linux
|
@dotnet-bot test Windows arm_debug please |
chakrabot
pushed a commit
that referenced
this pull request
Aug 5, 2016
Merge pull request #1392 from digitalinfinity:linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.