cross-platform: fix stack related issues on macOS #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obastemur
force-pushed
the
fixed_stack_osx
branch
from
d77ce17 to
538b7ba
Compare
We have all tests are passing for macOS now. notes on updates: - Sets 64MB process stack limit through macOS linker to match our testing needs
obastemur
force-pushed
the
fixed_stack_osx
branch
from
538b7ba to
adf894c
Compare
|
@mmitche Was there an issue causing timeouts? Two hour delay after the test summary (presumably nothing was running then) and then the build timed out. |
|
@dotnet-bot test Windows x86_debug please |
|
@dilijev Not that I know of. Please let me know if it happens again |
|
@dilijev Thanks for following up with CI. @digitalinfinity @jianchun any thoughts? |
|
LGTM- you can merge |
|
@dilijev @digitalinfinity thanks for the reviews! |
chakrabot
pushed a commit
that referenced
this pull request
Jul 22, 2016
…macOS Merge pull request #1306 from obastemur:fixed_stack_osx We have all tests are passing for macOS now. notes on updates: ~~Main thread default stack limit is 8MB while `pthread_get_stacksize_np` may return lower value.~~ ~~OSX implementation of Pthread stack size is 512KB~~ - Sets 64MB process stack limit through macOS linker to match our testing needs edit: removed additional pthread updates. It was kind of a nice to have but at the moment not needed. Going to visit that separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have all tests are passing for macOS now.
notes on updates:
Main thread default stack limit is 8MB whilepthread_get_stacksize_npmay return lower value.OSX implementation of Pthread stack size is 512KBedit: removed additional pthread updates. It was kind of a nice to have but at the moment not needed. Going to visit that separately.