-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added shebang to build script #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This avoids build problems when you're using another shell like zsh.
Hi @TorbenKoehn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Thanks for the change! Should we use /bin/bash? The script used to have problems with /bin/sh. I think previously we had trouble with the license header checker for this change. Seems that problem is gone. @dilijev |
Absolutely. Changed it. |
bin/sh forces POSIX. So, the differences. However makes sure the experience due to strict bacward compatibility. On the other hand, for the range of platforms we target, 'bash' makes more sense for us. |
LGTM |
Thanks @TorbenKoehn, and @obastemur for confirmation. I'll merge this. |
Merge pull request #1358 from TorbenKoehn:patch-1 This avoids build problems when you're using another default shell like zsh.
@jianchun yes, last time this came up @obastemur and I fixed the copyright check to support shebangs as the first line of the file before the required copyright header. |
@dilijev Thanks for confirm! |
For reference, that logic is here: https://github.com/Microsoft/ChakraCore/blob/master/jenkins/check_copyright.py#L46 |
This avoids build problems when you're using another default shell like zsh.