Skip to content

Conversation

TorbenKoehn
Copy link
Contributor

@TorbenKoehn TorbenKoehn commented Jul 29, 2016

This avoids build problems when you're using another default shell like zsh.

This avoids build problems when you're using another shell like zsh.
@msftclas
Copy link

Hi @TorbenKoehn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@jianchun
Copy link

Thanks for the change! Should we use /bin/bash? The script used to have problems with /bin/sh. I think previously we had trouble with the license header checker for this change. Seems that problem is gone. @dilijev

@TorbenKoehn
Copy link
Contributor Author

Absolutely. Changed it.

@obastemur
Copy link
Collaborator

Should we use /bin/bash? The script used to have problems with /bin/sh.

bin/sh forces POSIX. So, the differences. However makes sure the experience due to strict bacward compatibility. On the other hand, for the range of platforms we target, 'bash' makes more sense for us.

@obastemur
Copy link
Collaborator

LGTM

@jianchun
Copy link

Thanks @TorbenKoehn, and @obastemur for confirmation. I'll merge this.

@chakrabot chakrabot merged commit d0dd21b into chakra-core:linux Jul 29, 2016
chakrabot pushed a commit that referenced this pull request Jul 29, 2016
Merge pull request #1358 from TorbenKoehn:patch-1

This avoids build problems when you're using another default shell like zsh.
@dilijev
Copy link
Contributor

dilijev commented Jul 29, 2016

@jianchun yes, last time this came up @obastemur and I fixed the copyright check to support shebangs as the first line of the file before the required copyright header.

@jianchun
Copy link

@dilijev Thanks for confirm!

@dilijev
Copy link
Contributor

dilijev commented Jul 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants