split ChakraCoreVersion.h file #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split version defs out from `CommonDefines.h` into a separate file. Hosts that statically link to ChakraCore can then access ChakraCore version info by `#include` this file at build time.
|
LGTM. Is this file supposed to be redistributable with Jsrt? |
Thanks. Yes, I suppose so. Not needed for Windows/Chakra JSRT. Needed for ChakraCore. |
chakrabot
pushed a commit
that referenced
this pull request
Jul 22, 2016
Merge pull request #1313 from jianchun:chakracoreversion Split version defs out from `CommonDefines.h` into a separate file. Hosts that statically link to ChakraCore can then access ChakraCore version info by `#include` this file at build time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split version defs out from
CommonDefines.hinto a separate file.Hosts that statically link to ChakraCore can then access ChakraCore
version info by
#includethis file at build time.