cross-platform: Fix GCC lib Fedora X64 compile time issues #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora x64, we have only 1 failing test at the moment: 'test/Regex/BoiHardFail.js' Compile steps for Fedora 24 ``` > sudo dnf group install -y "Development Tools" "C Development Tools and Libraries" > sudo dnf install -y git cmake clang gcc gcc-c++ libunwind-devel.x86_64 libuuid-devel lttng-ust-devel.x86_64 kernel-devel libicu-devel.x86_64 > git clone https://github.com/Microsoft/ChakraCore > cd ChakraCore > ./build.sh ```
| @@ -677,4 +677,11 @@ inline T* InterlockedCompareExchangePointerT( | |||
|
|
|||
| #endif // __cplusplus | |||
|
|
|||
| #ifndef max | |||
There was a problem hiding this comment.
Curious, why is this needed for fedora and not needed for ubuntu? pal.h also defines min and max, so this seems unnecessary but I saw the same compile error as you. Can you explain why that definition is insufficient?
There was a problem hiding this comment.
IIRC; NO_PAL_MINMAX was being defined in the chain by mistake. Edit: not that our mistake though..
|
Awesome. Thanks for fixing this @obastemur! LGTM, just had one question. |
|
@digitalinfinity @jianchun thanks for the reviews! |
chakrabot
pushed a commit
that referenced
this pull request
Jul 22, 2016
…le time issues Merge pull request #1312 from obastemur:fedora_compile Fedora x64, we have only 1 failing test at the moment: 'test/Regex/BoiHardFail.js' Compile steps for Fedora 24 Install dependencies ``` sudo dnf group install -y "Development Tools" "C Development Tools and Libraries" sudo dnf install -y git cmake clang gcc gcc-c++ kernel-devel python sudo dnf install -y libuuid-devel lttng-ust-devel.x86_64 libunwind-devel.x86_64 libicu-devel.x86_64 ``` Clone && Compile ``` > git clone https://github.com/Microsoft/ChakraCore > cd ChakraCore > ./build.sh ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora x64, we have only 1 failing test at the moment: 'test/Regex/BoiHardFail.js'
Compile steps for Fedora 24
Install dependencies
Clone && Compile