Skip to content

Conversation

calvinlu3
Copy link
Contributor

No description provided.

@calvinlu3 calvinlu3 force-pushed the rc branch 2 times, most recently from b9d3a51 to 0bd3862 Compare August 21, 2023 16:05
@calvinlu3
Copy link
Contributor Author

calvinlu3 commented Aug 21, 2023

Issue list:

  • We need to pass in Pageable to getAllGenes endpoint, but oncokb-core does not have spring-data dependency

  • Solution 1: Add spring-boot-starter-data-jpa dependency to the core. A drawback of this approach is that our spring version is very old, so we need to use an older version of spring-data that is compatible. In older version of spring-data, the method Pageable.unpaged() is not available, so we need to use new PageRequest(0, Integer.MAX_VALUE) to get all genes.

  • Solution 2 ✔️ : Use the org.oncokb.oncokb_curation.client.Pageable in the java client and manually set the Page fields.

org.oncokb.oncokb_curation.client.Pageable pageable = new org.oncokb.oncokb_curation.client.Pageable();
pageable.setPage(0);
pageable.setSize(Integer.MAX_VALUE);

  • In Gene model, we are applying @JsonIgnore annotation to the ensemblGenes field. As a result, this field is not included in our java client generated model.

Usages:

  1. In oncokb-core, we are using this field in genomicLocationShouldBeAnnotated(...) method to determine if a GL/HGVSg should be annoated by GenomeNexus.
  2. We are also using this field in PrivateUtilsApi.utilsEnsemblGenesGet(...) to get ensemble genes from entrez gene id. This is used in the AnnotationPage in oncokb-public.
  • Solution 1: Remove @JsonIgnore, so that ensemblGenes can be pulled from the Gene entity.
  • Solution 2 ✔️: Keep annotation, but provide and endpoint in EnsembleGeneResource to fetch ensembl genes by gene id. With this approach, we also need to cache all ensemblGenes in oncokb-core and create a mapping with allTranscriptGenes to quickly fetch the ensembl gene.

  • Missing properties in Gene schema produced by SpringDoc.

  • Adding @JsonIgnoreProperties in EnsemblGene causes the Gene schema to not include "geneAliases", "ensemblGenes", "alterations"

@ManyToOne
@JsonIgnoreProperties(value = { "geneAliases", "ensemblGenes", "alterations" }, allowSetters = true)
private Gene gene;

Related issue from springdoc and it seems like a bug.

  1. Increasing the springdoc version to 1.7.0 did not make a difference
  2. Created a new JHipster project with the same JDL models.
  • Interesting thing is that this new project does not have the same problem. The properties ignored in EnsemblGene does not affect the Gene schema.
  • Replacing all the java models in oncokb-curation with the newly generated models from this test application did not resolve the issue either.

zhx828 and others added 25 commits May 23, 2024 12:12
Remove Users collection from mockdata & Include set up for client tests
Check history has records
When user is redirected to ErrorBoundry, we should send the error to Sentry
Enabling source maps in production will slow down the build, but we need it to show error in Sentry properly
dockerize screenshot test

---------

Co-authored-by: Hongxin <[email protected]>
fix mutation collapsibles rerendering
reduce blinking on mutation list
 add more screenshot tests
bprize15 and others added 30 commits April 24, 2025 10:58
* allow download callback for oncokb table

* update screenshots
…ocalDate (#520)

* Initial change

* Update fda-submission-detail.tsx
* initial

* Show FDASubmission form in popover on CDx page

* Update based on feedback
* automatically end review mode if no active reviewer for 5 minutes

* address pr comments
* allow selecting neither and unknown as gene types

* change unknown to insufficient evidence

* address comments

* update tests

* update screenshots

* update screenshot

* disable new gene types for germline

* remove console logs
* normalize hgvsg using genome nexus

* address PR comments

* update pom
)

* use somatic gene type and background for both somatic and germline

* update gene release tab

* update screenshot

* comment out flaky test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants