Skip to content

Conversation

gebbing12
Copy link

close oncokb/oncokb-pipeline#356
image

@gebbing12 gebbing12 added the feature Feature tag for release label May 23, 2024
@gebbing12 gebbing12 requested a review from zhx828 May 23, 2024 20:10
@@ -233,6 +233,7 @@ const GenomicIndicatorsTable = ({
);
await fetchGenomicIndicators(genomicIndicatorsPath);
}}
noOptionsMessage={() => 'No such mutation in Mutations List'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
noOptionsMessage={() => 'No such mutation in Mutations List'}
noOptionsMessage={() => 'Please add this mutation in the Mutations List below first'}

@jfkonecn what do you think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gebbing12 gebbing12 requested review from zhx828 and jfkonecn May 24, 2024 00:00
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhx828 zhx828 merged commit 30e2c45 into oncokb:rc May 24, 2024
@gebbing12 gebbing12 deleted the lan branch May 24, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature tag for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants