Add sort cancer types #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
reviewed
May 30, 2024
Comment on lines
358
to
373
| <InputGroup> | ||
| <Input | ||
| id={`tx-level-filter-${filter.label}`} | ||
| onChange={() => handleFilterCheckboxChange(index, setTempReviewedFilter)} | ||
| checked={filter.selected} | ||
| disabled={isDisabled} | ||
| style={{ cursor: `${isDisabled ? null : 'pointer'}`, marginLeft: '0px' }} | ||
| type="checkbox" | ||
| /> | ||
| <Label | ||
| for={`tx-level-filter-${filter.label}`} | ||
| style={{ cursor: `${isDisabled ? null : 'pointer'}`, marginLeft: CHECKBOX_LABEL_LEFT_MARGIN }} | ||
| > | ||
| {filter.label} | ||
| </Label> | ||
| </InputGroup> |
There was a problem hiding this comment.
This InputGroup seems to be replicated quite a lot. Can we make it a component?
There was a problem hiding this comment.
Oh sorry about this, but I was actually working on a different PR and I accidentally forked this one off of that. This was not supposed to make it into this PR, so I just removed it, but I will definitely make it into a component for that PR
bprize15
force-pushed
the
add-sort-cancer-types
branch
from
bb96834 to
82b8e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/oncokb/oncokb-pipeline/issues/372
I played around with and without debounce, and I settled on not debouncing. Since you mentioned that the API call is not an issue, I prefer the instant feedback.