Add screenshot tests #330
Merged
Add screenshot tests #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Chrome prevents using http. We need to start a https server - In docker services, the network is called using the service name. We need to allow all hosts to access the dev server
Fix docker test network issue
zhx828
reviewed
Jun 3, 2024
| docker-compose up -d | ||
| docker-compose run --rm wdio | ||
|
|
||
| - name: Archive screenshots |
There was a problem hiding this comment.
Do we have something similar to public https://github.com/oncokb/oncokb-public/blob/master/.github/workflows/screenshot-test.yml#L20-L31 to compare latest/base?
There was a problem hiding this comment.
We do. I save the entire screenshots folder which contains the image that was just taken, the baseline image, and the diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing to note is that the file
screenshot.tsis a work in progress. The entire commented out section needs to be added back, but I removed it for now to isolate the SSL certificate error.