src: use simdjson to parse SEA configuration

[joyeecheung]

Refs: #59288

This PR is a bit easier to review by ignoring indentation changes using https://github.com/nodejs/node/pull/59323/files?w=1

[nodejs-github-bot]

Review requested:

• @nodejs/single-executable

[codecov]

Codecov Report

❌ Patch coverage is 64.63415% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (91dadf2) to head (822da44).
⚠️ Report is 66 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sea.cc	64.63%	17 Missing and 12 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59323      +/-   ##
==========================================
- Coverage   90.00%   89.87%   -0.13%     
==========================================
  Files         649      655       +6     
  Lines      192180   192866     +686     
  Branches    37659    37811     +152     
==========================================
+ Hits       172970   173338     +368     
- Misses      11830    12053     +223     
- Partials     7380     7475      +95     

Files with missing lines	Coverage Δ
src/node_sea.cc	87.26% <64.63%> (-4.11%)	⬇️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[joyeecheung]

cc @nodejs/cpp-reviewers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68427/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68438/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68439/

[lemire]

@joyeecheung Give me a minute Joyee. I will propose a minor simplification.

[lemire]

@joyeecheung Please see joyeecheung#8 (It is a PR on top your PR, if you merge it, it will affect this current PR).

[lemire]

This looks fine to me, but consider the simplification joyeecheung#8
as it will trim some boilerplate code.

[joyeecheung]

@lemire Thanks for the suggestion! I didn't know about simdjson::pad. It seems there are other places where we are currently manually padding it. Opened #59389

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68478/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68496/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68503/

[joyeecheung]

@lemire @Ethan-Arrowood @RaisinTen CI is green. This needs a re-approval to land. Can you take a look again? Thanks.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59323
✔  Done loading data for nodejs/node/pull/59323
----------------------------------- PR info ------------------------------------
Title      src: use simdjson to parse SEA configuration (#59323)
Author     Joyee Cheung <[email protected]> (@joyeecheung)
Branch     joyeecheung:sea-simdjson -> nodejs:main
Labels     needs-ci, commit-queue-squash, single-executable
Commits    4
 - src: use simdjson to parse SEA configuration
 - minor simplification
 - Merge pull request #8 from lemire/sea-simdjson-simpler
 - fixup! src: use simdjson to parse SEA configuration
Committers 3
 - Joyee Cheung <[email protected]>
 - Daniel Lemire <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59323
Refs: https://github.com/nodejs/node/issues/59288
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59323
Refs: https://github.com/nodejs/node/issues/59288
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 01 Aug 2025 21:55:22 GMT
   ✔  Approvals: 3
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/59323#pullrequestreview-3102365095
   ✔  - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/59323#pullrequestreview-3093909312
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/59323#pullrequestreview-3093942747
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-08-08T20:53:49Z: https://ci.nodejs.org/job/node-test-pull-request/68503/
- Querying data for job/node-test-pull-request/68503/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 59323
From https://github.com/nodejs/node
 * branch                  refs/pull/59323/merge -> FETCH_HEAD
✔  Fetched commits as af20ce5bcc72..822da4443f1c
--------------------------------------------------------------------------------
[main ccb7ae8b85] src: use simdjson to parse SEA configuration
 Author: Joyee Cheung <[email protected]>
 Date: Fri Aug 1 23:53:48 2025 +0200
 2 files changed, 157 insertions(+), 141 deletions(-)
error: commit 007602a3fd8a7b58c6f8f9c91b47648c37adf993 is a merge but no -m option was given.
fatal: cherry-pick failed
[main 7ce33c8581] minor simplification
 Author: Daniel Lemire <[email protected]>
 Date: Wed Aug 6 15:16:02 2025 -0400
 1 file changed, 1 insertion(+), 6 deletions(-)
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/16859206133

[joyeecheung]

For some reason, node-core-utils cannot squash a merge commit.

error: commit 007602a is a merge but no -m option was given.

Going to land this manually..

[joyeecheung]

Landed in 013190d