Skip to content

lib: docs deprecate _http_* #59293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2025
Merged

lib: docs deprecate _http_* #59293

merged 1 commit into from
Aug 2, 2025
+15 −0

Conversation

bjohansebas
Copy link
Member

It seems that the plan is to start with a documentation deprecation, in order to remove these modules and rely solely on internals.

Ref #58535

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Jul 31, 2025
@bjohansebas bjohansebas force-pushed the http-docs-deprecate branch from df48e6f to 70c3173 Compare July 31, 2025 00:53
@bjohansebas
lib: docs deprecate _http_*
e947fb5 
Ref nodejs#58535

Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas bjohansebas force-pushed the http-docs-deprecate branch from 70c3173 to e947fb5 Compare July 31, 2025 00:56
@bjohansebas
Copy link
Member Author

cc: @nodejs/http @jasnell @mcollina

mcollina
mcollina approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bjohansebas bjohansebas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. notable-change PRs with changes that should be highlighted in changelogs. labels Jul 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @bjohansebas.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@jasnell
Copy link
Member

jasnell commented Jul 31, 2025

It does need to be acknowledged that, like sys, we will never be able to actually remove these modules. We'd only be able to remove the exports from them if we decide later.

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2025
@Renegade334
Copy link
Contributor

It does need to be acknowledged that, like sys, we will never be able to actually remove these modules. We'd only be able to remove the exports from them if we decide later.

Do the same arguments apply here?

npm does not allow, and has never allowed, package names to start with an underscore. Even attempting to manually map a dependency alias in package.json is rejected by the package manager if the alias name starts with an underscore.

Yes, the module loader will happily resolve _pkg to node_modules/_pkg, but if npm will refuse to touch this path, then is this a concern? (Admittedly, third-party package managers may not honour this behaviour.)

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit e4b748a into nodejs:main Aug 2, 2025
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e4b748a

@bjohansebas bjohansebas deleted the http-docs-deprecate branch August 2, 2025 01:14
meteorqz6 pushed a commit to meteorqz6/node that referenced this pull request Aug 2, 2025
@bjohansebas @meteorqz6
lib: docs deprecate _http_*
7c79238 
Ref nodejs#58535

Signed-off-by: Sebastian Beltran <[email protected]>
PR-URL: nodejs#59293
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
panva pushed a commit to panva/node that referenced this pull request Aug 7, 2025
@bjohansebas @panva
lib: docs deprecate _http_*
b28c42c 
Ref nodejs#58535

Signed-off-by: Sebastian Beltran <[email protected]>
PR-URL: nodejs#59293
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
targos pushed a commit that referenced this pull request Aug 8, 2025
@bjohansebas @targos
lib: docs deprecate _http_*
83b1be5 
Ref #58535

Signed-off-by: Sebastian Beltran <[email protected]>
PR-URL: #59293
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
mete0rfish pushed a commit to mete0rfish/node-contribute that referenced this pull request Aug 9, 2025
@bjohansebas @mete0rfish
lib: docs deprecate _http_*
b6b3794 
Ref nodejs#58535

Signed-off-by: Sebastian Beltran <[email protected]>
PR-URL: nodejs#59293
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
panva pushed a commit to panva/node that referenced this pull request Aug 9, 2025
@bjohansebas @panva
lib: docs deprecate _http_*
239ef7c 
Ref nodejs#58535

Signed-off-by: Sebastian Beltran <[email protected]>
PR-URL: nodejs#59293
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 11, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request Aug 11, 2025
@nodejs-github-bot
2025-08-11, Version 24.6.0 (Current)
e9f6065 
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) #59276
crypto:
  * (SEMVER-MINOR) support ML-DSA KeyObject, sign, and verify (Filip Skokan) #59259
fs:
  * (SEMVER-MINOR) port SonicBoom module to fs module as Utf8Stream (James M Snell) #58897
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) #59243
lib:
  * docs deprecate _http_* (Sebastian Beltran) #59293
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) #59240

PR-URL: #59449
RafaelGSS pushed a commit that referenced this pull request Aug 12, 2025
@bjohansebas @RafaelGSS
lib: docs deprecate _http_*
c144d69 
Ref #58535

Signed-off-by: Sebastian Beltran <[email protected]>
PR-URL: #59293
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 12, 2025
@nodejs-github-bot @RafaelGSS
2025-08-11, Version 24.6.0 (Current)
1268525 
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) #59276
  * (SEMVER-MINOR) add --use-env-proxy (Joyee Cheung) #59151
  * (SEMVER-MINOR) support `${pid}` placeholder in --cpu-prof-name (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) support ML-DSA KeyObject, sign, and verify (Filip Skokan) #59259
  * (SEMVER-MINOR) add tls.setDefaultCACertificates() (Joyee Cheung) #58822
deps:
  * update archs files for openssl-3.5.1 (Node.js GitHub Bot) #59234
  * upgrade openssl sources to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag --experimental-wasm-modules (Guy Bedford) #57038
fs:
  * (SEMVER-MINOR) port SonicBoom module to fs module as Utf8Stream (James M Snell) #58897
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) #59243
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and Agent (Joyee Cheung) #58980
lib:
  * docs deprecate _http_* (Sebastian Beltran) #59293
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) #59240

PR-URL: #59449
Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 12, 2025
@nodejs-github-bot @RafaelGSS
2025-08-12, Version 24.6.0 (Current)
a8861ee 
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) #59276
  * (SEMVER-MINOR) add --use-env-proxy (Joyee Cheung) #59151
  * (SEMVER-MINOR) support `${pid}` placeholder in --cpu-prof-name (Haram Jeong) #59072
crypto:
  * (SEMVER-MINOR) support ML-DSA KeyObject, sign, and verify (Filip Skokan) #59259
  * (SEMVER-MINOR) add tls.setDefaultCACertificates() (Joyee Cheung) #58822
deps:
  * update archs files for openssl-3.5.1 (Node.js GitHub Bot) #59234
  * upgrade openssl sources to openssl-3.5.1 (Node.js GitHub Bot) #59234
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) #58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) #59113
esm:
  * (SEMVER-MINOR) unflag --experimental-wasm-modules (Guy Bedford) #57038
fs:
  * (SEMVER-MINOR) port SonicBoom module to fs module as Utf8Stream (James M Snell) #58897
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) #59243
http,https:
  * (SEMVER-MINOR) add built-in proxy support in http/https.request and Agent (Joyee Cheung) #58980
lib:
  * docs deprecate _http_* (Sebastian Beltran) #59293
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) #58087
test:
  * (SEMVER-MINOR) move http proxy tests to test/client-proxy (Joyee Cheung) #58980
worker:
  * (SEMVER-MINOR) add web locks api (ishabi) #58666
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) #59240

PR-URL: #59449
Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 12, 2025
@nodejs-github-bot @RafaelGSS
2025-08-12, Version 24.6.0 (Current)
086aa8f 
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) #59276
crypto:
  * (SEMVER-MINOR) support ML-DSA KeyObject, sign, and verify (Filip Skokan) #59259
fs:
  * (SEMVER-MINOR) port SonicBoom module to fs module as Utf8Stream (James M Snell) #58897
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) #59243
lib:
  * docs deprecate _http_* (Sebastian Beltran) #59293
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) #59240

PR-URL: #59449
Signed-off-by: RafaelGSS <[email protected]>
@wlgh1553 wlgh1553 mentioned this pull request Aug 14, 2025
Open
RafaelGSS pushed a commit that referenced this pull request Aug 14, 2025
@nodejs-github-bot @RafaelGSS
2025-08-14, Version 24.6.0 (Current)
09dc7a5 
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) #59276
crypto:
  * (SEMVER-MINOR) support ML-DSA KeyObject, sign, and verify (Filip Skokan) #59259
fs:
  * (SEMVER-MINOR) port SonicBoom module to fs module as Utf8Stream (James M Snell) #58897
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) #59243
lib:
  * docs deprecate _http_* (Sebastian Beltran) #59293
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) #59240

PR-URL: #59449
Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 14, 2025
@nodejs-github-bot @RafaelGSS
2025-08-14, Version 24.6.0 (Current)
31b6255 
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) #59276
crypto:
  * (SEMVER-MINOR) support ML-DSA KeyObject, sign, and verify (Filip Skokan) #59259
fs:
  * (SEMVER-MINOR) port SonicBoom module to fs module as Utf8Stream (James M Snell) #58897
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) #59243
lib:
  * docs deprecate _http_* (Sebastian Beltran) #59293
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) #59240

PR-URL: #59449
Signed-off-by: RafaelGSS <[email protected]>
meteorqz6 pushed a commit to meteorqz6/node that referenced this pull request Aug 15, 2025
@nodejs-github-bot @meteorqz6
2025-08-14, Version 24.6.0 (Current)
48d99da 
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) nodejs#59276
crypto:
  * (SEMVER-MINOR) support ML-DSA KeyObject, sign, and verify (Filip Skokan) nodejs#59259
fs:
  * (SEMVER-MINOR) port SonicBoom module to fs module as Utf8Stream (James M Snell) nodejs#58897
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) nodejs#59243
lib:
  * docs deprecate _http_* (Sebastian Beltran) nodejs#59293
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) nodejs#59240

PR-URL: nodejs#59449
Signed-off-by: RafaelGSS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bjohansebas @jasnell @Renegade334 @nodejs-github-bot @mcollina @lpinca @pimterry @UlisesGascon @Ethan-Arrowood @marco-ippolito