fs: fix TypeError in glob when directory access is denied #58674
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Ethan-Arrowood
approved these changes
Jun 11, 2025
|
This is nice! Thanks! Would you mind adding a test case? Just make sure that it will never return null |
|
@juanarbol Done. Added test case |
jasnell
approved these changes
Jun 12, 2025
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58674 +/- ##
==========================================
- Coverage 90.09% 90.08% -0.01%
==========================================
Files 640 640
Lines 188271 188271
Branches 36923 36916 -7
==========================================
- Hits 169625 169607 -18
- Misses 11386 11405 +19
+ Partials 7260 7259 -1
🚀 New features to boost your workflow:
|
Sylphy-0xd3ac
force-pushed
the
main
branch
2 times, most recently
from
6b33002 to
7ae4597
Compare
|
Delete the test-fs-glob-readdir-error-handling.mjs file as its functionality is now covered by the test-fs-glob.mjs |
Ethan-Arrowood
approved these changes
Jun 16, 2025
Ethan-Arrowood
added
the
request-ci
github-actions
bot
removed
the
request-ci
Ethan-Arrowood
approved these changes
Jun 17, 2025
Ethan-Arrowood
approved these changes
Jun 20, 2025
Sylphy-0xd3ac
force-pushed
the
main
branch
2 times, most recently
from
db318e6 to
8c18cc5
Compare
Sylphy-0xd3ac
pushed a commit
to Sylphy-0xd3ac/node
that referenced
this pull request
Jun 24, 2025
When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null. PR-URL: nodejs#58674 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ethan-Arrowood <[email protected]> Reviewed-By: Juan José <[email protected]>
|
Add PR-URL and Reviewed-By fields to the commit message |
Sylphy-0xd3ac
pushed a commit
to Sylphy-0xd3ac/node
that referenced
this pull request
Jun 24, 2025
When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null. PR-URL: nodejs#58674 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ethan-Arrowood <[email protected]> Reviewed-By: Juan José <[email protected]>
Sylphy-0xd3ac
pushed a commit
to Sylphy-0xd3ac/node
that referenced
this pull request
Jun 24, 2025
When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null. PR-URL: nodejs#58674 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ethan-Arrowood <[email protected]> Reviewed-By: Juan José <[email protected]>
When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null. PR-URL: nodejs#58674 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ethan-Arrowood <[email protected]> Reviewed-By: Juan José <[email protected]>
|
I think you need to stop force-pushing so it can land. Another contributor can correct me if I'm wrong though |
|
Sorry for the force-push. Could you please help re-approve this PR so it can land? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a directory cannot be read due to permission issues, the async version of fs.glob() returns null from readdir(), while the sync version returns an empty array. This causes a TypeError when trying to access the 'length' property of null.
Fix by making the async readdir() method return an empty array on error, consistent with the sync version behavior.
Fixes: #58670
Fixes: #58276