test: deflake stream-readable-to-web test #58948

Ethan-Arrowood · 2025-07-03T16:29:25Z

Ethan-Arrowood · 2025-07-03T16:32:48Z

cc @nodejs/streams

github-actions · 2025-07-03T16:37:32Z

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/16055944616

Ethan-Arrowood · 2025-07-03T16:44:54Z

I guess I appreciate the CI not running without a review lol

mcollina

lgtm

nodejs-github-bot · 2025-07-03T16:58:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67821/

test/parallel/test-stream-readable-to-web.mjs

nodejs-github-bot · 2025-07-03T17:09:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67822/

codecov · 2025-07-03T18:27:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (1c4fe6d) to head (5b5f9dc).
⚠️ Report is 137 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58948      +/-   ##
==========================================
- Coverage   90.08%   90.06%   -0.02%     
==========================================
  Files         641      641              
  Lines      188718   188718              
  Branches    37022    37025       +3     
==========================================
- Hits       170000   169965      -35     
- Misses      11417    11462      +45     
+ Partials     7301     7291      -10

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Ethan-Arrowood · 2025-07-03T18:59:32Z

I think somethings wrong with how I'm checking for crypto support

https://ci.nodejs.org/job/node-test-commit-linux-containered/51526/nodes=ubuntu2204_sharedlibs_withoutssl_x64/testReport/junit/(root)/parallel/test_stream_readable_to_web/

Will fix

targos · 2025-07-03T19:27:17Z

@Ethan-Arrowood The problem is that all static imports will be evaluated before your condition (it doesn't matter where they are in the file).

Ethan-Arrowood · 2025-07-03T19:31:14Z

I had a feeling that was it. Doesn't seem like we have any other occurrences of this in our tests. I could switch back to CJS if that is preferred, or I think a dynamic import is okay?

lpinca · 2025-07-03T19:34:14Z

Going back to cjs would make the diff useful. It currently looks like a new test.

Ethan-Arrowood · 2025-07-03T19:36:02Z

My preference is to move towards using ESM but if anyone else feels strongly it should stay as CJS I will happily switch back. Just let me know if that is what is wanted

nodejs-github-bot · 2025-07-03T19:42:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67826/

nodejs-github-bot · 2025-07-09T22:57:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67916/

nodejs-github-bot · 2025-07-10T16:56:05Z

Commit Queue failed

- Loading data for nodejs/node/pull/58948
✔  Done loading data for nodejs/node/pull/58948
----------------------------------- PR info ------------------------------------
Title      test: deflake stream-readable-to-web test (#58948)
Author     Ethan Arrowood <[email protected]> (@Ethan-Arrowood)
Branch     Ethan-Arrowood:deflake-stream-readable-to-web -> nodejs:main
Labels     test, flaky-test, needs-ci
Commits    3
 - test: deflake stream-readable-to-web test
 - test: dynamic import cypto
 - test: simplify but keep accurate
Committers 1
 - Ethan Arrowood <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58948
Fixes: https://github.com/nodejs/node/issues/58949
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mattias Buelens <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58948
Fixes: https://github.com/nodejs/node/issues/58949
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mattias Buelens <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 03 Jul 2025 16:29:25 GMT
   ✔  Approvals: 5
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58948#pullrequestreview-2983898238
   ✔  - Mattias Buelens (@MattiasBuelens): https://github.com/nodejs/node/pull/58948#pullrequestreview-2983969659
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58948#pullrequestreview-2984451374
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58948#pullrequestreview-2985657415
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/58948#pullrequestreview-2989658746
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-07-09T22:57:46Z: https://ci.nodejs.org/job/node-test-pull-request/67916/
- Querying data for job/node-test-pull-request/67916/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 58948
From https://github.com/nodejs/node
 * branch                  refs/pull/58948/merge -> FETCH_HEAD
✔  Fetched commits as c44fa8d0b65d..5b5f9dc85b63
--------------------------------------------------------------------------------
[main f797193ad8] test: deflake stream-readable-to-web test
 Author: Ethan Arrowood <[email protected]>
 Date: Thu Jul 3 10:27:03 2025 -0600
 2 files changed, 69 insertions(+), 62 deletions(-)
 delete mode 100644 test/parallel/test-stream-readable-to-web.js
 create mode 100644 test/parallel/test-stream-readable-to-web.mjs
[main 1eca5dbc83] test: dynamic import cypto
 Author: Ethan Arrowood <[email protected]>
 Date: Thu Jul 3 13:30:28 2025 -0600
 1 file changed, 54 insertions(+), 48 deletions(-)
[main 15def1f185] test: simplify but keep accurate
 Author: Ethan Arrowood <[email protected]>
 Date: Thu Jul 3 15:43:55 2025 -0600
 1 file changed, 36 insertions(+), 47 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: deflake stream-readable-to-web test
Co-authored-by: Luigi Pinca <[email protected]>

PR-URL: #58948

Fixes: #58949

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Mattias Buelens <[email protected]>

Reviewed-By: Juan José Arboleda <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>
[detached HEAD e8edf49e2b] test: deflake stream-readable-to-web test

Author: Ethan Arrowood <[email protected]>

Date: Thu Jul 3 10:27:03 2025 -0600

2 files changed, 69 insertions(+), 62 deletions(-)

delete mode 100644 test/parallel/test-stream-readable-to-web.js

create mode 100644 test/parallel/test-stream-readable-to-web.mjs

Rebasing (3/6)

Rebasing (4/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: dynamic import cypto
PR-URL: #58948

Fixes: #58949

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Mattias Buelens <[email protected]>

Reviewed-By: Juan José Arboleda <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>
[detached HEAD 0b2dba40da] test: dynamic import cypto

Author: Ethan Arrowood <[email protected]>

Date: Thu Jul 3 13:30:28 2025 -0600

1 file changed, 54 insertions(+), 48 deletions(-)

Rebasing (5/6)

Rebasing (6/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: simplify but keep accurate
PR-URL: #58948

Fixes: #58949

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Mattias Buelens <[email protected]>

Reviewed-By: Juan José Arboleda <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>
[detached HEAD 936c7f6cc9] test: simplify but keep accurate

Author: Ethan Arrowood <[email protected]>

Date: Thu Jul 3 15:43:55 2025 -0600

1 file changed, 36 insertions(+), 47 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/16201169771

nodejs-github-bot · 2025-08-02T04:25:37Z

Landed in fa458d2

Co-authored-by: Luigi Pinca <[email protected]> PR-URL: nodejs#58948 Fixes: nodejs#58949 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>

Co-authored-by: Luigi Pinca <[email protected]> PR-URL: #58948 Fixes: #58949 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>

Co-authored-by: Luigi Pinca <[email protected]> PR-URL: nodejs#58948 Fixes: nodejs#58949 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>

Co-authored-by: Luigi Pinca <[email protected]> PR-URL: #58948 Fixes: #58949 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `24.5.0` -> `24.6.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v24.6.0`](https://github.com/nodejs/node/releases/tag/v24.6.0): 2025-08-14, Version 24.6.0 (Current), @RafaelGSS [Compare Source](nodejs/node@v24.5.0...v24.6.0) ##### Notable Changes - \[[`471fe712b3`](nodejs/node@471fe712b3)] - **(SEMVER-MINOR)** **cli**: add NODE\_USE\_SYSTEM\_CA=1 (Joyee Cheung) [#59276](nodejs/node#59276) - \[[`38aedfbf73`](nodejs/node@38aedfbf73)] - **(SEMVER-MINOR)** **crypto**: support ML-DSA KeyObject, sign, and verify (Filip Skokan) [#59259](nodejs/node#59259) - \[[`201304537e`](nodejs/node@201304537e)] - **(SEMVER-MINOR)** **zlib**: add dictionary support to zstdCompress and zstdDecompress (lluisemper) [#59240](nodejs/node#59240) - \[[`e79c93a5d0`](nodejs/node@e79c93a5d0)] - **(SEMVER-MINOR)** **http**: add server.keepAliveTimeoutBuffer option (Haram Jeong) [#59243](nodejs/node#59243) - \[[`c144d69efc`](nodejs/node@c144d69efc)] - **lib**: docs deprecate \_http\_\* (Sebastian Beltran) [#59293](nodejs/node#59293) - \[[`aeb4de55a7`](nodejs/node@aeb4de55a7)] - **(SEMVER-MINOR)** **fs**: port SonicBoom module to fs module as Utf8Stream (James M Snell) [#58897](nodejs/node#58897) ##### Commits - \[[`f7484575ff`](nodejs/node@f7484575ff)] - **assert**: change utils to use index instead of for...of (방진혁) [#59278](nodejs/node#59278) - \[[`269cd16185`](nodejs/node@269cd16185)] - **benchmark**: remove deprecated \_extend from benchmark (Rafael Gonzaga) [#59228](nodejs/node#59228) - \[[`848e49c20b`](nodejs/node@848e49c20b)] - **benchmark**: add fs warmup to writefile-promises (Bruno Rodrigues) [#59215](nodejs/node#59215) - \[[`8c609be1b1`](nodejs/node@8c609be1b1)] - **benchmark**: add calibrate-n script (Rafael Gonzaga) [#59186](nodejs/node#59186) - \[[`6a3bf772d8`](nodejs/node@6a3bf772d8)] - **build**: fix node\_use\_sqlite for GN builds (Shelley Vohr) [#59017](nodejs/node#59017) - \[[`471fe712b3`](nodejs/node@471fe712b3)] - **(SEMVER-MINOR)** **cli**: add NODE\_USE\_SYSTEM\_CA=1 (Joyee Cheung) [#59276](nodejs/node#59276) - \[[`38aedfbf73`](nodejs/node@38aedfbf73)] - **(SEMVER-MINOR)** **crypto**: support ML-DSA KeyObject, sign, and verify (Filip Skokan) [#59259](nodejs/node#59259) - \[[`a312e706cf`](nodejs/node@a312e706cf)] - **crypto**: prepare webcrypto key import/export for modern algorithms (Filip Skokan) [#59284](nodejs/node#59284) - \[[`3a7c2c3a47`](nodejs/node@3a7c2c3a47)] - **deps**: update ada to 3.2.7 (Node.js GitHub Bot) [#59336](nodejs/node#59336) - \[[`8d9ceeaf6a`](nodejs/node@8d9ceeaf6a)] - **deps**: update archs files for openssl-3.5.2 (Node.js GitHub Bot) [#59371](nodejs/node#59371) - \[[`33b06df354`](nodejs/node@33b06df354)] - **deps**: upgrade openssl sources to openssl-3.5.2 (Node.js GitHub Bot) [#59371](nodejs/node#59371) - \[[`fa70f1af77`](nodejs/node@fa70f1af77)] - **deps**: support madvise(3C) across ALL illumos revisions (Dan McDonald) [#58237](nodejs/node#58237) - \[[`f834a6be59`](nodejs/node@f834a6be59)] - **deps**: update undici to 7.13.0 (Node.js GitHub Bot) [#59338](nodejs/node#59338) - \[[`db2417487e`](nodejs/node@db2417487e)] - **deps**: update sqlite to 3.50.4 (Node.js GitHub Bot) [#59337](nodejs/node#59337) - \[[`41978adb08`](nodejs/node@41978adb08)] - **deps**: V8: backport [`493cb53`](nodejs/node@493cb53691be) (Chengzhong Wu) [#59238](nodejs/node#59238) - \[[`05667991ca`](nodejs/node@05667991ca)] - **deps**: V8: backport [`1c3e018`](nodejs/node@1c3e018e7d48) (Renegade334) [#58818](nodejs/node#58818) - \[[`fd61588bb4`](nodejs/node@fd61588bb4)] - **doc**: rename x509.extKeyUsage to x509.keyUsage (Filip Skokan) [#59332](nodejs/node#59332) - \[[`a271ae4360`](nodejs/node@a271ae4360)] - **doc**: fix Pbkdf2Params hash attribute heading (Filip Skokan) [#59395](nodejs/node#59395) - \[[`72cfff165b`](nodejs/node@72cfff165b)] - **doc**: fix missing reference links for server.keepAliveTimeoutBuffer (Lee Jiho) [#59356](nodejs/node#59356) - \[[`8341916772`](nodejs/node@8341916772)] - **doc**: fix grammar in global dispatcher usage (Eng Zer Jun) [#59344](nodejs/node#59344) - \[[`e3e489706b`](nodejs/node@e3e489706b)] - **doc**: run license-builder (github-actions\[bot]) [#59343](nodejs/node#59343) - \[[`46527e8cea`](nodejs/node@46527e8cea)] - **doc**: correct orthography `eg.` → `e.g.` (Jacob Smith) [#59329](nodejs/node#59329) - \[[`d140c3713e`](nodejs/node@d140c3713e)] - **doc**: clarify the need of compiler compatible with c++20 (Rafael Gonzaga) [#59297](nodejs/node#59297) - \[[`95e9cabf9d`](nodejs/node@95e9cabf9d)] - **doc**: clarify release candidate stability index (Filip Skokan) [#59295](nodejs/node#59295) - \[[`a056dd36d2`](nodejs/node@a056dd36d2)] - **doc**: add WDYT to glossary (btea) [#59280](nodejs/node#59280) - \[[`1e2c52f5c4`](nodejs/node@1e2c52f5c4)] - **doc**: add manpage entry for --use-system-ca (Joyee Cheung) [#59273](nodejs/node#59273) - \[[`31a46fdeb4`](nodejs/node@31a46fdeb4)] - **doc**: add path.join and path.normalize clarification (Rafael Gonzaga) [#59262](nodejs/node#59262) - \[[`cff3725ff9`](nodejs/node@cff3725ff9)] - **doc**: fix typo in `test/common/README.md` (Yoo) [#59180](nodejs/node#59180) - \[[`31a9283591`](nodejs/node@31a9283591)] - **doc**: add note on process memoryUsage (fengmk2) [#59026](nodejs/node#59026) - \[[`5a98bff6b8`](nodejs/node@5a98bff6b8)] - **doc**: format safely for `doc-kit` (Aviv Keller) [#59229](nodejs/node#59229) - \[[`95b8b7ea5c`](nodejs/node@95b8b7ea5c)] - **domain**: remove deprecated API call (Alex Yang) [#59339](nodejs/node#59339) - \[[`2990f178bd`](nodejs/node@2990f178bd)] - **fs**: fix glob TypeError on restricted dirs (Sylphy-0xd3ac) [#58674](nodejs/node#58674) - \[[`e2fb4caf9c`](nodejs/node@e2fb4caf9c)] - **fs**: correct error message when FileHandle is transferred (Alex Yang) [#59156](nodejs/node#59156) - \[[`aeb4de55a7`](nodejs/node@aeb4de55a7)] - **(SEMVER-MINOR)** **fs**: port SonicBoom module to fs module as Utf8Stream (James M Snell) [#58897](nodejs/node#58897) - \[[`e79c93a5d0`](nodejs/node@e79c93a5d0)] - **(SEMVER-MINOR)** **http**: add server.keepAliveTimeoutBuffer option (Haram Jeong) [#59243](nodejs/node#59243) - \[[`0fb005a53f`](nodejs/node@0fb005a53f)] - **http2**: set Http2Stream#sentHeaders for raw headers (Darshan Sen) [#59244](nodejs/node#59244) - \[[`e055539604`](nodejs/node@e055539604)] - **lib**: add trace-sigint APIs (theanarkh) [#59040](nodejs/node#59040) - \[[`d2183d860a`](nodejs/node@d2183d860a)] - **lib**: optimize writable stream buffer clearing (Yoo) [#59406](nodejs/node#59406) - \[[`47543a7e17`](nodejs/node@47543a7e17)] - **lib**: handle windows reserved device names on UNC (Rafael Gonzaga) [#59286](nodejs/node#59286) - \[[`c6911f0717`](nodejs/node@c6911f0717)] - **lib**: do not modify prototype deprecated asyncResource (RafaelGSS) [#59195](nodejs/node#59195) - \[[`3c88b769bb`](nodejs/node@3c88b769bb)] - **lib**: restructure assert to become a class (Miguel Marcondes Filho) [#58253](nodejs/node#58253) - \[[`e91b54df59`](nodejs/node@e91b54df59)] - **lib**: handle superscript variants on windows device (Rafael Gonzaga) [#59261](nodejs/node#59261) - \[[`4ee467905d`](nodejs/node@4ee467905d)] - **lib**: use validateString (hotpineapple) [#59296](nodejs/node#59296) - \[[`c144d69efc`](nodejs/node@c144d69efc)] - **lib**: docs deprecate \_http\_\* (Sebastian Beltran) [#59293](nodejs/node#59293) - \[[`c89b67e681`](nodejs/node@c89b67e681)] - **lib**: add type names in source mapped stack traces (Chengzhong Wu) [#58976](nodejs/node#58976) - \[[`5b2363be8d`](nodejs/node@5b2363be8d)] - **lib**: prefer AsyncIteratorPrototype primordial (René) [#59097](nodejs/node#59097) - \[[`41b4f4d694`](nodejs/node@41b4f4d694)] - **meta**: clarify pr objection process further (James M Snell) [#59096](nodejs/node#59096) - \[[`0eb5962f1e`](nodejs/node@0eb5962f1e)] - **meta**: add mailmap entry for aditi-1400 (Aditi) [#59316](nodejs/node#59316) - \[[`a2b72c2304`](nodejs/node@a2b72c2304)] - **meta**: add tsc and build team as codeowners building.md (Rafael Gonzaga) [#59298](nodejs/node#59298) - \[[`d69f3ee1e0`](nodejs/node@d69f3ee1e0)] - **meta**: add nodejs/path to path files (Rafael Gonzaga) [#59289](nodejs/node#59289) - \[[`1e37eab865`](nodejs/node@1e37eab865)] - **node-api**: reword "implementation in an alternative VM" as implementable (Chengzhong Wu) [#59036](nodejs/node#59036) - \[[`64add6302a`](nodejs/node@64add6302a)] - **src**: use simdjson to parse SEA configuration (Joyee Cheung) [#59323](nodejs/node#59323) - \[[`e9c6636585`](nodejs/node@e9c6636585)] - **src**: mark realm leaf classes final (Anna Henningsen) [#59355](nodejs/node#59355) - \[[`42ef8147d1`](nodejs/node@42ef8147d1)] - **src**: warn about FastOneByteString invalidation (James M Snell) [#59275](nodejs/node#59275) - \[[`8686b8037a`](nodejs/node@8686b8037a)] - **src**: remove unused DSAKeyExportJob (Filip Skokan) [#59291](nodejs/node#59291) - \[[`1e5f632666`](nodejs/node@1e5f632666)] - **src**: use C++20 `contains()` method (iknoom) [#59304](nodejs/node#59304) - \[[`22d4683cfe`](nodejs/node@22d4683cfe)] - **src**: added CHECK\_NOT\_NULL check for multiple eq\_wrap\_async (F3lixTheCat) [#59267](nodejs/node#59267) - \[[`6a47ff4943`](nodejs/node@6a47ff4943)] - **src**: clear all linked module caches once instantiated (Chengzhong Wu) [#59117](nodejs/node#59117) - \[[`33728cb4ca`](nodejs/node@33728cb4ca)] - **src**: add nullptr checks in `StreamPipe::New` (Burkov Egor) [#57613](nodejs/node#57613) - \[[`4a907bdad1`](nodejs/node@4a907bdad1)] - **src**: add percentage support to --max-old-space-size (Asaf Federman) [#59082](nodejs/node#59082) - \[[`7c189d4f55`](nodejs/node@7c189d4f55)] - **test**: deflake sequential/test-tls-session-timeout (Joyee Cheung) [#59423](nodejs/node#59423) - \[[`fb0a6fb57f`](nodejs/node@fb0a6fb57f)] - **test**: exclude mock from coverage (Shima Ryuhei) [#59348](nodejs/node#59348) - \[[`7e10f95f13`](nodejs/node@7e10f95f13)] - **test**: split test-fs-cp.js (Joyee Cheung) [#59408](nodejs/node#59408) - \[[`41bcf5f659`](nodejs/node@41bcf5f659)] - **test**: update WPT resources,WebCryptoAPI,webstorage (Filip Skokan) [#59311](nodejs/node#59311) - \[[`f9f3dc94cb`](nodejs/node@f9f3dc94cb)] - **test**: add known issue test for fs.cpSync dereference bug (James M Snell) [#58941](nodejs/node#58941) - \[[`244d0c38a8`](nodejs/node@244d0c38a8)] - **test**: deflake stream-readable-to-web test (Ethan Arrowood) [#58948](nodejs/node#58948) - \[[`564e604a1a`](nodejs/node@564e604a1a)] - **test**: make test-inspector-network-resource sequential (Shima Ryuhei) [#59104](nodejs/node#59104) - \[[`7ab13b7477`](nodejs/node@7ab13b7477)] - **test**: don't use expose internals in test-http-outgoing-buffer.js (Meghan Denny) [#59219](nodejs/node#59219) - \[[`319df3859a`](nodejs/node@319df3859a)] - **test,crypto**: skip unsupported ciphers (Shelley Vohr) [#59388](nodejs/node#59388) - \[[`713c70c32a`](nodejs/node@713c70c32a)] - **test\_runner**: remove unused callee convertion (Alex Yang) [#59221](nodejs/node#59221) - \[[`e4ca30e115`](nodejs/node@e4ca30e115)] - **tools**: disable nullability-completeness warnings (Michaël Zasso) [#59392](nodejs/node#59392) - \[[`dab7f6b542`](nodejs/node@dab7f6b542)] - **tools**: check for std::vector\<v8::Local> in lint (Aditi) [#58497](nodejs/node#58497) - \[[`7b94982eb0`](nodejs/node@7b94982eb0)] - **tools**: allow selecting test subsystems with numbers in their names (Darshan Sen) [#59242](nodejs/node#59242) - \[[`16bbcd8881`](nodejs/node@16bbcd8881)] - **typings**: improve internal binding types (Nam Yooseong) [#59351](nodejs/node#59351) - \[[`76bc4d659b`](nodejs/node@76bc4d659b)] - **typings**: improve internal binding types (Michaël Zasso) [#59176](nodejs/node#59176) - \[[`eecd3272a6`](nodejs/node@eecd3272a6)] - **worker**: add name for worker (theanarkh) [#59213](nodejs/node#59213) - \[[`84c3513ce2`](nodejs/node@84c3513ce2)] - **worker**: implements nits in Web Locks code (Antoine du Hamel) [#59270](nodejs/node#59270) - \[[`bd68fbd753`](nodejs/node@bd68fbd753)] - **worker**: add cpuUsage for worker (theanarkh) [#59177](nodejs/node#59177) - \[[`201304537e`](nodejs/node@201304537e)] - **(SEMVER-MINOR)** **zlib**: add dictionary support to zstdCompress and zstdDecompress (lluisemper) [#59240](nodejs/node#59240) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: Luigi Pinca <[email protected]> PR-URL: #58948 Fixes: #58949 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>

Ethan-Arrowood added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 3, 2025

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 3, 2025

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 3, 2025

mcollina approved these changes Jul 3, 2025

View reviewed changes

mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 3, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

lpinca approved these changes Jul 3, 2025

View reviewed changes

test/parallel/test-stream-readable-to-web.mjs Outdated Show resolved Hide resolved

lpinca previously approved these changes Jul 3, 2025

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

MattiasBuelens approved these changes Jul 3, 2025

View reviewed changes

juanarbol approved these changes Jul 3, 2025

View reviewed changes

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2025

Ethan-Arrowood added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 10, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 10, 2025

daeyeon approved these changes Aug 2, 2025

View reviewed changes

daeyeon added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 2, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2025

nodejs-github-bot merged commit fa458d2 into nodejs:main Aug 2, 2025
92 checks passed

github-actions bot mentioned this pull request Aug 11, 2025

2025-08-12, Version 24.6.0 (Current) #59449

Merged

github-actions bot mentioned this pull request Aug 26, 2025

2025-08-28, Version 22.19.0 'Jod' (LTS) #59641

Merged

Uh oh!

test: deflake stream-readable-to-web test #58948

test: deflake stream-readable-to-web test #58948

Conversation

Ethan-Arrowood commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ethan-Arrowood commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Ethan-Arrowood commented Jul 3, 2025

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 3, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 3, 2025

Uh oh!

codecov bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Ethan-Arrowood commented Jul 3, 2025

Uh oh!

targos commented Jul 3, 2025

Uh oh!

Ethan-Arrowood commented Jul 3, 2025

Uh oh!

lpinca commented Jul 3, 2025

Uh oh!

Ethan-Arrowood commented Jul 3, 2025

Uh oh!

nodejs-github-bot commented Jul 3, 2025

Uh oh!

nodejs-github-bot commented Jul 9, 2025

Uh oh!

nodejs-github-bot commented Jul 10, 2025

PR-URL: #58948 Fixes: #58949 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>

PR-URL: #58948 Fixes: #58949 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>

[detached HEAD 936c7f6cc9] test: simplify but keep accurate Author: Ethan Arrowood <[email protected]> Date: Thu Jul 3 15:43:55 2025 -0600 1 file changed, 36 insertions(+), 47 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 2, 2025

Uh oh!

Uh oh!

Ethan-Arrowood commented Jul 3, 2025 •

edited

Loading

codecov bot commented Jul 3, 2025 •

edited

Loading

PR-URL: #58948
Fixes: #58949
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mattias Buelens <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>

PR-URL: #58948
Fixes: #58949
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mattias Buelens <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>

[detached HEAD 936c7f6cc9] test: simplify but keep accurate
Author: Ethan Arrowood <[email protected]>
Date: Thu Jul 3 15:43:55 2025 -0600
1 file changed, 36 insertions(+), 47 deletions(-)
Successfully rebased and updated refs/heads/main.