[IBM] Remap components to application for IBM stack by moficodes · Pull Request #1603 · kubeflow/community-distribution

moficodes · 2020-11-02T23:46:57Z

Which issue is resolved by this Pull Request:
Resolves # -

Description of your changes:
We are remapping the IBM manifests to use Only application instead of a mix of application and components

Checklist:

Unit tests have been rebuilt:
1. cd manifests/tests
2. make generate-changed-only
3. make test

kubeflow-bot · 2020-11-02T23:47:03Z

This change is

k8s-ci-robot · 2020-11-02T23:47:07Z

Hi @moficodes. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tomcli

For the kfctl_ibm_customstack.yaml URI, can you change it to https://github.com/kubeflow/manifests/archive/master.tar.gz. So it can work once this PR is merged? thanks.

Tomcli · 2020-11-03T02:03:42Z

Overall, it looks good to me.

moficodes

@Tomcli made the change.

Reviewable status: 0 of 250 files reviewed, all discussions resolved (waiting on @krishnadurai and @PatrickXYS)

Tomcli · 2020-11-03T18:58:41Z

@moficodes you need to rebase since kfp moved to 1.0.4

moficodes · 2020-11-04T17:39:17Z

@Tomcli Done!

Tomcli · 2020-11-04T17:51:59Z

@moficodes it will be nice if you can squash your commits into one. This way the PR won't show the rebase commits from master.

PatrickXYS · 2020-11-04T20:53:27Z

/test kubeflow-manifests-presubmit-e2e

k8s-ci-robot · 2020-11-04T20:53:32Z

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test kubeflow-manifests-presubmit-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T21:23:57Z

/test ?

aws-kf-ci-bot · 2020-11-04T21:24:00Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit-e2e

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-11-04T21:24:02Z

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T21:24:45Z

If you have rebased from master branch, you can try to run test

Tomcli · 2020-11-04T21:33:27Z

/test all

k8s-ci-robot · 2020-11-04T21:33:32Z

@Tomcli: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tomcli · 2020-11-04T22:24:49Z

/lgtm for the deployment,
I'm not sure why there no presubmit test after the rebase

Tomcli · 2020-11-04T22:26:28Z

/test kubeflow-manifests-presubmit-e2e

k8s-ci-robot · 2020-11-04T22:26:33Z

@Tomcli: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test kubeflow-manifests-presubmit-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-04T22:38:41Z

#1601

Since we have migrated to AWS Test-infra after this PR merged, can you rebase master and then re-run the test?

PatrickXYS · 2020-11-05T17:54:47Z

/test ?

aws-kf-ci-bot · 2020-11-05T17:54:50Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit-e2e

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tomcli · 2020-11-05T22:14:23Z

/test all

k8s-ci-robot · 2020-11-05T22:14:28Z

@Tomcli: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-05T23:26:10Z

/test ?

aws-kf-ci-bot · 2020-11-05T23:26:13Z

@PatrickXYS: The following commands are available to trigger jobs:

/test kubeflow-manifests-presubmit-e2e

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-11-05T23:26:14Z

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PatrickXYS · 2020-11-05T23:26:56Z

/test kubeflow-manifests-presubmit-e2e

k8s-ci-robot · 2020-11-05T23:27:00Z

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test kubeflow-manifests-presubmit-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tomcli · 2020-11-06T05:41:46Z

/test kubeflow-manifests-presubmit-e2e
/lgtm

k8s-ci-robot · 2020-11-06T05:41:50Z

@Tomcli: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test kubeflow-manifests-presubmit-e2e
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tomcli · 2020-11-06T17:26:56Z

/assign @animeshsingh

Remove reference to components Regenerate tests Move global variable to individual application

Tomcli · 2020-11-06T18:06:36Z

/test kubeflow-manifests-presubmit-e2e
/lgtm

k8s-ci-robot · 2020-11-06T18:06:40Z

@Tomcli: No presubmit jobs available for kubeflow/manifests@master

Details

In response to this:

/test kubeflow-manifests-presubmit-e2e
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

animeshsingh · 2020-11-06T21:42:23Z

/lgtm
/approve

k8s-ci-robot · 2020-11-06T21:42:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, moficodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~kfdef/OWNERS~~ [animeshsingh]
~~stacks/ibm/OWNERS~~ [animeshsingh]
~~tests/OWNERS~~ [animeshsingh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PRs: Manifest (kubeflow/community-distribution#1603) Website (kubeflow/website#1752) Reviews: Manifest(kubeflow/community-distribution#1621, kubeflow/community-distribution#1594, kubeflow/community-distribution#1582, kubeflow/community-distribution#1567) kfctl(kubeflow/kfctl#419) Website(kubeflow/website#2327) Issue Triage: kfctl(kubeflow/kfctl#428, kubeflow/kfctl#424, kubeflow/kfctl#418)

k8s-ci-robot requested review from PatrickXYS and krishnadurai November 2, 2020 23:47

k8s-ci-robot added the needs-ok-to-test label Nov 2, 2020

moficodes changed the title ~~remap components to application for IBM stack~~ [IBM] Remap components to application for IBM stack Nov 2, 2020

k8s-ci-robot added the size/XXL label Nov 2, 2020

google-cla Bot added the cla: yes label Nov 2, 2020

Tomcli suggested changes Nov 3, 2020

View reviewed changes

moficodes commented Nov 3, 2020

View reviewed changes

moficodes force-pushed the upstream branch from fbbd5d7 to 594d107 Compare November 4, 2020 21:20

moficodes requested a review from Tomcli November 4, 2020 21:24

moficodes force-pushed the upstream branch from 9a83a9f to 59113e3 Compare November 6, 2020 02:37

k8s-ci-robot assigned Tomcli Nov 6, 2020

k8s-ci-robot added the lgtm label Nov 6, 2020

k8s-ci-robot assigned animeshsingh Nov 6, 2020

moficodes added 2 commits November 6, 2020 13:02

Remap components to application for IBM stack

e431c9a

Remove reference to components Regenerate tests Move global variable to individual application

rename app to kubeflow-apps for v3

6f15b1f

moficodes force-pushed the upstream branch from 59113e3 to 6f15b1f Compare November 6, 2020 18:03

k8s-ci-robot removed the lgtm label Nov 6, 2020

k8s-ci-robot added the lgtm label Nov 6, 2020

PatrickXYS mentioned this pull request Nov 6, 2020

Disable some of the kubeflow repos' trigger kubernetes/test-infra#19872

Merged

k8s-ci-robot added the approved label Nov 6, 2020

k8s-ci-robot merged commit b0fd34c into kubeflow:master Nov 6, 2020

animeshsingh mentioned this pull request Nov 11, 2020

add @moficodes to Kubeflow org kubeflow/internal-acls#399

Merged

moficodes deleted the upstream branch December 1, 2020 18:20

Conversation

moficodes commented Nov 2, 2020

Uh oh!

kubeflow-bot commented Nov 2, 2020

Uh oh!

k8s-ci-robot commented Nov 2, 2020

Uh oh!

Tomcli left a comment

Choose a reason for hiding this comment

Uh oh!

Tomcli commented Nov 3, 2020

Uh oh!

moficodes left a comment

Choose a reason for hiding this comment

Uh oh!

Tomcli commented Nov 3, 2020

Uh oh!

moficodes commented Nov 4, 2020

Uh oh!

Tomcli commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

aws-kf-ci-bot commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

Tomcli commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

Tomcli commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tomcli commented Nov 4, 2020

Uh oh!

k8s-ci-robot commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 4, 2020

Uh oh!

PatrickXYS commented Nov 5, 2020

Uh oh!

aws-kf-ci-bot commented Nov 5, 2020

Uh oh!

Tomcli commented Nov 5, 2020

Uh oh!

k8s-ci-robot commented Nov 5, 2020

Uh oh!

PatrickXYS commented Nov 5, 2020

Uh oh!

aws-kf-ci-bot commented Nov 5, 2020

Uh oh!

k8s-ci-robot commented Nov 5, 2020

Uh oh!

PatrickXYS commented Nov 5, 2020

Uh oh!

k8s-ci-robot commented Nov 5, 2020

Uh oh!

Tomcli commented Nov 6, 2020

Uh oh!

k8s-ci-robot commented Nov 6, 2020

Uh oh!

Tomcli commented Nov 6, 2020

Uh oh!

Tomcli commented Nov 6, 2020

Uh oh!

k8s-ci-robot commented Nov 6, 2020

Uh oh!

animeshsingh commented Nov 6, 2020

Uh oh!

k8s-ci-robot commented Nov 6, 2020

Uh oh!

Reviewers

Assignees

Tomcli commented Nov 4, 2020 •

edited

Loading