Disable some of the kubeflow repos' trigger

[PatrickXYS]

Given the fact that some of the kubeflow repos exist two bot respond to /retest, /test all, etc. This is caused by some of the repos migrated to AWS CI, but still rely on upstream prow/tide managed PR.

E.g, manifests PR

Thus, disabling some of the kubeflow repos' trigger plugin to avoid two bots multiple response and save developer's confusions

/cc @jlewi @cblecker

[k8s-ci-robot]

Hi @PatrickXYS. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MushuEE]

Would it be helpful to have an exclude_repos option?

[PatrickXYS]

Would it be helpful to have an exclude_repos option?

That would be great if we have, but I don't think trigger support this feature yet, someone can correct me if I'm wrong

[jlewi]

@PatrickXYS Lets add a comment here explaining why the default is no longer "on" for new repos.

Can we also file an issue to track updating the new repository setup guide
https://github.com/kubeflow/community/blob/master/repository-setup.md

/cc @Bobgy

[PatrickXYS]

I added comments to explain the reason, also, file issue here to keep track kubeflow/community#450

[k8s-ci-robot]

@jlewi: GitHub didn't allow me to request PR reviews from the following users: Bobgy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@PatrickXYS Lets add a comment here explaining why the default is no longer "on" for new repos.

Can we also file an issue to track updating the new repository setup guide
https://github.com/kubeflow/community/blob/master/repository-setup.md

/cc @Bobgy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bobgy]

/lgtm
Thanks!

[k8s-ci-robot]

@Bobgy: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bobgy]

@PatrickXYS I'm not sure about the change, in fact. Will k8s tide continue to work on those repos? (Tide is responsible for merging PRs)
If not, has @aws-kf-ci-bot been configured to handle tide actions? (does it have permissions?)

I'd suggest starting with testing one repo and when we get everything working as expected, move to the others.

[PatrickXYS]

I'm not sure about the change, in fact. Will k8s tide continue to work on those repos? (Tide is responsible for merging PRs)

What I change here is about Prow plugin - trigger, and Tide is one of the core component in Prow.

So I think Tide should still work as before, and k8s-ci-bot will continuously work on those repos.

I'm okay to start with one repo if we're not sure

/cc @Bobgy @jlewi

[k8s-ci-robot]

@PatrickXYS: GitHub didn't allow me to request PR reviews from the following users: Bobgy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

I'm not sure about the change, in fact. Will k8s tide continue to work on those repos? (Tide is responsible for merging PRs)

What I change here is about Prow plugin - trigger, and Tide is one of the core component in Prow.

So I think Tide should still work as before, and k8s-ci-bot will continuously work on those repos.

I'm okay to start with one repo if we're not sure

/cc @Bobgy @jlewi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bobgy]

SGTM

@PatrickXYS because there are no people we can ask for quick approval if the change broke some repos. The risk is high, so shall we reduce to just one repo first?

[jlewi]

So the plan is to merge #19897 first to test with a single repo and then if that looks good merge this one?

[PatrickXYS]

So the plan is to merge #19897 first to test with a single repo and then if that looks good merge this one?

Yes, so the #19897 will be able to confirm if there's any risk in disabling repo's trigger, after confirmation, we'll go ahead with other repos.

[PatrickXYS]

We started experiment on this PR #19897

After it merged, we expect kubeflow/kfctl only exist one bot to respond /test ?,

and I experimented here kubeflow/kfctl#247 (comment), it's working properly.

I'll go ahead with other repos in this one single PR

/cc @jlewi @Bobgy

[k8s-ci-robot]

@PatrickXYS: GitHub didn't allow me to request PR reviews from the following users: Bobgy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

We started experiment on this PR #19897

After it merged, we expect kubeflow/kfctl only exist one bot to respond /test ?,

and I experimented here kubeflow/kfctl#247 (comment), it's working properly.

I'll go ahead with other repos in this one single PR

/cc @jlewi @Bobgy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bobgy]

/lgtm
/assign @jlewi

[k8s-ci-robot]

@Bobgy: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
/assign @jlewi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlewi]

/lgtm
/approve

[PatrickXYS]

{"component":"unset","file":"prow/cmd/checkconfig/main.go:79","func":"main.reportWarning","level":"warning","msg":"the following repos have jobs configured but do not have the trigger plugin enabled: repo: kubeflow/pytorch-operator","severity":"warning","time":"2020-11-17T13:17:30Z"}

This is the error message, but that's exactly what we want to do.

I assume this is because pytorch-operator still have postsubmit job configured https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubeflow/kubeflow-postsubmits.yaml#L57-L69

  kubeflow/pytorch-operator:
  - name: kubeflow-pytorch-operator-postsubmit
    cluster: kubeflow
    labels:
      preset-service-account: "true"
    spec:
      containers:
      - image: gcr.io/kubeflow-ci/test-worker:latest
        imagePullPolicy: Always

    annotations:
      testgrid-dashboards: sig-big-data
      description: Postsubmit kubeflow/pytorch-operator.

Will try to clean up this as well

[PatrickXYS]

Can you help on adding / ok-to-test and I'll wait to see if test can pass? @jlewi

[PatrickXYS]

Friendly ping @jlewi @cblecker

[jlewi]

/lgtm
/approve

[PatrickXYS]

ERROR: /home/prow/go/src/github.com/kubernetes/test-infra/config/tests/testgrids/BUILD.bazel:25:1: Executing genrule //config/tests/testgrids:testgrid_config failed (Exit 1)
2020/11/20 15:31:49 FAIL: could not write config: 1 error occurred:
	* configuration error for (TestGroup) kubeflow-pytorch-operator-postsubmit: Each Test Group must be referenced by at least 1 Dashboard Tab.

I see, maybe I need to clean up testgird config for pytorch as well

[cblecker]

/ok-to-test

[cblecker]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jlewi, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• config/OWNERS [cblecker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@PatrickXYS: Updated the following 2 configmaps:

• job-config configmap in namespace default at cluster test-infra-trusted using the following files:
  • key kubeflow-postsubmits.yaml using file config/jobs/kubeflow/kubeflow-postsubmits.yaml
• plugins configmap in namespace default at cluster test-infra-trusted using the following files:
  • key plugins.yaml using file config/prow/plugins.yaml

Details

In response to this:

Given the fact that some of the kubeflow repos exist two bot respond to /retest, /test all, etc. This is caused by some of the repos migrated to AWS CI, but still rely on upstream prow/tide managed PR.

E.g, manifests PR

Thus, disabling some of the kubeflow repos' trigger plugin to avoid two bots multiple response and save developer's confusions

/cc @jlewi @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.