-
Notifications
You must be signed in to change notification settings - Fork 62.5k
Describe $RUNNER_OS
/$RUNNER_TEMP
/$RUNNER_TOOL_CACHE
environment variables
#6740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Runners set up environment variables corresponding to the runner context's properties. The runner context documents the runner.os, runner.temp, and runner.tool_cache properties, so document these three as supported environment variables similarly. The tool_cache property value is not documented as being used for GitHub AE (see context-and-expression-syntax-for-github-actions.md), so just leave $RUNNER_TOOL_CACHE undocumented in this case.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👋 @jmarshall We cannot accept this PR until you've verified with support which environment variables should be documented. After you get that information from the support team please feel free to open a new issue with that information. Thanks for your interest in improving the GitHub docs! |
This repository's CONTRIBUTING.md says
This implies that sometimes the GitHub Docs team brings PRs to the attention of their GitHub colleagues in the relevant part of Engineering who will review them directly. That would be a much more efficient way to verify which of these environment variables are supported than for me to compose the question a third time in such detail that Support sees its meaning, routes the question to the right people, and replies in a reasonable timeframe. But, as noted above, even if that happened it would be pointless because you would have no reason to believe what I, a non-GitHub-employee, reported — so the Docs team would have to verify it directly with Engineering anyway. I notice that in e.g. #3060 (comment), #3788 (review), #4945 (comment), #5359 (comment), and #6615 (comment) the Docs team have themselves consulted their colleagues elsewhere within GitHub to directly verify aspects of these other outsiders' PRs. Is there a reason why this PR is being treated differently? Thanks. |
Following. The reason given for closing this does not make sense at all IMHO. It basically says that PR's for GH Docs should go to https://support.github.com/contact first? |
👋 @jmarshall I’ve spoken with the team and we've decided to reopen this PR. I apologize for closing this PR prematurely. Thank you for taking the time to voice your concerns with our process so that we can continue to improve. Please note that we’ll still need to validate with the engineering team and don’t know when they’ll have the bandwidth to prioritize. We appreciate your patience. |
Changes in this PR(The links below will stop working after merge)
|
(Closing and reopening this PR for CI purposes) |
Checking questions with support. |
Sorry about the delay here, following up 👍 |
Received confirmation that these environment variables are supported: RUNNER_OS, RUNNER_TEMP, and RUNNER_TOOL_CACHE 👍 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Changes are now live:
|
Why:
Closes #6127.
What's being changed:
As noted in #6127, several
$RUNNER_xyz
environment variables are set up by runners corresponding to${{ runner.xyz }}
context properties. A total of sevenRUNNER_*
environment variables are currently set in job steps, and it is unclear which are intended to be used and are supported for use by workflow steps. There are three correspondingrunner
context properties that are documented in “Context and expression syntax for GitHub Actions”, so this PR adds the environment variables corresponding to these three to the “Default environment variables” list:RUNNER_OS
Linux
,Windows
, ormacOS
.RUNNER_TEMP
RUNNER_TOOL_CACHE
(The
tool_cache
property value is not documented as being used for GitHub AE, so this PR just leaves$RUNNER_TOOL_CACHE
unlisted and undocumented in this case.)In considering merging this, it would be prudent for GitHub staff to confirm exactly which of these environment variables are intended to be supported for use in workflow steps; in particular, to confirm whether exactly these three are supported as environment variables, similarly to their context property equivalents.
(On #6127 it was suggested that I might attempt to confirm which are supported by contacting GitHub Support. However there is little point in a non-GitHub-employee such as myself doing that, as whoever took responsibility for merging this would need to confirm directly with other GitHub employees (in engineering or support) that the information so obtained was accurate.)
Check off the following:
Writer impact (This section is for GitHub staff members only):