Skip to content

Add note on 1K limit for GitHub Actions token #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2021

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Feb 19, 2021

Why:

Using the built-in token only provides 1K requests vs. a user PAT as currently documented.

What's being changed:

Adding small note to existing rate limit doc, that should probably be word-smithed by someone from the product team.

Check off the following:

@janiceilene janiceilene added the actions This issue or pull request should be reviewed by the docs actions team label Feb 22, 2021
@janiceilene
Copy link
Contributor

@nschonni Thanks so much for opening a PR! I'll get this triaged for review

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 22, 2021
@skedwards88 skedwards88 self-assigned this Mar 2, 2021
@skedwards88
Copy link
Contributor

Thank you for opening this PR to clarify the docs! Can you point me to where you found this rate limit?

@nschonni
Copy link
Contributor Author

nschonni commented Mar 2, 2021

https://github.com/tabatkins/bikeshed/runs/2007469198?check_suite_focus=true#step:5:11
Maybe its unique to the GITHUB_TOKEN running as part of a cron job, but I didn't try other combos

skedwards88
skedwards88 previously approved these changes Mar 4, 2021
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this issue! I confirmed your finding with the engineering team:

GITHUB_TOKEN is limited to 1000 requests per hour per repository. For organizations that belong to a GitHub Enterprise Cloud account, this limit is 15,000 requests per hour per repository.

I updated your PR with this info. Thank you again for your contribution! 💖 I'll get this merged down for you.

@skedwards88 skedwards88 dismissed stale reviews from ghost and themself via 5ed1232 March 4, 2021 00:12
@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 4, 2021
@nschonni
Copy link
Contributor Author

nschonni commented Mar 4, 2021

I think the 15K part is covered a few lines above (in the conditional rendering), but happy for you to word-smith as much as you like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants