Skip to content

Add required trailing dot for CNAME setup #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

tomayac
Copy link

@tomayac tomayac commented Apr 14, 2021

Why:

Closes #5358

What's being changed:

Add trailing dots.

Check off the following:

@welcome
Copy link

welcome bot commented Apr 14, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 14, 2021
@janiceilene
Copy link
Contributor

@tomayac Thanks so much for opening an issue and PR for this fix! I'll get this triaged for review ⚡

@janiceilene janiceilene added pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 14, 2021
Copy link

@Nirzak Nirzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get it actually. I have used CNAME before without the . in the end of the domain name and it works like a charm. I mean what's point to put a dot in the last of the domain!

Copy link

@nathanlayla nathanlayla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

@tomayac
Copy link
Author

tomayac commented May 7, 2021

Looks like someone else after @mahdiamer needs to approve for this to land.

@janiceilene
Copy link
Contributor

@tomayac So sorry for the delayed response! I've spoken with our engineers and this isn't a change we're looking to make in the docs. Most DNS providers add the trailing dot implicitly and will remove it in the UI if you include the trailing dot, so this addition would add confusion for the majority of users.

Thank you so much for your interest in improving the GitHub documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNAME configuration lacks missing trailing dots
6 participants