-
Notifications
You must be signed in to change notification settings - Fork 62.5k
Add required trailing dot for CNAME setup #5359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@tomayac Thanks so much for opening an issue and PR for this fix! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get it actually. I have used CNAME before without the . in the end of the domain name and it works like a charm. I mean what's point to put a dot in the last of the domain!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``
Looks like someone else after @mahdiamer needs to approve for this to land. |
@tomayac So sorry for the delayed response! I've spoken with our engineers and this isn't a change we're looking to make in the docs. Most DNS providers add the trailing dot implicitly and will remove it in the UI if you include the trailing dot, so this addition would add confusion for the majority of users. Thank you so much for your interest in improving the GitHub documentation! |
Why:
Closes #5358
What's being changed:
Add trailing dots.
Check off the following: