Skip to content

Update docs to note schedule action delay (#3059) #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

BrentonWheeler
Copy link
Contributor

@BrentonWheeler BrentonWheeler commented Jan 22, 2021

Why:

These start time delays on scheduled actions are significant and I think warrant a mention so that people aren't scratching their head for too long questioning what they did wrong

See the related issue

What's being changed:

The change can be found on this staging ENV page and can be seen on the following screenshot

Screen Shot 2021-01-22 at 4 45 27 pm

Check off the following:

The schedule action start time delay is significant (up to an hour) and warrants a mention to save people time thinking it's something they are doing incorrectly
@welcome
Copy link

welcome bot commented Jan 22, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene linked an issue Jan 22, 2021 that may be closed by this pull request
@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 22, 2021
@janiceilene
Copy link
Contributor

@BrentonWheeler Thanks so much for opening a PR! I'll get this triaged for review ⚡

@skedwards88 skedwards88 self-assigned this Jan 29, 2021
@skedwards88
Copy link
Contributor

I just want to confirm with engineering about the expected behavior (see #3059) before merging this.

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
@janiceilene
Copy link
Contributor

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛

@janiceilene janiceilene reopened this Feb 16, 2021
@BrentonWheeler
Copy link
Contributor Author

"github-actions closes a PR to improve its own docs, it's becoming sentient 😱."

haha all good 👍, also any update on the related Issue's comment here?

@janiceilene
Copy link
Contributor

😆 Thanks for understanding @BrentonWheeler! I'll check in with the writer (my guess is that they're still waiting on engineering) and ask them to update the other issue with any new info 💖

@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@skedwards88
Copy link
Contributor

Yes, I am checking with engineering again. Thank you for your patience!

@skedwards88 skedwards88 dismissed a stale review via 6ec1c13 February 22, 2021 20:21
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for taking the initiative and clarifying the docs! I'll get this merged down.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Feb 22, 2021
@skedwards88 skedwards88 enabled auto-merge (squash) February 22, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention currently delays in "schedule" actions start time
4 participants