Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Extract FML command_line target #26028

Merged
merged 1 commit into from
May 8, 2021
Merged

Extract FML command_line target #26028

merged 1 commit into from
May 8, 2021

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented May 8, 2021

Command-line argument parsing is valuable even in the absence of the
rest of FML's functionality.

This is pre-factoring for uwptool, which adds an adb-like helper tool
for install, uninstall, and launch of UWP applications for Windows
platforms.

See: flutter/flutter#81756

Build refactoring -- code is covered by existing tests

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 8, 2021
@cbracken
Copy link
Member Author

cbracken commented May 8, 2021

Note that this is necessary until #25749 lands.

That said, keeping dependencies minimal for additional tooling is also good build hygiene so it's unnecessary to re-merge these targets once that lands.

clarkezone
clarkezone approved these changes May 8, 2021
View reviewed changes
Copy link

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken force-pushed the fml-command-line branch from a44662c to 7d86ee6 Compare May 8, 2021 05:02
@cbracken
Extract FML command_line target
af0fffb 
Command-line argument parsing is valuable even in the absence of the
rest of FML's functionality.

This is pre-factoring for uwptool, which adds an adb-like helper tool
for install, uninstall, and launch of UWP applications for Windows
platforms.

See: flutter/flutter#81756
@cbracken cbracken force-pushed the fml-command-line branch from 7d86ee6 to af0fffb Compare May 8, 2021 05:11
@cbracken cbracken merged commit 3d73e06 into flutter:master May 8, 2021
@cbracken cbracken deleted the fml-command-line branch May 8, 2021 06:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
3d73e06 Extract FML command_line target (flutter/engine#26028)
4839d84
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
3d73e06 Extract FML command_line target (flutter/engine#26028)
709baa2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
3d73e06 Extract FML command_line target (flutter/engine#26028)
3f349b1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
3d73e06 Extract FML command_line target (flutter/engine#26028)
defa212
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
3d73e06 Extract FML command_line target (flutter/engine#26028)
8db2428
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
3d73e06 Extract FML command_line target (flutter/engine#26028)
bd29d94
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
3d73e06 Extract FML command_line target (flutter/engine#26028)
7704137
zanderso pushed a commit to flutter/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
Roll Engine from f57e986 to 1825bef (39 revisions) (#82132)
e7f0439 
* ccaae8d Roll Skia from 537293bf155f to adadb95a9f1e (1 revision) (flutter/engine#25905)

* 2e3a7f8 Roll buildroot to pick change to cppwinrt invocation (flutter/engine#25993)

* 1c22286 [Linux] revise dark theme detection (flutter/engine#25535)

* 7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)

* 406c4da Ensure that AutoIsolateShutdown drops its reference to the DartIsolate on the intended task runner (flutter/engine#25899)

* 72c2fda [web] Fix incorrect physical size due to visualviewport api on iOS (flutter/engine#25895)

* a712ffe Roll Dart SDK from b8f4018535fa to 86c749398b3a (16 revisions) (flutter/engine#25999)

* edbbb12 Roll Fuchsia Mac SDK from uQgs5ZmFq... to aCsEHpnS0... (flutter/engine#26001)

* afbbeac Implement smooth resizing for Linux (flutter/engine#25884)

* 3ffb8ef Roll Dart SDK from 86c749398b3a to b4210cc43086 (2 revisions) (flutter/engine#26006)

* 039dcd9 pull googletest from github instead of fuchsia.googlesource (flutter/engine#25907)

* 9c793f1 Roll Skia from adadb95a9f1e to 1dc2d0fe0fa0 (98 revisions) (flutter/engine#26009)

* 82efb9a Roll Skia from 1dc2d0fe0fa0 to 115645ee9b1b (2 revisions) (flutter/engine#26012)

* 91a4c72 Delete unused method from engine_layer.h (flutter/engine#25924)

* 619f82f fuchsia: Fix multi-views fallout (flutter/engine#25984)

* 0b4bf7e Fixes BUILD.gn if is_fuchsia (legacy embedder) and is_debug (flutter/engine#25858)

* 2e9de09 Streamline frame timings recording (flutter/engine#25892)

* 1077da8 [vsync_waiter] add AwaitVSyncForSecondaryCallback() (flutter/engine#25787)

* 0053bef [build_fuchsia_artifacts] Move license copying into BuildBucket(). (flutter/engine#25815)

* e8b80e7 Roll Skia from 115645ee9b1b to c411429239e9 (7 revisions) (flutter/engine#26018)

* d3353b2 Move more parts to libraries. (flutter/engine#25863)

* d1a1182 Roll Dart SDK from b4210cc43086 to 04e55dad908d (2 revisions) (flutter/engine#26020)

* f631f5b Exclude third_party/dart/third_party/devtools from the license script (flutter/engine#25918)

* 304539b Roll Fuchsia Mac SDK from aCsEHpnS0... to OyXxehV6e... (flutter/engine#26022)

* c3e28ae Roll Fuchsia Linux SDK from 4numS0K6T... to -FIIsjZj2... (flutter/engine#26023)

* 6cacb53 Roll Skia from c411429239e9 to 72de83df3a03 (1 revision) (flutter/engine#26024)

* bfccba5 Add dependency on Windows SDK CIPD package (flutter/engine#26003)

* 06cbf1e Roll Dart SDK from 04e55dad908d to 094c9024373c (1 revision) (flutter/engine#26027)

* 73aaeea Roll Skia from 72de83df3a03 to dabb2891c4a1 (4 revisions) (flutter/engine#26025)

* e229649 Extract Windows string_conversion target (flutter/engine#26029)

* 3d73e06 Extract FML command_line target (flutter/engine#26028)

* 4aace54 Make SceneBuilder.push* not return nullable objects (flutter/engine#25991)

* 0d62a56 Roll Dart SDK from 094c9024373c to 2ea89ef8f6de (1 revision) (flutter/engine#26030)

* 5a26c1f Use string_view inputs for conversion functions (flutter/engine#26031)

* 4f28de4 Support windows registry access (flutter/engine#26032)

* 234fae1 Roll Fuchsia Linux SDK from -FIIsjZj2... to KZCe5FqMb... (flutter/engine#26034)

* 7a47d3b Roll Fuchsia Mac SDK from OyXxehV6e... to DSk0IzBHv... (flutter/engine#26035)

* 01f9bd8 Roll Skia from dabb2891c4a1 to 686dd910dd6c (1 revision) (flutter/engine#26036)

* 1825bef Revert Dart SDK to b8f4018535fa792891e2add3a475f35e3ec156ab (flutter/engine#26037)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request May 21, 2021
@cbracken
Extract FML command_line target (flutter#26028)
1b1160b 
Command-line argument parsing is valuable even in the absence of the
rest of FML's functionality.

This is pre-factoring for uwptool, which adds an adb-like helper tool
for install, uninstall, and launch of UWP applications for Windows
platforms.

See: flutter/flutter#81756
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clarkezone clarkezone clarkezone approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
affects: engine cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbracken @clarkezone