[web] Fix incorrect physical size due to visualviewport api on iOS #25895

ferhatb · 2021-05-03T21:00:41Z

Fixed Chrome on iOS reporting incorrect visualviewport height when application is launched in portrait and then phone is rotated.

flutter/flutter#81430

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.
The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2021-05-03T21:00:43Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

yjbanov

yjbanov · 2021-05-03T21:02:35Z

lib/web_ui/lib/src/engine/window.dart

-        windowInnerWidth = viewport.width!.toDouble() * devicePixelRatio;
-        windowInnerHeight = viewport.height!.toDouble() * devicePixelRatio;
+        if (browserEngine == BrowserEngine.webkit &&
+            operatingSystem == OperatingSystem.iOs) {


iOS implies webkit

yjbanov · 2021-05-03T21:03:58Z

lib/web_ui/lib/src/engine/dom_renderer.dart

      EnginePlatformDispatcher.instance.invokeOnMetricsChanged();
    } else {
      window._computePhysicalSize();
      // When physical size changes this value has to be recalculated.
-      window.computeOnScreenKeyboardInsets();
+      window.computeOnScreenKeyboardInsets(false);
      EnginePlatformDispatcher.instance.invokeOnMetricsChanged();


This can be moved out of the if/else. We call it in both cases.

yjbanov · 2021-05-03T21:06:42Z

lib/web_ui/lib/src/engine/window.dart

    double windowInnerHeight;
    final html.VisualViewport? viewport = html.window.visualViewport;
    if (viewport != null) {
-      windowInnerHeight = viewport.height!.toDouble() * devicePixelRatio;
+      if (browserEngine == BrowserEngine.webkit &&
+          operatingSystem == OperatingSystem.iOs && isEditingOnMobile) {


ios => webkit, so we can just check for ios

…n iOS (flutter/engine#25895)

* ccaae8d Roll Skia from 537293bf155f to adadb95a9f1e (1 revision) (flutter/engine#25905) * 2e3a7f8 Roll buildroot to pick change to cppwinrt invocation (flutter/engine#25993) * 1c22286 [Linux] revise dark theme detection (flutter/engine#25535) * 7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860) * 406c4da Ensure that AutoIsolateShutdown drops its reference to the DartIsolate on the intended task runner (flutter/engine#25899) * 72c2fda [web] Fix incorrect physical size due to visualviewport api on iOS (flutter/engine#25895) * a712ffe Roll Dart SDK from b8f4018535fa to 86c749398b3a (16 revisions) (flutter/engine#25999) * edbbb12 Roll Fuchsia Mac SDK from uQgs5ZmFq... to aCsEHpnS0... (flutter/engine#26001) * afbbeac Implement smooth resizing for Linux (flutter/engine#25884) * 3ffb8ef Roll Dart SDK from 86c749398b3a to b4210cc43086 (2 revisions) (flutter/engine#26006) * 039dcd9 pull googletest from github instead of fuchsia.googlesource (flutter/engine#25907) * 9c793f1 Roll Skia from adadb95a9f1e to 1dc2d0fe0fa0 (98 revisions) (flutter/engine#26009) * 82efb9a Roll Skia from 1dc2d0fe0fa0 to 115645ee9b1b (2 revisions) (flutter/engine#26012) * 91a4c72 Delete unused method from engine_layer.h (flutter/engine#25924) * 619f82f fuchsia: Fix multi-views fallout (flutter/engine#25984) * 0b4bf7e Fixes BUILD.gn if is_fuchsia (legacy embedder) and is_debug (flutter/engine#25858) * 2e9de09 Streamline frame timings recording (flutter/engine#25892) * 1077da8 [vsync_waiter] add AwaitVSyncForSecondaryCallback() (flutter/engine#25787) * 0053bef [build_fuchsia_artifacts] Move license copying into BuildBucket(). (flutter/engine#25815) * e8b80e7 Roll Skia from 115645ee9b1b to c411429239e9 (7 revisions) (flutter/engine#26018) * d3353b2 Move more parts to libraries. (flutter/engine#25863) * d1a1182 Roll Dart SDK from b4210cc43086 to 04e55dad908d (2 revisions) (flutter/engine#26020) * f631f5b Exclude third_party/dart/third_party/devtools from the license script (flutter/engine#25918) * 304539b Roll Fuchsia Mac SDK from aCsEHpnS0... to OyXxehV6e... (flutter/engine#26022) * c3e28ae Roll Fuchsia Linux SDK from 4numS0K6T... to -FIIsjZj2... (flutter/engine#26023) * 6cacb53 Roll Skia from c411429239e9 to 72de83df3a03 (1 revision) (flutter/engine#26024) * bfccba5 Add dependency on Windows SDK CIPD package (flutter/engine#26003) * 06cbf1e Roll Dart SDK from 04e55dad908d to 094c9024373c (1 revision) (flutter/engine#26027) * 73aaeea Roll Skia from 72de83df3a03 to dabb2891c4a1 (4 revisions) (flutter/engine#26025) * e229649 Extract Windows string_conversion target (flutter/engine#26029) * 3d73e06 Extract FML command_line target (flutter/engine#26028) * 4aace54 Make SceneBuilder.push* not return nullable objects (flutter/engine#25991) * 0d62a56 Roll Dart SDK from 094c9024373c to 2ea89ef8f6de (1 revision) (flutter/engine#26030) * 5a26c1f Use string_view inputs for conversion functions (flutter/engine#26031) * 4f28de4 Support windows registry access (flutter/engine#26032) * 234fae1 Roll Fuchsia Linux SDK from -FIIsjZj2... to KZCe5FqMb... (flutter/engine#26034) * 7a47d3b Roll Fuchsia Mac SDK from OyXxehV6e... to DSk0IzBHv... (flutter/engine#26035) * 01f9bd8 Roll Skia from dabb2891c4a1 to 686dd910dd6c (1 revision) (flutter/engine#26036) * 1825bef Revert Dart SDK to b8f4018535fa792891e2add3a475f35e3ec156ab (flutter/engine#26037)

…lutter#25895)

Fix incorrect physical size due to visualviewport api on iOS

cc3b6e4

ferhatb added the platform-web Code specifically for the web engine label May 3, 2021

google-cla bot added the cla: yes label May 3, 2021

ferhatb requested a review from yjbanov May 3, 2021 21:00

yjbanov approved these changes May 3, 2021

View reviewed changes

ferhatb added 5 commits May 4, 2021 17:57

Fix edit check

4da9185

Merge remote-tracking branch 'upstream/master' into viewportfix

197daf1

Fix null warning

359bad2

address reviewer comments

46bb070

Merge remote-tracking branch 'upstream/master' into viewportfix

ab9331e

ferhatb merged commit 72c2fda into flutter:master May 7, 2021

engine-flutter-autoroll mentioned this pull request May 7, 2021

Roll Engine from f57e986aa80c to f631f5bcb2d7 (23 revisions) flutter/flutter#82070

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

5e66ec5

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to bfccba5ac00c (27 revisions) flutter/flutter#82079

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

77960e9

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 06cbf1e0d773 (28 revisions) flutter/flutter#82083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

8391915

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 73aaeea34640 (29 revisions) flutter/flutter#82090

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

7ea0ae1

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to e229649a7a97 (30 revisions) flutter/flutter#82096

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

0985eb2

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 4aace5476b33 (32 revisions) flutter/flutter#82097

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

bdf9e30

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 0d62a560fe6a (33 revisions) flutter/flutter#82120

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

bcca991

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 4f28de494253 (35 revisions) flutter/flutter#82121

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

a143794

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 234fae1b8d1d (36 revisions) flutter/flutter#82122

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

cf50a6b

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 8, 2021

Roll Engine from f57e986aa80c to 7a47d3b32567 (37 revisions) flutter/flutter#82127

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

d12ebfb

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 9, 2021

Roll Engine from f57e986aa80c to 01f9bd8649cd (38 revisions) flutter/flutter#82130

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

6e93eef

…n iOS (flutter/engine#25895)

engine-flutter-autoroll mentioned this pull request May 9, 2021

Roll Engine from f57e986aa80c to 1825befbc72d (39 revisions) flutter/flutter#82132

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021

72c2fda [web] Fix incorrect physical size due to visualviewport api o…

1e04d30

…n iOS (flutter/engine#25895)

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request May 21, 2021

[web] Fix incorrect physical size due to visualviewport api on iOS (f…

8811a76

…lutter#25895)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[web] Fix incorrect physical size due to visualviewport api on iOS #25895

[web] Fix incorrect physical size due to visualviewport api on iOS #25895

Uh oh!

ferhatb commented May 3, 2021

Uh oh!

flutter-dashboard bot commented May 3, 2021

Uh oh!

yjbanov left a comment

Uh oh!

yjbanov May 3, 2021

Uh oh!

ferhatb May 6, 2021

Uh oh!

yjbanov May 3, 2021

Uh oh!

ferhatb May 6, 2021

Uh oh!

yjbanov May 3, 2021

Uh oh!

ferhatb May 6, 2021

Uh oh!

Uh oh!

[web] Fix incorrect physical size due to visualviewport api on iOS #25895

[web] Fix incorrect physical size due to visualviewport api on iOS #25895

Uh oh!

Conversation

ferhatb commented May 3, 2021

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 3, 2021

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

yjbanov May 3, 2021

Choose a reason for hiding this comment

Uh oh!

ferhatb May 6, 2021

Choose a reason for hiding this comment

Uh oh!

yjbanov May 3, 2021

Choose a reason for hiding this comment

Uh oh!

ferhatb May 6, 2021

Choose a reason for hiding this comment

Uh oh!

yjbanov May 3, 2021

Choose a reason for hiding this comment

Uh oh!

ferhatb May 6, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!