Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Moved PlatformMessage's to unique_ptrs #25860

Merged
merged 10 commits into from
May 7, 2021
Merged

Moved PlatformMessage's to unique_ptrs #25860

merged 10 commits into from
May 7, 2021

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Apr 30, 2021 •
edited
Loading

This is in preparation for our work that removes copies of messages that are passed to the embedder. In order to safely transfer the data without a copy we need to be sure we are the only one with a copy of that data, thus the unique_ptr.

issue: flutter/flutter#81559

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@gaaclarke
Copy link
Member Author

It would be nice to get flutter/flutter#81414 landed and running before landing this. This change might have a slight measurable difference on performance since unique_ptr should be faster than refptr.

@gaaclarke gaaclarke marked this pull request as ready for review April 30, 2021 20:56
@gaaclarke gaaclarke requested a review from chinmaygarde April 30, 2021 20:56
@gaaclarke gaaclarke mentioned this pull request Apr 30, 2021
Merged
9 tasks
@gaaclarke
Copy link
Member Author

After this PR lands the next step is to move std::vector to fml::NonOwnedMapping, I started that here: #25867

@gaaclarke
Copy link
Member Author

@chinmaygarde friendly ping

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 6, 2021
@fluttergithubbot fluttergithubbot merged commit 7424400 into flutter:master May 7, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
49b19a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
c6ce123
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
67bd652
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
7488888
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
cb095c3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
717e7f2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
ed666e0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
eee2db5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
0515d8c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
fc12f07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
4964453
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)
fe7451b
zanderso pushed a commit to flutter/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
Roll Engine from f57e986 to 1825bef (39 revisions) (#82132)
e7f0439 
* ccaae8d Roll Skia from 537293bf155f to adadb95a9f1e (1 revision) (flutter/engine#25905)

* 2e3a7f8 Roll buildroot to pick change to cppwinrt invocation (flutter/engine#25993)

* 1c22286 [Linux] revise dark theme detection (flutter/engine#25535)

* 7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)

* 406c4da Ensure that AutoIsolateShutdown drops its reference to the DartIsolate on the intended task runner (flutter/engine#25899)

* 72c2fda [web] Fix incorrect physical size due to visualviewport api on iOS (flutter/engine#25895)

* a712ffe Roll Dart SDK from b8f4018535fa to 86c749398b3a (16 revisions) (flutter/engine#25999)

* edbbb12 Roll Fuchsia Mac SDK from uQgs5ZmFq... to aCsEHpnS0... (flutter/engine#26001)

* afbbeac Implement smooth resizing for Linux (flutter/engine#25884)

* 3ffb8ef Roll Dart SDK from 86c749398b3a to b4210cc43086 (2 revisions) (flutter/engine#26006)

* 039dcd9 pull googletest from github instead of fuchsia.googlesource (flutter/engine#25907)

* 9c793f1 Roll Skia from adadb95a9f1e to 1dc2d0fe0fa0 (98 revisions) (flutter/engine#26009)

* 82efb9a Roll Skia from 1dc2d0fe0fa0 to 115645ee9b1b (2 revisions) (flutter/engine#26012)

* 91a4c72 Delete unused method from engine_layer.h (flutter/engine#25924)

* 619f82f fuchsia: Fix multi-views fallout (flutter/engine#25984)

* 0b4bf7e Fixes BUILD.gn if is_fuchsia (legacy embedder) and is_debug (flutter/engine#25858)

* 2e9de09 Streamline frame timings recording (flutter/engine#25892)

* 1077da8 [vsync_waiter] add AwaitVSyncForSecondaryCallback() (flutter/engine#25787)

* 0053bef [build_fuchsia_artifacts] Move license copying into BuildBucket(). (flutter/engine#25815)

* e8b80e7 Roll Skia from 115645ee9b1b to c411429239e9 (7 revisions) (flutter/engine#26018)

* d3353b2 Move more parts to libraries. (flutter/engine#25863)

* d1a1182 Roll Dart SDK from b4210cc43086 to 04e55dad908d (2 revisions) (flutter/engine#26020)

* f631f5b Exclude third_party/dart/third_party/devtools from the license script (flutter/engine#25918)

* 304539b Roll Fuchsia Mac SDK from aCsEHpnS0... to OyXxehV6e... (flutter/engine#26022)

* c3e28ae Roll Fuchsia Linux SDK from 4numS0K6T... to -FIIsjZj2... (flutter/engine#26023)

* 6cacb53 Roll Skia from c411429239e9 to 72de83df3a03 (1 revision) (flutter/engine#26024)

* bfccba5 Add dependency on Windows SDK CIPD package (flutter/engine#26003)

* 06cbf1e Roll Dart SDK from 04e55dad908d to 094c9024373c (1 revision) (flutter/engine#26027)

* 73aaeea Roll Skia from 72de83df3a03 to dabb2891c4a1 (4 revisions) (flutter/engine#26025)

* e229649 Extract Windows string_conversion target (flutter/engine#26029)

* 3d73e06 Extract FML command_line target (flutter/engine#26028)

* 4aace54 Make SceneBuilder.push* not return nullable objects (flutter/engine#25991)

* 0d62a56 Roll Dart SDK from 094c9024373c to 2ea89ef8f6de (1 revision) (flutter/engine#26030)

* 5a26c1f Use string_view inputs for conversion functions (flutter/engine#26031)

* 4f28de4 Support windows registry access (flutter/engine#26032)

* 234fae1 Roll Fuchsia Linux SDK from -FIIsjZj2... to KZCe5FqMb... (flutter/engine#26034)

* 7a47d3b Roll Fuchsia Mac SDK from OyXxehV6e... to DSk0IzBHv... (flutter/engine#26035)

* 01f9bd8 Roll Skia from dabb2891c4a1 to 686dd910dd6c (1 revision) (flutter/engine#26036)

* 1825bef Revert Dart SDK to b8f4018535fa792891e2add3a475f35e3ec156ab (flutter/engine#26037)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request May 21, 2021
@gaaclarke
Moved PlatformMessage's to unique_ptrs (flutter#25860)
ff6dfd8
@gaaclarke gaaclarke mentioned this pull request May 21, 2021
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
cla: yes embedder Related to the embedder API platform-android platform-fuchsia platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaaclarke @chinmaygarde @fluttergithubbot