Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Implement smooth resizing for Linux #25884

Merged
merged 14 commits into from
May 7, 2021
Merged

Implement smooth resizing for Linux #25884

merged 14 commits into from
May 7, 2021

Conversation

knopp
Copy link
Member

@knopp knopp commented May 3, 2021

Fixes flutter/flutter#81677

Conceptually this is similar to what macOS and Windows embedder are doing (blocking the platform thread in resize event until frame of proper size is presented). The difference here is that on Linux the platform and raster thread are merged, so the implementation must ensure that flutter tasks are processed normally while waiting for the frame (otherwise raster thread would be blocked and not produce any frame). This is done in fl_task_runner.cc.

My initial prototype was simply running a nested GMainLoop within the resize event handler, but this caused problems with wayland where some events were prematurely processed while resize callback was still in progress. FlTaskRunner solves this by only processing flutter tasks.

Tested with X11 and Wayland.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@knopp knopp requested a review from stuartmorgan-g May 3, 2021 11:12
@google-cla google-cla bot added the cla: yes label May 3, 2021
@knopp knopp requested review from robert-ancell and cbracken May 3, 2021 11:13
@knopp knopp force-pushed the linux_smooth_resizing branch 2 times, most recently from 71ae764 to d8b3b6b Compare May 3, 2021 11:17
robert-ancell
robert-ancell reviewed May 4, 2021
View reviewed changes
robert-ancell
robert-ancell reviewed May 4, 2021
View reviewed changes
robert-ancell
robert-ancell reviewed May 4, 2021
View reviewed changes
robert-ancell
robert-ancell reviewed May 4, 2021
View reviewed changes
@knopp knopp force-pushed the linux_smooth_resizing branch 2 times, most recently from 43fe73d to 37ee1e9 Compare May 5, 2021 22:00
robert-ancell
robert-ancell reviewed May 5, 2021
View reviewed changes
robert-ancell
robert-ancell reviewed May 5, 2021
View reviewed changes
robert-ancell
robert-ancell reviewed May 6, 2021
View reviewed changes
@knopp
Copy link
Member Author

knopp commented May 6, 2021 •
edited
Loading

Now that TaskRunner is holding weak reference to engine, the fl_task_runner_stop method is most likely obsolete, since it's called from FlEngine::dispose, at which point the engine reference gets cleared anyway. I'll remove it.

robert-ancell
robert-ancell approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and confirmed the resizing is now smooth, thanks @knopp!

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 6, 2021
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows UWP Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 6, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
2d29e6a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
5e91b63
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
f4b7f27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
f1479bc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
15be4fd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
67fc183
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
591ac90
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
87db8c4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
88cb90d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
c5a75ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
90622ee
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
afbbeac Implement smooth resizing for Linux (flutter/engine#25884)
4000eb5
zanderso pushed a commit to flutter/flutter that referenced this pull request May 9, 2021
@engine-flutter-autoroll
Roll Engine from f57e986 to 1825bef (39 revisions) (#82132)
e7f0439 
* ccaae8d Roll Skia from 537293bf155f to adadb95a9f1e (1 revision) (flutter/engine#25905)

* 2e3a7f8 Roll buildroot to pick change to cppwinrt invocation (flutter/engine#25993)

* 1c22286 [Linux] revise dark theme detection (flutter/engine#25535)

* 7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860)

* 406c4da Ensure that AutoIsolateShutdown drops its reference to the DartIsolate on the intended task runner (flutter/engine#25899)

* 72c2fda [web] Fix incorrect physical size due to visualviewport api on iOS (flutter/engine#25895)

* a712ffe Roll Dart SDK from b8f4018535fa to 86c749398b3a (16 revisions) (flutter/engine#25999)

* edbbb12 Roll Fuchsia Mac SDK from uQgs5ZmFq... to aCsEHpnS0... (flutter/engine#26001)

* afbbeac Implement smooth resizing for Linux (flutter/engine#25884)

* 3ffb8ef Roll Dart SDK from 86c749398b3a to b4210cc43086 (2 revisions) (flutter/engine#26006)

* 039dcd9 pull googletest from github instead of fuchsia.googlesource (flutter/engine#25907)

* 9c793f1 Roll Skia from adadb95a9f1e to 1dc2d0fe0fa0 (98 revisions) (flutter/engine#26009)

* 82efb9a Roll Skia from 1dc2d0fe0fa0 to 115645ee9b1b (2 revisions) (flutter/engine#26012)

* 91a4c72 Delete unused method from engine_layer.h (flutter/engine#25924)

* 619f82f fuchsia: Fix multi-views fallout (flutter/engine#25984)

* 0b4bf7e Fixes BUILD.gn if is_fuchsia (legacy embedder) and is_debug (flutter/engine#25858)

* 2e9de09 Streamline frame timings recording (flutter/engine#25892)

* 1077da8 [vsync_waiter] add AwaitVSyncForSecondaryCallback() (flutter/engine#25787)

* 0053bef [build_fuchsia_artifacts] Move license copying into BuildBucket(). (flutter/engine#25815)

* e8b80e7 Roll Skia from 115645ee9b1b to c411429239e9 (7 revisions) (flutter/engine#26018)

* d3353b2 Move more parts to libraries. (flutter/engine#25863)

* d1a1182 Roll Dart SDK from b4210cc43086 to 04e55dad908d (2 revisions) (flutter/engine#26020)

* f631f5b Exclude third_party/dart/third_party/devtools from the license script (flutter/engine#25918)

* 304539b Roll Fuchsia Mac SDK from aCsEHpnS0... to OyXxehV6e... (flutter/engine#26022)

* c3e28ae Roll Fuchsia Linux SDK from 4numS0K6T... to -FIIsjZj2... (flutter/engine#26023)

* 6cacb53 Roll Skia from c411429239e9 to 72de83df3a03 (1 revision) (flutter/engine#26024)

* bfccba5 Add dependency on Windows SDK CIPD package (flutter/engine#26003)

* 06cbf1e Roll Dart SDK from 04e55dad908d to 094c9024373c (1 revision) (flutter/engine#26027)

* 73aaeea Roll Skia from 72de83df3a03 to dabb2891c4a1 (4 revisions) (flutter/engine#26025)

* e229649 Extract Windows string_conversion target (flutter/engine#26029)

* 3d73e06 Extract FML command_line target (flutter/engine#26028)

* 4aace54 Make SceneBuilder.push* not return nullable objects (flutter/engine#25991)

* 0d62a56 Roll Dart SDK from 094c9024373c to 2ea89ef8f6de (1 revision) (flutter/engine#26030)

* 5a26c1f Use string_view inputs for conversion functions (flutter/engine#26031)

* 4f28de4 Support windows registry access (flutter/engine#26032)

* 234fae1 Roll Fuchsia Linux SDK from -FIIsjZj2... to KZCe5FqMb... (flutter/engine#26034)

* 7a47d3b Roll Fuchsia Mac SDK from OyXxehV6e... to DSk0IzBHv... (flutter/engine#26035)

* 01f9bd8 Roll Skia from dabb2891c4a1 to 686dd910dd6c (1 revision) (flutter/engine#26036)

* 1825bef Revert Dart SDK to b8f4018535fa792891e2add3a475f35e3ec156ab (flutter/engine#26037)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request May 21, 2021
@knopp
Implement smooth resizing for Linux (flutter#25884)
48a39e3
@knopp knopp deleted the linux_smooth_resizing branch July 17, 2021 09:24
ishitatsuyuki added a commit to ishitatsuyuki/engine that referenced this pull request Sep 5, 2021
@ishitatsuyuki
VSync callback support for Linux
aee1bc6 
This change adds support for VSync callbacks on Linux, making it possible
to run at high refresh rates. The heavy lifting is done by GDK; and so the
implementation just wires the Flutter internals to it.

Unresolved: the implementation conflicts with "smooth resizing" support
(flutter#25884). Smooth resizing blocks the main thread until a frame is rendered,
but this also blocks the VSync callbacks necessary to make progress in
rendering, resulting in a livelock. The smooth resizing is commented out
for now.
@ishitatsuyuki ishitatsuyuki mentioned this pull request Sep 5, 2021
Closed
7 tasks
@knopp knopp mentioned this pull request Jan 20, 2025
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robert-ancell robert-ancell robert-ancell approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

@cbracken cbracken Awaiting requested review from cbracken

Assignees
No one assigned
Labels
cla: yes platform-linux waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smooth resizing on Linux
4 participants
@knopp @fluttergithubbot @robert-ancell @chinmaygarde