Drawing view multi line #1475

VladislavAntonyuk · 2021-07-05T23:14:52Z

WPF, UWP

Description of Change

WPF

UWP

iOS

Bugs Fixed

API Changes

Added:

Class Line (It contains a collection of points, line color, line width, SmoothLine, Granularity)
MultiLineModeProperty, LinesProperty,

Updated:

Renamed DrawingCompletedCommandProperty to DrawingLineCompletedCommandProperty

Removed:

DrawingView: a collection of points, line color, line width, SmoothLine, Granularity

Behavioral Changes

PR Checklist

Has a linked Issue, and the Issue has been approved
Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard

Updated documentation

WPF, UWP

VladislavAntonyuk · 2021-07-06T21:37:27Z

@jfversluis, @AndreiMisiukevich , @pictos please review

pictos · 2021-07-06T21:55:12Z

@VladislavAntonyuk can you fix the build issues?
https://github.com/xamarin/XamarinCommunityToolkit/pull/1475/checks?check_run_id=3003305930

VladislavAntonyuk · 2021-07-06T21:56:55Z

It's not related (ToastOptions). I don't know why but CI doesn't know about TimeSpan. System namespace is imported. You can try build locally. It should be fine.

I will investigate it tomorrow.

pictos · 2021-07-06T22:19:42Z

@VladislavAntonyuk I fixed the TimeSpan issue. Now we have another one related to the DrawingViewService. Looks like the methods haven't the same number of arguments and that's causing compilation errors for WPF.

VladislavAntonyuk · 2021-07-06T22:26:13Z

Thank you!
That's weird, how it appeared in develop, due to the compilation issue.
I will recheck the build on Windows. Maybe something is changed when I added it for iOS and macOS.

VladislavAntonyuk · 2021-07-07T10:55:41Z

@pictos it should be fine now. please check

jfversluis · 2021-07-08T12:48:25Z

Please don't forget to add more comments on all the public members next time :)

VladislavAntonyuk · 2021-07-08T14:00:19Z

Please don't forget to add more comments on all the public members next time :)

Thank you very much for your help!

So it will be in 1.4, not 1.3?

…VladislavAntonyuk/XamarinCommunityToolkit into vantonyuk/drawingView-multiLine

jfversluis · 2021-07-13T08:31:34Z

Please don't forget to add more comments on all the public members next time :)

Thank you very much for your help!

So it will be in 1.4, not 1.3?

Nope, I was totally confused. Should be in 1.3 :)

pictos · 2021-07-13T22:49:01Z

samples/XCT.Sample.WPF/DrawingViewRenderer.wpf.cs

 		}

 		void OnStrokesChanged(object sender, StrokeCollectionChangedEventArgs e)
 		{
-			Element.Points.CollectionChanged -= OnCollectionChanged;
+			Element.Lines.CollectionChanged -= OnCollectionChanged;


Is there a good reason to rename this prop? I presume this will be a binary breaking change

Maybe I didn’t understand your question, but I will try to answer.
DrawingView doesn’t contain collection of lines any more. Instead we added an additional layer - Line. Almost all DrawingView properties are moved to the Line class.
I don’t think it will be correct to leave the name Points. Furthermore it is a Collection of Lines, not Points.

You're right @pictos and not even ABI, API as well :)

That's why I was wondering what we should do with this one. Because this means in 1.2 we have the implementation that we have right now and in 1.3 we have a whole bunch of breaking changes with the DrawingView already while we actually said that we should deprecate something first and then actually remove it.

I think this is a major improvement though and I think if we communicate this in the release notes very clear then it's not too much of a problem?

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <[email protected]> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <[email protected]> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <[email protected]> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view multi line (#1475) * DrawingView MultiLine WPF, UWP * Android * GTK, Tizen * iOS, macOS * DrawingViewService Get Stream from lines * added missing System using * Add GetImageStream * Fix tests * Add description to switches * Styling and comments * DrawingLineCompletedEventArgs * Add summary, Add tests Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * [Bug] Fixed CameraView Linker issue (#1503) * Fixed CameraView linker issue * Added Preserve Conditional * Added test case Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * [iOS | Android] TextSwitcher + [iOS] ImageSwitcher (#1422) * Added text switcher * Added text switcher sample * Address comments * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * address comment * fixed build * fixed typo * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * cached sdk int * Fixed warnings Co-authored-by: Pedro Jesus <[email protected]> * iOS, macOS - Clean DrawingView on Lines clean (#1520) * [Bug] Fixed CameraView crash on FlashMode Torch (#1522) * Update FormsCameraView.ios.cs Fixed CameraView crashing in Torch FlashMode * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/FormsCameraView.ios.cs Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> * Consolidate our XCT platform class (#1559) * Moved and renamed ToolkitPlatform to XCT inside helpers folder * replaced all SDK version calls to XCT cached one * removed unecessary space * Added a cache to the iOS version * [Bug] Fixed CameraView Shutter not responding (#1535) * Fixed CameraView Shutter not responding * Fixed Merge conflict * Update FormsCameraView.ios.cs Removed unnecessary code * Update FormsCameraView.ios.cs Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added Speed Property to mediaelement (#1570) * Added Speed control for MediaElement in iOS and Android * Added Update Speed inside Play Method so after pausing and playing speed will be remembered * Added Sample for speed * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController * Added Speed control for MediaElement in iOS and Android * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController Co-authored-by: Aswin P G <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> Co-authored-by: Andrew Hoefling <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Aswin P G <[email protected]>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <[email protected]> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <[email protected]> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <[email protected]> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view multi line (#1475) * DrawingView MultiLine WPF, UWP * Android * GTK, Tizen * iOS, macOS * DrawingViewService Get Stream from lines * added missing System using * Add GetImageStream * Fix tests * Add description to switches * Styling and comments * DrawingLineCompletedEventArgs * Add summary, Add tests Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * [Bug] Fixed CameraView Linker issue (#1503) * Fixed CameraView linker issue * Added Preserve Conditional * Added test case Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * [iOS | Android] TextSwitcher + [iOS] ImageSwitcher (#1422) * Added text switcher * Added text switcher sample * Address comments * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * address comment * fixed build * fixed typo * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * cached sdk int * Fixed warnings Co-authored-by: Pedro Jesus <[email protected]> * iOS, macOS - Clean DrawingView on Lines clean (#1520) * [Bug] Fixed CameraView crash on FlashMode Torch (#1522) * Update FormsCameraView.ios.cs Fixed CameraView crashing in Torch FlashMode * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/FormsCameraView.ios.cs Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> * Consolidate our XCT platform class (#1559) * Moved and renamed ToolkitPlatform to XCT inside helpers folder * replaced all SDK version calls to XCT cached one * removed unecessary space * Added a cache to the iOS version * [Bug] Fixed CameraView Shutter not responding (#1535) * Fixed CameraView Shutter not responding * Fixed Merge conflict * Update FormsCameraView.ios.cs Removed unnecessary code * Update FormsCameraView.ios.cs Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added Speed Property to mediaelement (#1570) * Added Speed control for MediaElement in iOS and Android * Added Update Speed inside Play Method so after pausing and playing speed will be remembered * Added Sample for speed * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController * Added Speed control for MediaElement in iOS and Android * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController Co-authored-by: Aswin P G <[email protected]> Co-authored-by: Andrei <[email protected]> * Utc to local string converter (#1555) * Added UtcDateTimeToLocalStringConverter with page to test. * Tests class added * Refactored Tests * Added some additional tests * Added new converter to the Converters gallery * Minor fixes * Code tidy. * Some passing test. * Resolves Error CS8625. * All tests passing * Suggest changes including: Moved BindableProperty to top of class. IsValidDateFormat uses DateTime.TryParse rather then DateTime.Parse. Removed is string type check for DateTimeFormat. * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * removed private from method Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Update RangeSlider.shared.cs (#1545) Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Removed unused code (#1586) Co-authored-by: Pedro Jesus <[email protected]> * [Enhancement][Converter] Add Expression property to MathExpressionConverter and MultiMathExpressionConverter (#1609) * Added Expression parameter * Fixed Expression property declaration * Updated sample page * Added Tests Co-authored-by: Pedro Jesus <[email protected]> * [Bug] [XCT.Sample] Fixed ContentPages BackgroundColor (#1595) * Removed SetAppThemeColor * Move `BasePage` to `Pages` folder * Handle Null Dereferences introduced in .NET 6 Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> * CornerRadiusEffect (#1316) * CornerRadiusEffect added * cosmetics * Safe corner radius value impl * nullable fix * reduce to one linq call Co-authored-by: Pedro Jesus <[email protected]> * Effect replaced by event subscription * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/CornerRadius/CornerRadiusEffect.shared.cs * C#9 cleanup * removed extra ) * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/CornerRadius/CornerRadiusEffect.shared.cs Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> * Update dotnet-format-daily.yml * MauiCompat Fix for preview 12 (#1792) * Fix for preview 12 * Allow Prerelease of .NET 6 * Add `--include-previews` to Install .NET MAUI Workload * Specify .NET v6.0.2 * Install Nightly .NET Build * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * dotnet install with script * Update azure-pipelines.yml * install using script * Update azure-pipelines.yml * set version * remove dir Co-authored-by: Brandon Minnick <[email protected]> * Match Visual Studio 2022 .NET 6.0.2 Preview Version * Update azure-pipelines.yml Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Andrew Hoefling <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Aswin P G <[email protected]> Co-authored-by: Leonard <[email protected]> Co-authored-by: Yann Zahringer Ferrando <[email protected]>

DrawingView MultiLine

345145b

WPF, UWP

VladislavAntonyuk mentioned this pull request Jul 5, 2021

[Enhancement] DrawingView multiple line support #1462

Closed

2 tasks

jfversluis added a/DrawingView api-change 🚨 labels Jul 6, 2021

VladislavAntonyuk added 2 commits July 6, 2021 18:26

Android

93b9fdf

GTK, Tizen

e7e8b6a

VladislavAntonyuk mentioned this pull request Jul 6, 2021

[Bug] DrawingCompletedCommand improperly implemented #1474

Closed

iOS, macOS

be67ae3

VladislavAntonyuk marked this pull request as ready for review July 6, 2021 20:38

VladislavAntonyuk and others added 2 commits July 6, 2021 14:34

DrawingViewService Get Stream from lines

39b6dbe

Merge branch 'develop' into vantonyuk/drawingView-multiLine

99cb2b0

added missing System using

1d5426c

VladislavAntonyuk and others added 2 commits July 7, 2021 13:45

Add GetImageStream

0955d74

Merge branch 'develop' into vantonyuk/drawingView-multiLine

5c667cf

VladislavAntonyuk and others added 3 commits July 7, 2021 15:55

Fix tests

495767a

Merge branch 'develop' into vantonyuk/drawingView-multiLine

e0e316d

Add description to switches

b9bbbfb

jfversluis previously approved these changes Jul 8, 2021

View reviewed changes

jfversluis added this to the 1.4 milestone Jul 8, 2021

Styling and comments

ba1658e

jfversluis dismissed their stale review via ba1658e July 8, 2021 12:46

Merge branch 'develop' into vantonyuk/drawingView-multiLine

bd61cfb

VladislavAntonyuk added 2 commits July 12, 2021 13:57

DrawingLineCompletedEventArgs

312df02

Merge branch 'vantonyuk/drawingView-multiLine' of https://github.com/…

78d8e74

…VladislavAntonyuk/XamarinCommunityToolkit into vantonyuk/drawingView-multiLine

VladislavAntonyuk mentioned this pull request Jul 12, 2021

Feature/add drawingcompleted event to drawingview #1473

Closed

6 tasks

Add summary, Add tests

87eff54

jfversluis modified the milestones: 1.4, 1.3 Jul 13, 2021

Merge branch 'develop' into vantonyuk/drawingView-multiLine

15c26ef

pictos reviewed Jul 13, 2021

View reviewed changes

Merge branch 'develop' into vantonyuk/drawingView-multiLine

f894543

jfversluis approved these changes Jul 16, 2021

View reviewed changes

jfversluis merged commit 8d688e4 into xamarin:develop Jul 16, 2021

VladislavAntonyuk deleted the vantonyuk/drawingView-multiLine branch July 16, 2021 18:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Drawing view multi line #1475

Drawing view multi line #1475

Uh oh!

VladislavAntonyuk commented Jul 5, 2021 •

edited by jfversluis

Loading

Uh oh!

VladislavAntonyuk commented Jul 6, 2021

Uh oh!

pictos commented Jul 6, 2021

Uh oh!

VladislavAntonyuk commented Jul 6, 2021 •

edited

Loading

Uh oh!

pictos commented Jul 6, 2021

Uh oh!

VladislavAntonyuk commented Jul 6, 2021 •

edited

Loading

Uh oh!

VladislavAntonyuk commented Jul 7, 2021

Uh oh!

jfversluis commented Jul 8, 2021

Uh oh!

VladislavAntonyuk commented Jul 8, 2021

Uh oh!

jfversluis commented Jul 13, 2021

Uh oh!

pictos Jul 13, 2021 •

edited

Loading

Uh oh!

VladislavAntonyuk Jul 14, 2021

Uh oh!

jfversluis Jul 14, 2021

Uh oh!

Uh oh!

Drawing view multi line #1475

Drawing view multi line #1475

Uh oh!

Conversation

VladislavAntonyuk commented Jul 5, 2021 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

Uh oh!

VladislavAntonyuk commented Jul 6, 2021

Uh oh!

pictos commented Jul 6, 2021

Uh oh!

VladislavAntonyuk commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pictos commented Jul 6, 2021

Uh oh!

VladislavAntonyuk commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VladislavAntonyuk commented Jul 7, 2021

Uh oh!

jfversluis commented Jul 8, 2021

Uh oh!

VladislavAntonyuk commented Jul 8, 2021

Uh oh!

jfversluis commented Jul 13, 2021

Uh oh!

pictos Jul 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VladislavAntonyuk Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

jfversluis Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VladislavAntonyuk commented Jul 5, 2021 •

edited by jfversluis

Loading

VladislavAntonyuk commented Jul 6, 2021 •

edited

Loading

VladislavAntonyuk commented Jul 6, 2021 •

edited

Loading

pictos Jul 13, 2021 •

edited

Loading