This repository was archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 459
Drawing view multi line #1475
Merged
jfversluis
merged 19 commits into
xamarin:develop
from
VladislavAntonyuk:vantonyuk/drawingView-multiLine
Jul 16, 2021
Merged
Drawing view multi line #1475
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
345145b
DrawingView MultiLine
VladislavAntonyuk 93b9fdf
Android
VladislavAntonyuk e7e8b6a
GTK, Tizen
VladislavAntonyuk be67ae3
iOS, macOS
VladislavAntonyuk 39b6dbe
DrawingViewService Get Stream from lines
VladislavAntonyuk 99cb2b0
Merge branch 'develop' into vantonyuk/drawingView-multiLine
VladislavAntonyuk 1d5426c
added missing System using
pictos 0955d74
Add GetImageStream
VladislavAntonyuk 5c667cf
Merge branch 'develop' into vantonyuk/drawingView-multiLine
VladislavAntonyuk 495767a
Fix tests
VladislavAntonyuk e0e316d
Merge branch 'develop' into vantonyuk/drawingView-multiLine
jfversluis b9bbbfb
Add description to switches
jfversluis ba1658e
Styling and comments
jfversluis bd61cfb
Merge branch 'develop' into vantonyuk/drawingView-multiLine
VladislavAntonyuk 312df02
DrawingLineCompletedEventArgs
VladislavAntonyuk 78d8e74
Merge branch 'vantonyuk/drawingView-multiLine' of https://github.com/…
VladislavAntonyuk 87eff54
Add summary, Add tests
VladislavAntonyuk 15c26ef
Merge branch 'develop' into vantonyuk/drawingView-multiLine
VladislavAntonyuk f894543
Merge branch 'develop' into vantonyuk/drawingView-multiLine
jfversluis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to rename this prop? I presume this will be a binary breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I didn’t understand your question, but I will try to answer.
DrawingView doesn’t contain collection of lines any more. Instead we added an additional layer - Line. Almost all DrawingView properties are moved to the Line class.
I don’t think it will be correct to leave the name Points. Furthermore it is a Collection of Lines, not Points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right @pictos and not even ABI, API as well :)
That's why I was wondering what we should do with this one. Because this means in 1.2 we have the implementation that we have right now and in 1.3 we have a whole bunch of breaking changes with the DrawingView already while we actually said that we should deprecate something first and then actually remove it.
I think this is a major improvement though and I think if we communicate this in the release notes very clear then it's not too much of a problem?