Drawing View #740

pictos · 2021-01-10T01:46:32Z

Description of Change

Adding a Drawing view to the XCT. This is a continuation of #468

Bugs Fixed

Fixes [Enhancement] GesturePad #467

API Changes

This PR just make sure that we are following our code style (if you see something wrong please comment) and fixed StackOverflowException on both WPF and iOS implementation.

Behavioral Changes

Now users can draw easily in your apps!

PR Checklist

Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard

Updated documentation

* DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]>

…Toolkit into drawingViewHolder # Conflicts: # samples/XCT.Sample.Android/Xamarin.CommunityToolkit.Sample.Android.csproj # samples/XCT.Sample.GTK/Xamarin.CommunityToolkit.Sample.GTK.csproj # samples/XCT.Sample.UWP/Xamarin.CommunityToolkit.Sample.UWP.csproj # samples/XCT.Sample.iOS/Xamarin.CommunityToolkit.Sample.iOS.csproj # samples/XCT.Sample/Pages/Views/DrawingViewPage.xaml # samples/XCT.Sample/Pages/Views/DrawingViewPage.xaml.cs # samples/XCT.Sample/ViewModels/Views/DrawingViewViewModel.cs # src/CommunityToolkit/Xamarin.CommunityToolkit.Sample.Tizen/Xamarin.CommunityToolkit.Sample.Tizen.csproj # src/CommunityToolkit/Xamarin.CommunityToolkit.Sample.WPF/Xamarin.CommunityToolkit.Sample.WPF.csproj # src/CommunityToolkit/Xamarin.CommunityToolkit.Sample/Xamarin.CommunityToolkit.Sample.csproj # src/CommunityToolkit/Xamarin.CommunityToolkit/Views/AvatarView/ImageSourceValidator.android.ios.macos.uwp.wpf.gtk.tizen.cs # src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Snackbar/Helpers/SnackBarLayout.uwp.wpf.cs

VladislavAntonyuk · 2021-01-11T22:28:51Z

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Snackbar/Options/ToastOptions.shared.cs

@@ -23,7 +23,7 @@ public class ToastOptions
 		/// </summary>
 		public Color BackgroundColor { get; set; } = DefaultBackgroundColor;

-		public static Color DefaultBackgroundColor { get; set; } = Color.Default;
+		public static Color DefaultBackgroundColor { get; set; } = Color.White;


Please revert this changes

samples/XCT.Sample.WPF/MainWindow.xaml.cs

samples/XCT.Sample/App.xaml.cs

…Toolkit into pj/drawingwork # Conflicts: # samples/XCT.Sample/Resx/AppResources.Designer.cs

jfversluis

Couple of small things, overall looks good! I love how it supports ALL platforms!

jfversluis · 2021-02-08T08:15:20Z

README.md

@@ -48,6 +48,42 @@ xmlns:xct="http://xamarin.com/schemas/2020/toolkit">

 The documentation is still under construction, but we've published the most important things over at [Microsoft Docs](https://docs.microsoft.com/en-us/xamarin/community-toolkit/). If you want to contribute some of the missing bits you can do this over at the [official Docs repo](https://github.com/MicrosoftDocs/xamarin-communitytoolkit) as contributions are very much welcomed!

+## DrawingView


Let's not add these to the README, this should go into the Docs. Remove it from here, I have copied it so we can add it to the Docs when this gets merged

jfversluis · 2021-02-08T08:15:34Z

samples/XCT.Sample.Android/MainActivity.cs

@@ -16,7 +16,6 @@ protected override void OnCreate(Bundle savedInstanceState)

 			base.OnCreate(savedInstanceState);

-			global::Xamarin.Forms.Forms.SetFlags("CollectionView_Experimental");


jfversluis · 2021-02-08T08:17:19Z

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/DrawingView.shared.cs

+		public static readonly BindableProperty DrawingCompletedCommandProperty = BindableProperty.Create(
+			nameof(DrawingCompletedCommand), typeof(ICommand), typeof(DrawingView), default(ICommand));
+
+		public ObservableCollection<Point> Points


Should we make this a ObservableCollection? Shouldn't we take something more low-level and make it a choice for people to use this?

...munityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.uwp.cs

jfversluis · 2021-05-18T13:54:37Z

OK this builds again, what is the status here? I think this is a great feature, let's have it! :D

VladislavAntonyuk · 2021-05-18T15:07:05Z

I fixed the issue with the build (nullable) and added docs to the public methods.
If you do not see any issues which needs to be fixed, please merge it

pictos · 2021-05-21T00:18:08Z

I'll double-check this weekend if everything is in place and move forward

...nityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Service/DrawingViewService.android.cs

jfversluis · 2021-06-18T18:19:04Z

Just trying this out. On iOS it seems impossible to draw whenever it's in a view that scrolls, is there anything we can still do about that?

Simulator.Screen.Recording.-.iPhone.12.-.2021-06-18.at.20.18.06.mp4

Edit: Ah I wished it showed my touches. But all you can see is that I'm touching in the grey square. Horizontal seems to work if I don't trigger the scroll, anything vertical never works. Outside of a ScrollView it works perfectly

jfversluis · 2021-06-18T18:28:48Z

On Android I can't seem to test the scrolling because the sizing does something weird up til the point where the size seems to go below 0?

draw.mov

Edit: if I set a HeightRequest it stays that and it also does a better job than iOS with the scroll. As long as you draw the parent view doesn't scroll so that's good.

If there is some way we could do that for iOS that would be awesome and we can merge for now afaic

draw.mov

pictos · 2021-06-18T21:16:16Z

cc: @VladislavAntonyuk do you have any idea regarding the @jfversluis comments?

VladislavAntonyuk · 2021-06-18T21:30:02Z

on Android would be nice to fix, I'll take a look.
as for iOS to be honest never tried to use it with scrollView in the simulator. we need somehow to force drawing (stop propagating the scroll event)

pictos · 2021-06-18T21:56:35Z

I'm not an iOS expert, but I believe there's a way to ignore the scroll events or make the OS able to distinguish between drawing gestures and scroll gestures.

jfversluis · 2021-06-19T08:14:43Z

Maybe I'll just merge as is and open issues for these things, people can work around them :)

VladislavAntonyuk · 2021-06-19T17:09:10Z

Maybe I'll just merge as is and open issues for these things, people can work around them :)

Sounds good to me

VladislavAntonyuk · 2021-06-20T09:49:11Z

Awesome, thank you!
I will try to fix that 2 issues tommorow

pictos · 2021-06-20T15:41:01Z

Thank you @VladislavAntonyuk for all hard work and patience with me <3

VladislavAntonyuk · 2021-06-21T13:58:00Z

@pictos thank you for significantly improved the initial PR.
@jfversluis that 2 issues should be fixed by #1421

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <[email protected]> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <[email protected]> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <[email protected]> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> Co-authored-by: Andrew Hoefling <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> Co-authored-by: Daniel Christmas <[email protected]>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <[email protected]> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <[email protected]> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <[email protected]> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> Co-authored-by: Andrew Hoefling <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <[email protected]> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <[email protected]> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <[email protected]> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view multi line (#1475) * DrawingView MultiLine WPF, UWP * Android * GTK, Tizen * iOS, macOS * DrawingViewService Get Stream from lines * added missing System using * Add GetImageStream * Fix tests * Add description to switches * Styling and comments * DrawingLineCompletedEventArgs * Add summary, Add tests Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * [Bug] Fixed CameraView Linker issue (#1503) * Fixed CameraView linker issue * Added Preserve Conditional * Added test case Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * [iOS | Android] TextSwitcher + [iOS] ImageSwitcher (#1422) * Added text switcher * Added text switcher sample * Address comments * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * address comment * fixed build * fixed typo * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * cached sdk int * Fixed warnings Co-authored-by: Pedro Jesus <[email protected]> * iOS, macOS - Clean DrawingView on Lines clean (#1520) * [Bug] Fixed CameraView crash on FlashMode Torch (#1522) * Update FormsCameraView.ios.cs Fixed CameraView crashing in Torch FlashMode * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/FormsCameraView.ios.cs Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> * Consolidate our XCT platform class (#1559) * Moved and renamed ToolkitPlatform to XCT inside helpers folder * replaced all SDK version calls to XCT cached one * removed unecessary space * Added a cache to the iOS version * [Bug] Fixed CameraView Shutter not responding (#1535) * Fixed CameraView Shutter not responding * Fixed Merge conflict * Update FormsCameraView.ios.cs Removed unnecessary code * Update FormsCameraView.ios.cs Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added Speed Property to mediaelement (#1570) * Added Speed control for MediaElement in iOS and Android * Added Update Speed inside Play Method so after pausing and playing speed will be remembered * Added Sample for speed * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController * Added Speed control for MediaElement in iOS and Android * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController Co-authored-by: Aswin P G <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> Co-authored-by: Andrew Hoefling <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Aswin P G <[email protected]>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <[email protected]> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <[email protected]> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <[email protected]> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <[email protected]> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Drawing view multi line (#1475) * DrawingView MultiLine WPF, UWP * Android * GTK, Tizen * iOS, macOS * DrawingViewService Get Stream from lines * added missing System using * Add GetImageStream * Fix tests * Add description to switches * Styling and comments * DrawingLineCompletedEventArgs * Add summary, Add tests Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * [Bug] Fixed CameraView Linker issue (#1503) * Fixed CameraView linker issue * Added Preserve Conditional * Added test case Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * [iOS | Android] TextSwitcher + [iOS] ImageSwitcher (#1422) * Added text switcher * Added text switcher sample * Address comments * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * address comment * fixed build * fixed typo * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <[email protected]> * cached sdk int * Fixed warnings Co-authored-by: Pedro Jesus <[email protected]> * iOS, macOS - Clean DrawingView on Lines clean (#1520) * [Bug] Fixed CameraView crash on FlashMode Torch (#1522) * Update FormsCameraView.ios.cs Fixed CameraView crashing in Torch FlashMode * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/FormsCameraView.ios.cs Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> * Consolidate our XCT platform class (#1559) * Moved and renamed ToolkitPlatform to XCT inside helpers folder * replaced all SDK version calls to XCT cached one * removed unecessary space * Added a cache to the iOS version * [Bug] Fixed CameraView Shutter not responding (#1535) * Fixed CameraView Shutter not responding * Fixed Merge conflict * Update FormsCameraView.ios.cs Removed unnecessary code * Update FormsCameraView.ios.cs Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Added Speed Property to mediaelement (#1570) * Added Speed control for MediaElement in iOS and Android * Added Update Speed inside Play Method so after pausing and playing speed will be remembered * Added Sample for speed * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <[email protected]> * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController * Added Speed control for MediaElement in iOS and Android * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController Co-authored-by: Aswin P G <[email protected]> Co-authored-by: Andrei <[email protected]> * Utc to local string converter (#1555) * Added UtcDateTimeToLocalStringConverter with page to test. * Tests class added * Refactored Tests * Added some additional tests * Added new converter to the Converters gallery * Minor fixes * Code tidy. * Some passing test. * Resolves Error CS8625. * All tests passing * Suggest changes including: Moved BindableProperty to top of class. IsValidDateFormat uses DateTime.TryParse rather then DateTime.Parse. Removed is string type check for DateTimeFormat. * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * removed private from method Co-authored-by: Andrei <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Update RangeSlider.shared.cs (#1545) Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> * Removed unused code (#1586) Co-authored-by: Pedro Jesus <[email protected]> * [Enhancement][Converter] Add Expression property to MathExpressionConverter and MultiMathExpressionConverter (#1609) * Added Expression parameter * Fixed Expression property declaration * Updated sample page * Added Tests Co-authored-by: Pedro Jesus <[email protected]> * [Bug] [XCT.Sample] Fixed ContentPages BackgroundColor (#1595) * Removed SetAppThemeColor * Move `BasePage` to `Pages` folder * Handle Null Dereferences introduced in .NET 6 Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> * CornerRadiusEffect (#1316) * CornerRadiusEffect added * cosmetics * Safe corner radius value impl * nullable fix * reduce to one linq call Co-authored-by: Pedro Jesus <[email protected]> * Effect replaced by event subscription * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/CornerRadius/CornerRadiusEffect.shared.cs * C#9 cleanup * removed extra ) * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/CornerRadius/CornerRadiusEffect.shared.cs Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Brandon Minnick <[email protected]> * Update dotnet-format-daily.yml * MauiCompat Fix for preview 12 (#1792) * Fix for preview 12 * Allow Prerelease of .NET 6 * Add `--include-previews` to Install .NET MAUI Workload * Specify .NET v6.0.2 * Install Nightly .NET Build * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * dotnet install with script * Update azure-pipelines.yml * install using script * Update azure-pipelines.yml * set version * remove dir Co-authored-by: Brandon Minnick <[email protected]> * Match Visual Studio 2022 .NET 6.0.2 Preview Version * Update azure-pipelines.yml Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Andrew Hoefling <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Maksym Koshovyi <[email protected]> Co-authored-by: Daniel Christmas <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Yuriy Holembyovskyy <[email protected]> Co-authored-by: Gustavo Oliveira <[email protected]> Co-authored-by: Aswin P G <[email protected]> Co-authored-by: Leonard <[email protected]> Co-authored-by: Yann Zahringer Ferrando <[email protected]>

VladislavAntonyuk and others added 12 commits November 22, 2020 20:48

DrawingView (#468)

8292f3b

* DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <[email protected]> Co-authored-by: Pedro Jesus <[email protected]>

fixed codestyle on Android renderer

9b2c001

GTK renderer adjustments

6132b34

iOS renderer adjustments

caae16f

MacOS renderer adjustments

5ff9aa0

TIzen rendere adjustments

0b884b4

UWP renderer adjustments

648438c

WPF tests

2a30395

Fixed merge conflict

e37af72

Fixed wpf stackoverflow exception

c0addd2

fixed iOS leaks

9d427d9

pictos added the a/views This issue/PR is related to views label Jan 10, 2021

pictos added this to the v1.1 milestone Jan 10, 2021

pictos requested review from jfversluis, sthewissen, jsuarezruiz and AndreiMisiukevich January 10, 2021 01:46

pictos changed the title ~~Pj/drawing work~~ Drawing View Jan 10, 2021

VladislavAntonyuk reviewed Jan 13, 2021

View reviewed changes

revert toast change

f41d645

pictos added the DO-NOT-MERGE Don't merge it.... don't do it! Really... label Jan 14, 2021

VladislavAntonyuk reviewed Jan 14, 2021

View reviewed changes

samples/XCT.Sample/App.xaml.cs Outdated Show resolved Hide resolved

pictos added 3 commits January 31, 2021 21:41

removed wpf implementations

02e1fc4

Merge branch 'develop' of https://github.com/xamarin/XamarinCommunity…

15fe5df

…Toolkit into pj/drawingwork # Conflicts: # samples/XCT.Sample/Resx/AppResources.Designer.cs

root sample page to WelcomePage

4f22164

pictos removed the DO-NOT-MERGE Don't merge it.... don't do it! Really... label Feb 1, 2021

removed DrawingView ctor from MainWindow

42a36c8

jfversluis suggested changes Feb 8, 2021

View reviewed changes

removed drawing instructions from readme

d47a7a4

Merge branch 'develop' into pj/drawingWork

dc46d32

pictos commented May 26, 2021

View reviewed changes

...nityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Service/DrawingViewService.android.cs Outdated Show resolved Hide resolved

return null instead of exception (#1339)

7248f21

pictos requested a review from jfversluis May 30, 2021 00:35

pictos added 2 commits June 7, 2021 19:44

Merge branch 'develop' into pj/drawingWork

c59a709

Merge branch 'develop' into pj/drawingWork

0acada1

jfversluis removed this from the v1.1 milestone Jun 18, 2021

jfversluis added 2 commits June 18, 2021 10:29

Merge branch 'develop' into pj/drawingWork

feef70b

Merge branch 'develop' into pj/drawingWork

7a2996a

Merge branch 'develop' into pj/drawingWork

dfabca1

jfversluis approved these changes Jun 20, 2021

View reviewed changes

jfversluis merged commit a762932 into develop Jun 20, 2021

jfversluis deleted the pj/drawingWork branch June 20, 2021 09:34

		@@ -48,6 +48,42 @@ xmlns:xct="http://xamarin.com/schemas/2020/toolkit">

		The documentation is still under construction, but we've published the most important things over at [Microsoft Docs](https://docs.microsoft.com/en-us/xamarin/community-toolkit/). If you want to contribute some of the missing bits you can do this over at the [official Docs repo](https://github.com/MicrosoftDocs/xamarin-communitytoolkit) as contributions are very much welcomed!

		## DrawingView

		@@ -16,7 +16,6 @@ protected override void OnCreate(Bundle savedInstanceState)

		base.OnCreate(savedInstanceState);

		global::Xamarin.Forms.Forms.SetFlags("CollectionView_Experimental");

Drawing View #740

Drawing View #740

Uh oh!

Conversation

pictos commented Jan 10, 2021

Description of Change

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

Uh oh!

VladislavAntonyuk Jan 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

jfversluis Feb 8, 2021

Choose a reason for hiding this comment

Uh oh!

jfversluis Feb 8, 2021

Choose a reason for hiding this comment

Uh oh!

jfversluis Feb 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jfversluis commented May 18, 2021

Uh oh!

VladislavAntonyuk commented May 18, 2021

Uh oh!

pictos commented May 21, 2021

Uh oh!

Uh oh!

jfversluis commented Jun 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfversluis commented Jun 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pictos commented Jun 18, 2021

Uh oh!

VladislavAntonyuk commented Jun 18, 2021

Uh oh!

pictos commented Jun 18, 2021

Uh oh!

jfversluis commented Jun 19, 2021

Uh oh!

VladislavAntonyuk commented Jun 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VladislavAntonyuk commented Jun 20, 2021

Uh oh!

pictos commented Jun 20, 2021

Uh oh!

VladislavAntonyuk commented Jun 21, 2021

Uh oh!

Uh oh!

jfversluis commented Jun 18, 2021 •

edited

Loading

jfversluis commented Jun 18, 2021 •

edited

Loading

VladislavAntonyuk commented Jun 19, 2021 •

edited

Loading