-
Notifications
You must be signed in to change notification settings - Fork 3
Fix describing type with table in schema #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4399f75
to
2e5f29c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks hacky, but I can't propose a better solution. At least, tests are passed. Feel free to proceed.
I suggest to leave comments here with brief explanation, why such tweaks are legal and don't break anything. And why they're needed.
2e5f29c
to
9addc76
Compare
We already support describing output arguments type with table, for example, here: Line 310 in e9590db
|
So it is purely to support this new way to delare arguments in the schema? Well, how about commenting all blocks, which are for supporting it? I'm pretty sure that it is not obvious from the code itself. |
9addc76
to
489d8be
Compare
Added comments near lines of code. |
Rework of #22
Before this PR, describing argument type in schema with a table resulted in "No value provided" error on query execution and in "unsupported Lua type 'function'" error on variable type validation.
Reworks: introduce tests, separate from descriptions commit.