Skip to content

Add availability of description field in any object/inputObject arguments #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add availability of description field in any object/inputObject arguments #22

wants to merge 7 commits into from

Conversation

no1seman
Copy link

@no1seman no1seman commented Oct 3, 2021

No description provided.

@no1seman no1seman requested review from olegrok and Totktonada October 3, 2021 09:10
DifferentialOrange pushed a commit that referenced this pull request Nov 19, 2021
@no1seman @DifferentialOrange
Improve injected descriptions support
1cc5a45 
Fix using kind with object injections. Support descriptions in
InputObject fields. Include descriptions in args introspection.

Based on PR #22 by @no1seman
@DifferentialOrange DifferentialOrange mentioned this pull request Nov 19, 2021
Merged
@DifferentialOrange
Copy link
Member

I was finishing this PR as a part of this sprint tasks. You can see reworked version in #28 . Since this PR is based on branch of no1seman/graphql and I don't think it's nice to force-push to other people forks' branches, I opened a new one.

DifferentialOrange pushed a commit that referenced this pull request Nov 23, 2021
@no1seman @DifferentialOrange
Improve injected descriptions support
e63189d 
Fix using kind with object injections. Support descriptions in
InputObject fields. Include descriptions in args introspection.

Based on PR #22 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 23, 2021
@no1seman @DifferentialOrange
Improve injected descriptions support
ff4f769 
Fix using kind with object injections. Support descriptions in
InputObject fields. Include descriptions in args introspection.

Based on PR #22 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 30, 2021
@no1seman @DifferentialOrange
Improve injected descriptions support
43ba87c 
Fix using kind with object injections. Support descriptions in
InputObject fields. Include descriptions in args introspection.

Based on PR #22 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 30, 2021
@no1seman @DifferentialOrange
Improve descriptions support
4270a2f 
Fix using kind with object injections. Support descriptions in
InputObject fields. Include descriptions in args introspection.

Based on PR #22 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 30, 2021
@no1seman @DifferentialOrange
Improve descriptions support
51b3bd9 
Fix using kind with object injections. Support descriptions in
InputObject fields. Include descriptions in args introspection.

Based on PR #22 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Dec 1, 2021
@no1seman @DifferentialOrange
Improve descriptions support
fa59e22 
Support descriptions in InputObject fields. Include descriptions in
introspection output.

Based on PR #22 by @no1seman
DifferentialOrange added a commit that referenced this pull request Dec 1, 2021
@DifferentialOrange
Fix describing type with table in schema
6b15568 
Before this patch, describing argument type in schema with a table
resulted in "No value provided" error on query execution.

Based on PR #22 by @no1seman
DifferentialOrange added a commit that referenced this pull request Dec 1, 2021
@DifferentialOrange
Fix variable validation for type as table
4399f75 
Before this patch, describing argument type in schema with a table
resulted in "unsupported Lua type 'function'" error on variable 
type validation.

Based on PR #22 by @no1seman
@DifferentialOrange DifferentialOrange mentioned this pull request Dec 1, 2021
Merged
@DifferentialOrange
Copy link
Member

Now it's two PRs: #28 , #31

DifferentialOrange added a commit that referenced this pull request Dec 2, 2021
@DifferentialOrange
Fix variable validation for type as table
2e5f29c 
Before this patch, describing argument type in schema with a table
resulted in "unsupported Lua type 'function'" error on variable
type validation.

Based on PR #22 by @no1seman
Totktonada pushed a commit that referenced this pull request Dec 14, 2021
@no1seman @Totktonada
Improve descriptions support
e9590db 
Support descriptions in InputObject fields. Include descriptions in
introspection output.

Based on PR #22 by @no1seman
DifferentialOrange added a commit that referenced this pull request Dec 14, 2021
@DifferentialOrange
Fix describing type with table in schema
921e4d8 
Before this patch, describing argument type in schema with a table
resulted in "No value provided" error on query execution.

Based on PR #22 by @no1seman
DifferentialOrange added a commit that referenced this pull request Dec 14, 2021
@DifferentialOrange
Fix variable validation for type as table
9addc76 
Before this patch, describing argument type in schema with a table
resulted in "unsupported Lua type 'function'" error on variable
type validation.

Based on PR #22 by @no1seman
DifferentialOrange added a commit that referenced this pull request Dec 14, 2021
@DifferentialOrange
Fix describing type with table in schema
009b3a2 
Before this patch, describing argument type in schema with a table
resulted in "No value provided" error on query execution.

Based on PR #22 by @no1seman
DifferentialOrange added a commit that referenced this pull request Dec 14, 2021
@DifferentialOrange
Fix variable validation for type as table
489d8be 
Before this patch, describing argument type in schema with a table
resulted in "unsupported Lua type 'function'" error on variable
type validation.

Based on PR #22 by @no1seman
Totktonada pushed a commit that referenced this pull request Dec 14, 2021
@DifferentialOrange @Totktonada
Fix describing type with table in schema
23bc543 
Before this patch, describing argument type in schema with a table
resulted in "No value provided" error on query execution.

Based on PR #22 by @no1seman
Totktonada pushed a commit that referenced this pull request Dec 14, 2021
@DifferentialOrange @Totktonada
Fix variable validation for type as table
4de3632 
Before this patch, describing argument type in schema with a table
resulted in "unsupported Lua type 'function'" error on variable
type validation.

Based on PR #22 by @no1seman
@DifferentialOrange
Copy link
Member

Closed by #28, #31

@kostja kostja mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegrok olegrok Awaiting requested review from olegrok

@Totktonada Totktonada Awaiting requested review from Totktonada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no1seman @DifferentialOrange