Skip to content

Improve descriptions support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

Improve descriptions support #28

merged 1 commit into from
Dec 14, 2021

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Nov 19, 2021 •
edited
Loading

Rework of #22 .

Support descriptions in InputObject fields. Include descriptions in introspection output.

Rework: minor test reworks, rebase on modern branches.

@DifferentialOrange DifferentialOrange mentioned this pull request Nov 19, 2021
Closed
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no1seman-descriptions_everywhere branch 2 times, most recently from e63189d to ff4f769 Compare November 23, 2021 09:15
Totktonada
Totktonada reviewed Nov 30, 2021
View reviewed changes
Totktonada
Totktonada reviewed Nov 30, 2021
View reviewed changes
@Totktonada Totktonada requested a review from olegrok November 30, 2021 00:26
@Totktonada
Copy link
Member

@DifferentialOrange BTW, what do you mean by 'injected'? Is it somewhat non-standard?

@olegrok Please, take a look, if you have a spare time.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no1seman-descriptions_everywhere branch 2 times, most recently from 43ba87c to 4270a2f Compare November 30, 2021 06:53
@DifferentialOrange DifferentialOrange changed the title Improve injected descriptions support Improve descriptions support Nov 30, 2021
@DifferentialOrange
Copy link
Member Author

@DifferentialOrange BTW, what do you mean by 'injected'? Is it somewhat non-standard?

Removed the word to not confuse anyone since it doesn't seems necessary.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no1seman-descriptions_everywhere branch from 4270a2f to 51b3bd9 Compare November 30, 2021 09:44
@no1seman @DifferentialOrange
Improve descriptions support
fa59e22 
Support descriptions in InputObject fields. Include descriptions in
introspection output.

Based on PR #22 by @no1seman
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no1seman-descriptions_everywhere branch from 51b3bd9 to fa59e22 Compare December 1, 2021 12:37
@DifferentialOrange
Copy link
Member Author

DifferentialOrange commented Dec 1, 2021 •
edited
Loading

@Totktonada , @olegrok I removed kind fix to #31, now this PR contains only descriptions changes. So I kindly ask you to review this one more time.

@Totktonada Totktonada self-requested a review December 8, 2021 04:20
Totktonada
Totktonada approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Totktonada Totktonada merged commit e9590db into master Dec 14, 2021
@Totktonada Totktonada deleted the DifferentialOrange/no1seman-descriptions_everywhere branch December 14, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no1seman no1seman no1seman left review comments

@Totktonada Totktonada Totktonada approved these changes

@olegrok olegrok olegrok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DifferentialOrange @Totktonada @olegrok @no1seman