Skip to content

Remove unused allow attrs #143572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Remove unused allow attrs #143572

merged 1 commit into from
Jul 7, 2025

Conversation

yotamofek
Copy link
Contributor

These #[allow]s seem to be unused (at least according to x check, didn't run x test locally). Let's clean them up! 🧹

@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-rustdoc-json Area: Rustdoc JSON backend F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_llvm/src/llvm/enzyme_ffi.rs

cc @ZuseZ4

Some changes occurred in exhaustiveness checking

cc @Nadrieril

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yotamofek yotamofek force-pushed the pr/unused-allow-attrs branch from 3c47665 to 3b48407 Compare July 7, 2025 12:58
@yotamofek
Copy link
Contributor Author

Added back the #![allow(unused_crate_dependencies)] to rustc_pattern_analysis, dev dependencies are flagged as unused even when used by a test target, see #95513

@fee1-dead
Copy link
Member

r=me when CI is happy

@bors delegate+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

✌️ @yotamofek, you can now approve this pull request!

If @fee1-dead told you to "r=me" after making some further change, please make that change, then do @bors r=@fee1-dead

@yotamofek
Copy link
Contributor Author

@bors r=@fee1-dead

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

📌 Commit 3b48407 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 7, 2025
Merged
bors added a commit that referenced this pull request Jul 7, 2025
@bors
Auto merge of #143601 - matthiaskrgr:rollup-9iw2sqk, r=matthiaskrgr
a2d45f7 
Rollup of 9 pull requests

Successful merges:

 - #132469 (Do not suggest borrow that is already there in fully-qualified call)
 - #143340 (awhile -> a while where appropriate)
 - #143438 (Fix the link in `rustdoc.md`)
 - #143539 (Regression tests for repr ICEs)
 - #143566 (Fix `x86_64-unknown-netbsd` platform support page)
 - #143572 (Remove unused allow attrs)
 - #143583 (`loop_match`: fix 'no terminator on block')
 - #143584 (make `Machine::load_mir` infallible)
 - #143591 (Fix missing words in future tracking issue)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7ed6bd9 into rust-lang:master Jul 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 7, 2025
rust-timer added a commit that referenced this pull request Jul 7, 2025
@rust-timer
Unrolled build for #143572
666c95c 
Rollup merge of #143572 - yotamofek:pr/unused-allow-attrs, r=fee1-dead

Remove unused allow attrs

These `#[allow]`s seem to be unused (at least according to `x check`, didn't run `x test` locally). Let's clean them up! 🧹
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@fee1-dead fee1-dead

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-rustdoc-json Area: Rustdoc JSON backend F-autodiff `#![feature(autodiff)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yotamofek @rustbot @rust-log-analyzer @fee1-dead @bors @GuillaumeGomez